Hadoop Common
  1. Hadoop Common
  2. HADOOP-8917

add LOCALE.US to toLowerCase in SecurityUtil.replacePattern

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.2.0, 3.0.0
    • Fix Version/s: 1.2.0, 2.1.0-beta
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Webhdfs and fsck when getting the kerberos principal use Locale.US in toLowerCase. We should do the same in replacePattern as this method is used when service prinicpals log in.

      see https://issues.apache.org/jira/browse/HADOOP-8878?focusedCommentId=13472245&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13472245 for more details

      1. HADOOP-8917.branch-1.patch
        1 kB
        Arpit Gupta
      2. HADOOP-8917.patch
        1 kB
        Arpit Gupta

        Activity

        Arpit Gupta created issue -
        Hide
        Arpit Gupta added a comment -

        patch for branch-1. removed un used import as well. Will post the test patch results shortly.

        Show
        Arpit Gupta added a comment - patch for branch-1. removed un used import as well. Will post the test patch results shortly.
        Arpit Gupta made changes -
        Field Original Value New Value
        Attachment HADOOP-8917.branch-1.patch [ 12549199 ]
        Hide
        Arpit Gupta added a comment -

        patch for trunk

        Show
        Arpit Gupta added a comment - patch for trunk
        Arpit Gupta made changes -
        Attachment HADOOP-8917.patch [ 12549200 ]
        Arpit Gupta made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12549200/HADOOP-8917.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1628//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1628//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12549200/HADOOP-8917.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1628//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1628//console This message is automatically generated.
        Hide
        Arpit Gupta added a comment -

        no tests added as TestSecurityUtil already has appropriate coverage.

        Show
        Arpit Gupta added a comment - no tests added as TestSecurityUtil already has appropriate coverage.
        Hide
        Arpit Gupta added a comment -

        here the test patch output from branch-1

        [exec] 
             [exec] BUILD SUCCESSFUL
             [exec] Total time: 5 minutes 30 seconds
             [exec] 
             [exec] 
             [exec] 
             [exec] 
             [exec] -1 overall.  
             [exec] 
             [exec]     +1 @author.  The patch does not contain any @author tags.
             [exec] 
             [exec]     -1 tests included.  The patch doesn't appear to include any new or modified tests.
             [exec]                         Please justify why no tests are needed for this patch.
             [exec] 
             [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
             [exec] 
             [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
             [exec] 
             [exec]     -1 findbugs.  The patch appears to introduce 9 new Findbugs (version 1.3.9) warnings.
             [exec] 
             [exec] 
             [exec] 
             [exec] 
             [exec] ======================================================================
             [exec] ======================================================================
             [exec]     Finished build.
             [exec] ======================================================================
             [exec] ======================================================================
             [exec] 
             [exec] 
        
        

        find bugs warnings are not related to this patch and no tests were added as TestSecurityUtil has appropriate coverage

        Show
        Arpit Gupta added a comment - here the test patch output from branch-1 [exec] [exec] BUILD SUCCESSFUL [exec] Total time: 5 minutes 30 seconds [exec] [exec] [exec] [exec] [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no tests are needed for this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] -1 findbugs. The patch appears to introduce 9 new Findbugs (version 1.3.9) warnings. [exec] [exec] [exec] [exec] [exec] ====================================================================== [exec] ====================================================================== [exec] Finished build. [exec] ====================================================================== [exec] ====================================================================== [exec] [exec] find bugs warnings are not related to this patch and no tests were added as TestSecurityUtil has appropriate coverage
        Arpit Gupta made changes -
        Description see https://issues.apache.org/jira/browse/HADOOP-8878?focusedCommentId=13472245&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13472245 for more details Webhdfs and fsck when getting the kerberos principal use Locale.US in toLowerCase. We should do the same in replacePattern as this method is used when service prinicpals log in.

        see https://issues.apache.org/jira/browse/HADOOP-8878?focusedCommentId=13472245&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13472245 for more details
        Hide
        Suresh Srinivas added a comment -

        +1 for the patches. I will commit it shortly.

        Show
        Suresh Srinivas added a comment - +1 for the patches. I will commit it shortly.
        Hide
        Suresh Srinivas added a comment -

        I committed the patch to trunk, branch-2 and branch-1. Thank you Arpit!

        Show
        Suresh Srinivas added a comment - I committed the patch to trunk, branch-2 and branch-1. Thank you Arpit!
        Suresh Srinivas made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Fix Version/s 1.2.0 [ 12321659 ]
        Fix Version/s 2.0.4-beta [ 12324030 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-trunk-Commit #3386 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3386/)
        HADOOP-8917. add LOCALE.US to toLowerCase in SecurityUtil.replacePattern. Contributed by Arpit Agarwal. (Revision 1450571)

        Result = SUCCESS
        suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1450571
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java
        Show
        Hudson added a comment - Integrated in Hadoop-trunk-Commit #3386 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3386/ ) HADOOP-8917 . add LOCALE.US to toLowerCase in SecurityUtil.replacePattern. Contributed by Arpit Agarwal. (Revision 1450571) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1450571 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-trunk-Commit #3387 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3387/)
        HADOOP-8917. Changed contributed by from Arpit Agarwal to Arpit Gupta. (Revision 1450575)

        Result = SUCCESS
        suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1450575
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-trunk-Commit #3387 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3387/ ) HADOOP-8917 . Changed contributed by from Arpit Agarwal to Arpit Gupta. (Revision 1450575) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1450575 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Yarn-trunk #140 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/140/)
        HADOOP-8917. Changed contributed by from Arpit Agarwal to Arpit Gupta. (Revision 1450575)
        HADOOP-8917. add LOCALE.US to toLowerCase in SecurityUtil.replacePattern. Contributed by Arpit Agarwal. (Revision 1450571)

        Result = SUCCESS
        suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1450575
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt

        suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1450571
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java
        Show
        Hudson added a comment - Integrated in Hadoop-Yarn-trunk #140 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/140/ ) HADOOP-8917 . Changed contributed by from Arpit Agarwal to Arpit Gupta. (Revision 1450575) HADOOP-8917 . add LOCALE.US to toLowerCase in SecurityUtil.replacePattern. Contributed by Arpit Agarwal. (Revision 1450571) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1450575 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1450571 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1329 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1329/)
        HADOOP-8917. Changed contributed by from Arpit Agarwal to Arpit Gupta. (Revision 1450575)
        HADOOP-8917. add LOCALE.US to toLowerCase in SecurityUtil.replacePattern. Contributed by Arpit Agarwal. (Revision 1450571)

        Result = SUCCESS
        suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1450575
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt

        suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1450571
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1329 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1329/ ) HADOOP-8917 . Changed contributed by from Arpit Agarwal to Arpit Gupta. (Revision 1450575) HADOOP-8917 . add LOCALE.US to toLowerCase in SecurityUtil.replacePattern. Contributed by Arpit Agarwal. (Revision 1450571) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1450575 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1450571 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1357 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1357/)
        HADOOP-8917. Changed contributed by from Arpit Agarwal to Arpit Gupta. (Revision 1450575)
        HADOOP-8917. add LOCALE.US to toLowerCase in SecurityUtil.replacePattern. Contributed by Arpit Agarwal. (Revision 1450571)

        Result = SUCCESS
        suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1450575
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt

        suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1450571
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1357 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1357/ ) HADOOP-8917 . Changed contributed by from Arpit Agarwal to Arpit Gupta. (Revision 1450575) HADOOP-8917 . add LOCALE.US to toLowerCase in SecurityUtil.replacePattern. Contributed by Arpit Agarwal. (Revision 1450571) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1450575 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1450571 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java
        Hide
        Matt Foley added a comment -

        Closed upon release of Hadoop 1.2.0.

        Show
        Matt Foley added a comment - Closed upon release of Hadoop 1.2.0.
        Matt Foley made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        4d 4h 49m 1 Arpit Gupta 15/Oct/12 20:31
        Patch Available Patch Available Resolved Resolved
        134d 5h 8m 1 Suresh Srinivas 27/Feb/13 01:40
        Resolved Resolved Closed Closed
        77d 3h 35m 1 Matt Foley 15/May/13 05:15

          People

          • Assignee:
            Arpit Gupta
            Reporter:
            Arpit Gupta
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development