Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.2.0
    • Fix Version/s: 1.2.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The original patch was only partially back ported to branch-1. This JIRA is to back port the rest of it.

      1. HADOOP-8832.branch-1.patch.all
        9 kB
        Brandon Li
      2. HADOOP-8832.branch-1.patch
        3 kB
        Brandon Li
      3. HADOOP-8832.branch-1.patch
        5 kB
        Brandon Li

        Issue Links

          Activity

          Hide
          Todd Lipcon added a comment -

          Hey Brandon. Can you please explain the use case you're targeting?

          Show
          Todd Lipcon added a comment - Hey Brandon. Can you please explain the use case you're targeting?
          Hide
          Brandon Li added a comment -

          As stated in HADOOP-5357: "Adding support for pluggable components would allow exporting DFS functionallity using arbitrary protocols", to start custom services.

          Show
          Brandon Li added a comment - As stated in HADOOP-5357 : "Adding support for pluggable components would allow exporting DFS functionallity using arbitrary protocols", to start custom services.
          Hide
          Brandon Li added a comment -

          For Hadoop Common, we actually only need to back port the test TestGetInstances. Changed the title accordingly.

          Show
          Brandon Li added a comment - For Hadoop Common, we actually only need to back port the test TestGetInstances. Changed the title accordingly.
          Hide
          Todd Lipcon added a comment -

          The original motivation of the issue was to expose DFS protocols via Thrift. But now that we have protobufs in place, it seems less useful. Do you have a particular service or protocol that you're looking to expose?

          Show
          Todd Lipcon added a comment - The original motivation of the issue was to expose DFS protocols via Thrift. But now that we have protobufs in place, it seems less useful. Do you have a particular service or protocol that you're looking to expose?
          Hide
          Brandon Li added a comment -

          We want to use this to start some custom services. Since this is already in trunk and seems to be a good way to achieve that. Half of its functionality is already in branch-1. Do you have any concerns with it? The backport seems pretty straightforward to me.

          Show
          Brandon Li added a comment - We want to use this to start some custom services. Since this is already in trunk and seems to be a good way to achieve that. Half of its functionality is already in branch-1. Do you have any concerns with it? The backport seems pretty straightforward to me.
          Hide
          Suresh Srinivas added a comment -

          Brandon, ServicePlugin is also required with the patch.

          May be your development area for branch-1 has it, but the apache branch-1 does not.

          Show
          Suresh Srinivas added a comment - Brandon, ServicePlugin is also required with the patch. May be your development area for branch-1 has it, but the apache branch-1 does not.
          Hide
          Brandon Li added a comment -

          my bad The change from original patch already in branch-1 is the change in Configuration.java. ServicePlugin is not there yet.

          Show
          Brandon Li added a comment - my bad The change from original patch already in branch-1 is the change in Configuration.java. ServicePlugin is not there yet.
          Hide
          Todd Lipcon added a comment -

          I don't have any particular concerns, I just like to understand motivation behind spending time backporting things into 1.0 rather than spending time on forward development. So, consider me curious, not hostile

          Show
          Todd Lipcon added a comment - I don't have any particular concerns, I just like to understand motivation behind spending time backporting things into 1.0 rather than spending time on forward development. So, consider me curious, not hostile
          Hide
          Brandon Li added a comment -

          No problem. I understand.

          Show
          Brandon Li added a comment - No problem. I understand.
          Hide
          Suresh Srinivas added a comment - - edited

          Brandon, can you post separate jiras/patches for hdfs and common.

          Show
          Suresh Srinivas added a comment - - edited Brandon, can you post separate jiras/patches for hdfs and common.
          Hide
          Brandon Li added a comment -

          Uploaded a patch for common only.

          Show
          Brandon Li added a comment - Uploaded a patch for common only.
          Hide
          Eli Collins added a comment -

          Linking in HADOOP-5640 since it's related.

          @Brandon, out of curiosity, what custom services do you want to run?

          Show
          Eli Collins added a comment - Linking in HADOOP-5640 since it's related. @Brandon, out of curiosity, what custom services do you want to run?
          Hide
          Suresh Srinivas added a comment -

          out of curiosity, what custom services do you want to run?

          Eli this is a generic mechianism to start some services. How does it matter what custom services?

          Show
          Suresh Srinivas added a comment - out of curiosity, what custom services do you want to run? Eli this is a generic mechianism to start some services. How does it matter what custom services?
          Hide
          Suresh Srinivas added a comment -

          +1 for the patch.

          Show
          Suresh Srinivas added a comment - +1 for the patch.
          Hide
          Suresh Srinivas added a comment -

          I committed the patch. Thank you Brandon for back porting the patch.

          Show
          Suresh Srinivas added a comment - I committed the patch. Thank you Brandon for back porting the patch.
          Hide
          Eli Collins added a comment -

          Eli this is a generic mechianism to start some services. How does it matter what custom services?

          Per above, I'm just curious. In general it's good to understand how something is going to be used. If Brandon doesn't want to explain the motivation for his work that's his prerogative of course.

          Show
          Eli Collins added a comment - Eli this is a generic mechianism to start some services. How does it matter what custom services? Per above, I'm just curious. In general it's good to understand how something is going to be used. If Brandon doesn't want to explain the motivation for his work that's his prerogative of course.
          Hide
          Brandon Li added a comment -

          @Eli, a few of our customers want to use this to start some custom services specific to their own setup.

          Show
          Brandon Li added a comment - @Eli, a few of our customers want to use this to start some custom services specific to their own setup.
          Hide
          Matt Foley added a comment -

          Closed upon release of Hadoop 1.2.0.

          Show
          Matt Foley added a comment - Closed upon release of Hadoop 1.2.0.

            People

            • Assignee:
              Brandon Li
              Reporter:
              Brandon Li
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development