Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-8789

Tests setLevel(Level.OFF) should be Level.ERROR

VotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.0.1-alpha
    • 2.0.3-alpha, 0.23.5
    • test
    • None
    • Reviewed

    Description

      Multiple tests have code like

      ((Log4JLogger)LogFactory.getLog(FSNamesystem.class)).getLogger().setLevel(Level.OFF);
      

      Completely disabling logs from given classes with Level.OFF is a bad idea and makes debugging other test failures, especially intermittent test failures like HDFS-3664, difficult. Instead the code should use Level.ERROR to reduce verbosity.

      Attachments

        1. hdfs-3911.txt
          3 kB
          Andy Isaacson

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            adi2 Andy Isaacson
            adi2 Andy Isaacson
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Issue deployment