Hadoop Common
  1. Hadoop Common
  2. HADOOP-8766

FileContextMainOperationsBaseTest should randomize the root dir

        Details

        • Type: Bug Bug
        • Status: Closed
        • Priority: Major Major
        • Resolution: Fixed
        • Affects Version/s: 2.0.0-alpha
        • Fix Version/s: 2.0.2-alpha
        • Component/s: test
        • Labels:

          Description

          FileContextMainOperationsBaseTest should randomize the name of the root directory it creates. It currently hardcodes LOCAL_FS_ROOT_URI to /tmp/test.

          This causes the job to fail if it clashes with another jobs that also uses that path. Eg

          org.apache.hadoop.fs.FileAlreadyExistsException: Parent path is not a directory: file:/tmp/test
        at org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:362)
        at org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:373)
        at org.apache.hadoop.fs.FileSystem.primitiveMkdir(FileSystem.java:931)
        at org.apache.hadoop.fs.DelegateToFileSystem.mkdir(DelegateToFileSystem.java:143)
        at org.apache.hadoop.fs.FilterFs.mkdir(FilterFs.java:189)
        at org.apache.hadoop.fs.FileContext$4.next(FileContext.java:706)
        at org.apache.hadoop.fs.FileContext$4.next(FileContext.java:703)
        at org.apache.hadoop.fs.FileContext$FSLinkResolver.resolve(FileContext.java:2333)
        at org.apache.hadoop.fs.FileContext.mkdir(FileContext.java:703)
        at org.apache.hadoop.fs.FileContextMainOperationsBaseTest.testWorkingDirectory(FileContextMainOperationsBaseTest.java:178)
          1. Text File
            HADOOP-8766.001.patch
            2 kB
            Colin Patrick McCabe

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            Colin Patrick McCabe added a comment -

            It's easier just to use System.getProperty("test.build.data"). (that's the approach I took here)

            Show
            Colin Patrick McCabe added a comment - It's easier just to use System.getProperty("test.build.data") . (that's the approach I took here)
            Hide
            Permalink
            Hadoop QA added a comment -

            -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12543905/HADOOP-8766.001.patch
            against trunk revision .

            +1 @author. The patch does not contain any @author tags.

            +1 tests included. The patch appears to include 1 new or modified test files.

            +1 javac. The applied patch does not increase the total number of javac compiler warnings.

            +1 javadoc. The javadoc tool did not generate any warning messages.

            +1 eclipse:eclipse. The patch built with eclipse:eclipse.

            +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

            +1 release audit. The applied patch does not increase the total number of release audit warnings.

            -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common:

            org.apache.hadoop.ha.TestZKFailoverController

            +1 contrib tests. The patch passed contrib unit tests.

            Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1407//testReport/
            Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1407//console

            This message is automatically generated.

            Show
            Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12543905/HADOOP-8766.001.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common: org.apache.hadoop.ha.TestZKFailoverController +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1407//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1407//console This message is automatically generated.
            Hide
            Permalink
            Aaron T. Myers added a comment -

            +1, the patch looks good to me. I'm going to commit this momentarily.

            Show
            Aaron T. Myers added a comment - +1, the patch looks good to me. I'm going to commit this momentarily.
            Hide
            Permalink
            Aaron T. Myers added a comment -

            I've just committed this to trunk and branch-2.

            Thanks a lot for the contribution, Colin.

            Show
            Aaron T. Myers added a comment - I've just committed this to trunk and branch-2. Thanks a lot for the contribution, Colin.
            Hide
            Permalink
            Hudson added a comment -

            Integrated in Hadoop-Hdfs-trunk-Commit #2752 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2752/)
            HADOOP-8766. FileContextMainOperationsBaseTest should randomize the root dir. Contributed by Colin Patrick McCabe. (Revision 1381437)

            Result = SUCCESS
            atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1381437
            Files :

            • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
            • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/FileContextMainOperationsBaseTest.java
            Show
            Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2752 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2752/ ) HADOOP-8766 . FileContextMainOperationsBaseTest should randomize the root dir. Contributed by Colin Patrick McCabe. (Revision 1381437) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1381437 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/FileContextMainOperationsBaseTest.java
            Hide
            Permalink
            Hudson added a comment -

            Integrated in Hadoop-Common-trunk-Commit #2689 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2689/)
            HADOOP-8766. FileContextMainOperationsBaseTest should randomize the root dir. Contributed by Colin Patrick McCabe. (Revision 1381437)

            Result = SUCCESS
            atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1381437
            Files :

            • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
            • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/FileContextMainOperationsBaseTest.java
            Show
            Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2689 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2689/ ) HADOOP-8766 . FileContextMainOperationsBaseTest should randomize the root dir. Contributed by Colin Patrick McCabe. (Revision 1381437) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1381437 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/FileContextMainOperationsBaseTest.java
            Hide
            Permalink
            Hudson added a comment -

            Integrated in Hadoop-Mapreduce-trunk-Commit #2713 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2713/)
            HADOOP-8766. FileContextMainOperationsBaseTest should randomize the root dir. Contributed by Colin Patrick McCabe. (Revision 1381437)

            Result = FAILURE
            atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1381437
            Files :

            • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
            • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/FileContextMainOperationsBaseTest.java
            Show
            Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2713 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2713/ ) HADOOP-8766 . FileContextMainOperationsBaseTest should randomize the root dir. Contributed by Colin Patrick McCabe. (Revision 1381437) Result = FAILURE atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1381437 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/FileContextMainOperationsBaseTest.java
            Hide
            Permalink
            Hudson added a comment -

            Integrated in Hadoop-Hdfs-trunk #1157 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1157/)
            HADOOP-8766. FileContextMainOperationsBaseTest should randomize the root dir. Contributed by Colin Patrick McCabe. (Revision 1381437)

            Result = FAILURE
            atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1381437
            Files :

            • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
            • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/FileContextMainOperationsBaseTest.java
            Show
            Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1157 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1157/ ) HADOOP-8766 . FileContextMainOperationsBaseTest should randomize the root dir. Contributed by Colin Patrick McCabe. (Revision 1381437) Result = FAILURE atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1381437 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/FileContextMainOperationsBaseTest.java
            Hide
            Permalink
            Hudson added a comment -

            Integrated in Hadoop-Mapreduce-trunk #1188 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1188/)
            HADOOP-8766. FileContextMainOperationsBaseTest should randomize the root dir. Contributed by Colin Patrick McCabe. (Revision 1381437)

            Result = ABORTED
            atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1381437
            Files :

            • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
            • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/FileContextMainOperationsBaseTest.java
            Show
            Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1188 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1188/ ) HADOOP-8766 . FileContextMainOperationsBaseTest should randomize the root dir. Contributed by Colin Patrick McCabe. (Revision 1381437) Result = ABORTED atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1381437 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/FileContextMainOperationsBaseTest.java

              People

              • Assignee:
                Colin Patrick McCabe
                Reporter:
                Eli Collins
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development