Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.2-alpha
    • Fix Version/s: 2.0.2-alpha
    • Component/s: build
    • Labels:
      None
    • Environment:
    • Hadoop Flags:
      Reviewed

      Description

      ARM build is broken again: CMAKE_SYSTEM_PROCESSOR comes from uname -p, which reports values like "armv7l" for the ARMv7 architecture. However, the OpenJDK and Oracle ARM JREs both use "jre/lib/arm" for the JVM directory.

      1. HADOOP-8764.patch
        0.7 kB
        Trevor Robinson

        Issue Links

          Activity

          Trevor Robinson created issue -
          Trevor Robinson made changes -
          Field Original Value New Value
          Link This issue relates to HADOOP-8737 [ HADOOP-8737 ]
          Trevor Robinson made changes -
          Attachment HADOOP-8764.patch [ 12543798 ]
          Hide
          Trevor Robinson added a comment -

          Added processor architecture decode case for ARM similar to x86:

              ELSEIF (CMAKE_SYSTEM_PROCESSOR MATCHES "^arm")
                  SET(_java_libarch "arm")
          
          Show
          Trevor Robinson added a comment - Added processor architecture decode case for ARM similar to x86: ELSEIF (CMAKE_SYSTEM_PROCESSOR MATCHES "^arm" ) SET(_java_libarch "arm" )
          Trevor Robinson made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Assignee Trevor Robinson [ scurrilous ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12543798/HADOOP-8764.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1399//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1399//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12543798/HADOOP-8764.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1399//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1399//console This message is automatically generated.
          Hide
          Eli Collins added a comment -

          +1 lgtm

          Show
          Eli Collins added a comment - +1 lgtm
          Hide
          Eli Collins added a comment -

          Btw I created a jenkins job to run on the Apache ARM machines to capture future breakages:

          https://builds.apache.org/job/Hadoop-trunk-ARM/

          Show
          Eli Collins added a comment - Btw I created a jenkins job to run on the Apache ARM machines to capture future breakages: https://builds.apache.org/job/Hadoop-trunk-ARM/
          Hide
          Eli Collins added a comment -

          I've committed this and merged to branch-2. Thanks Trevor!

          Show
          Eli Collins added a comment - I've committed this and merged to branch-2. Thanks Trevor!
          Eli Collins made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags Reviewed [ 10343 ]
          Fix Version/s 2.2.0-alpha [ 12322473 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #2682 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2682/)
          HADOOP-8764. CMake: HADOOP-8737 broke ARM build. Contributed by Trevor Robinson (Revision 1380984)

          Result = SUCCESS
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1380984
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/JNIFlags.cmake
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2682 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2682/ ) HADOOP-8764 . CMake: HADOOP-8737 broke ARM build. Contributed by Trevor Robinson (Revision 1380984) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1380984 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/JNIFlags.cmake
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #2745 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2745/)
          HADOOP-8764. CMake: HADOOP-8737 broke ARM build. Contributed by Trevor Robinson (Revision 1380984)

          Result = SUCCESS
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1380984
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/JNIFlags.cmake
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2745 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2745/ ) HADOOP-8764 . CMake: HADOOP-8737 broke ARM build. Contributed by Trevor Robinson (Revision 1380984) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1380984 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/JNIFlags.cmake
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #2706 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2706/)
          HADOOP-8764. CMake: HADOOP-8737 broke ARM build. Contributed by Trevor Robinson (Revision 1380984)

          Result = FAILURE
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1380984
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/JNIFlags.cmake
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2706 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2706/ ) HADOOP-8764 . CMake: HADOOP-8737 broke ARM build. Contributed by Trevor Robinson (Revision 1380984) Result = FAILURE eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1380984 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/JNIFlags.cmake
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #1156 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1156/)
          HADOOP-8764. CMake: HADOOP-8737 broke ARM build. Contributed by Trevor Robinson (Revision 1380984)

          Result = SUCCESS
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1380984
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/JNIFlags.cmake
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1156 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1156/ ) HADOOP-8764 . CMake: HADOOP-8737 broke ARM build. Contributed by Trevor Robinson (Revision 1380984) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1380984 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/JNIFlags.cmake
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1187 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1187/)
          HADOOP-8764. CMake: HADOOP-8737 broke ARM build. Contributed by Trevor Robinson (Revision 1380984)

          Result = SUCCESS
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1380984
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/JNIFlags.cmake
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1187 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1187/ ) HADOOP-8764 . CMake: HADOOP-8737 broke ARM build. Contributed by Trevor Robinson (Revision 1380984) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1380984 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/JNIFlags.cmake
          Hide
          Colin Patrick McCabe added a comment -

          This patch looks reasonable to me (although I do not have an ARM device to test on).

          Thanks for looking at this, Trevor.

          Show
          Colin Patrick McCabe added a comment - This patch looks reasonable to me (although I do not have an ARM device to test on). Thanks for looking at this, Trevor.
          Arun C Murthy made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          5m 10s 1 Trevor Robinson 05/Sep/12 04:17
          Patch Available Patch Available Resolved Resolved
          1h 23m 1 Eli Collins 05/Sep/12 05:41
          Resolved Resolved Closed Closed
          36d 13h 3m 1 Arun C Murthy 11/Oct/12 18:45

            People

            • Assignee:
              Trevor Robinson
              Reporter:
              Trevor Robinson
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development