[HADOOP-8757] Metrics should disallow names with invalid characters

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0.0-alpha, 3.0.0-alpha1
• Fix Version/s: 2.7.0
• Component/s: metrics
• Labels: newbie
• Hadoop Flags: Reviewed
• Assignee: Ray Chiang
• Reporter: Todd Lipcon
• Created: 01/Sep/12 01:48
• Updated: 12/May/16 18:22
• Resolved: 15/Jan/15 19:42

Description

Just spent a couple hours trying to figure out why a metric I added didn't show up in JMX, only to eventually realize it was because I had a whitespace in the property name. This didn't cause any errors to be logged – the metric just didn't show up in JMX. We should check that the name is valid and log an error, or replace invalid characters with something like an underscore.