Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-8757

Metrics should disallow names with invalid characters

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-alpha, 3.0.0-alpha1
    • Fix Version/s: 2.7.0
    • Component/s: metrics
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      Just spent a couple hours trying to figure out why a metric I added didn't show up in JMX, only to eventually realize it was because I had a whitespace in the property name. This didn't cause any errors to be logged – the metric just didn't show up in JMX. We should check that the name is valid and log an error, or replace invalid characters with something like an underscore.

        Attachments

        1. HADOOP-8757.003.patch
          4 kB
          Ray Chiang
        2. HADOOP-8757-02.patch
          4 kB
          Ray Chiang
        3. HADOOP-8757-01.patch
          4 kB
          Ray Chiang

          Activity

            People

            • Assignee:
              rchiang Ray Chiang
              Reporter:
              tlipcon Todd Lipcon
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: