Hadoop Common
  1. Hadoop Common
  2. HADOOP-8756

Fix SEGV when libsnappy is in java.library.path but not LD_LIBRARY_PATH

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.2-alpha
    • Fix Version/s: 2.0.3-alpha
    • Component/s: native
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      We use System.loadLibrary("snappy") from the Java side. However in libhadoop, we use dlopen to open libsnappy.so dynamically. System.loadLibrary uses java.library.path to resolve libraries, and dlopen uses LD_LIBRARY_PATH and the system paths to resolve libraries. Because of this, the two library loading functions can be at odds.

      We should fix this so we only load the library once, preferably using the standard Java java.library.path.

      We should also log the search path(s) we use for libsnappy.so when loading fails, so that it's easier to diagnose configuration issues.

      1. HADOOP-8756.004.patch
        16 kB
        Colin Patrick McCabe
      2. HADOOP-8756.003.patch
        16 kB
        Colin Patrick McCabe
      3. HADOOP-8756.002.patch
        13 kB
        Colin Patrick McCabe

        Issue Links

          Activity

          Hide
          Colin Patrick McCabe added a comment -
          • remove HADOOP_RUNAS_HOME (runAs has been removed)
          • remove SnappyCodec.java. Instead, load the native code from SnappyCompressor.java and SnappyDecompressor.java. This is similar to the way the zlib stuff works now.
          • If we try to instantiate SnappyCodec, but snappy is not loaded, throw an exception. Formerly, we might get undefined behavior like segfaults in this case.
          • Be more helpful about why snappy could not be loaded: was it because the build was compiled without snappy? Or some other reason found in the exception thrown from SnappyDecompressor#initIDs or SnappyCompressor#initIDs?
          • We don't need to call System.loadLibrary("snappy"). It's irrelevant because libsnappy is not a JNI library. Again, zlib shows how this should be done: just use dlopen, not System.loadLibrary. Note that calliing System.loadLibrary does not make the symbols visible to libhadoop.so because the JVM does not use RTLD_GLOBAL.
          Show
          Colin Patrick McCabe added a comment - remove HADOOP_RUNAS_HOME (runAs has been removed) remove SnappyCodec.java. Instead, load the native code from SnappyCompressor.java and SnappyDecompressor.java. This is similar to the way the zlib stuff works now. If we try to instantiate SnappyCodec, but snappy is not loaded, throw an exception. Formerly, we might get undefined behavior like segfaults in this case. Be more helpful about why snappy could not be loaded: was it because the build was compiled without snappy? Or some other reason found in the exception thrown from SnappyDecompressor#initIDs or SnappyCompressor#initIDs ? We don't need to call System.loadLibrary("snappy") . It's irrelevant because libsnappy is not a JNI library. Again, zlib shows how this should be done: just use dlopen , not System.loadLibrary . Note that calliing System.loadLibrary does not make the symbols visible to libhadoop.so because the JVM does not use RTLD_GLOBAL .
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12544127/HADOOP-8756.002.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common:

          org.apache.hadoop.ha.TestZKFailoverController
          org.apache.hadoop.io.compress.TestCodec
          org.apache.hadoop.io.compress.TestCodecFactory

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1418//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1418//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12544127/HADOOP-8756.002.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common: org.apache.hadoop.ha.TestZKFailoverController org.apache.hadoop.io.compress.TestCodec org.apache.hadoop.io.compress.TestCodecFactory +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1418//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1418//console This message is automatically generated.
          Hide
          Colin Patrick McCabe added a comment -

          We previously allowed Codecs to be constructed even if they couldn't be used; the tests relied on this. So let's keep the old behavior for now.

          Show
          Colin Patrick McCabe added a comment - We previously allowed Codecs to be constructed even if they couldn't be used; the tests relied on this. So let's keep the old behavior for now.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12544147/HADOOP-8756.003.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common:

          org.apache.hadoop.ha.TestZKFailoverController

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1420//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1420//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12544147/HADOOP-8756.003.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common: org.apache.hadoop.ha.TestZKFailoverController +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1420//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1420//console This message is automatically generated.
          Hide
          Ahmed Radwan added a comment -

          The TestZKFailoverController failures seems unrelated (see HADOOP-8591).

          Show
          Ahmed Radwan added a comment - The TestZKFailoverController failures seems unrelated (see HADOOP-8591 ).
          Hide
          Andy Isaacson added a comment -
          @@ -295,4 +298,5 @@ public class SnappyCompressor implements Compressor {
             private native static void initIDs();
           
             private native int compressBytesDirect();
          +
           }
          

          Unneeded whitespace change.

          Other than that, the patch looks right and is a nice conceptual cleanup as well as fixing the SEGV. +1.

          Show
          Andy Isaacson added a comment - @@ -295,4 +298,5 @@ public class SnappyCompressor implements Compressor { private native static void initIDs(); private native int compressBytesDirect(); + } Unneeded whitespace change. Other than that, the patch looks right and is a nice conceptual cleanup as well as fixing the SEGV. +1.
          Hide
          Colin Patrick McCabe added a comment -
          • fix whitespace
          Show
          Colin Patrick McCabe added a comment - fix whitespace
          Hide
          Roman Shaposhnik added a comment -

          This seems to be related to the HADOOP-8781. Just to make sure – is the patches posted to this JIRA meant to provide an alternative fix for the issue that won't require us changing the value of LD_LIBRARY_PATH ? If so, shouldn't your patches include the changes that would restore the old behavior?

          Show
          Roman Shaposhnik added a comment - This seems to be related to the HADOOP-8781 . Just to make sure – is the patches posted to this JIRA meant to provide an alternative fix for the issue that won't require us changing the value of LD_LIBRARY_PATH ? If so, shouldn't your patches include the changes that would restore the old behavior?
          Hide
          Colin Patrick McCabe added a comment -

          Just to make sure – is the patches posted to this JIRA meant to provide an alternative fix for the issue that won't require us changing the value of LD_LIBRARY_PATH

          No, you will still need to set LD_LIBRARY_PATH. The patch could be revised to manually search java.library.path, I guess. Would that be worthwhile?

          If so, shouldn't your patches include the changes that would restore the old behavior?

          The behavior hasn't changed. You always needed to have libsnappy.so in your LD_LIBRARY_PATH or system library path in order to load it with dlopen.

          Show
          Colin Patrick McCabe added a comment - Just to make sure – is the patches posted to this JIRA meant to provide an alternative fix for the issue that won't require us changing the value of LD_LIBRARY_PATH No, you will still need to set LD_LIBRARY_PATH . The patch could be revised to manually search java.library.path , I guess. Would that be worthwhile? If so, shouldn't your patches include the changes that would restore the old behavior? The behavior hasn't changed. You always needed to have libsnappy.so in your LD_LIBRARY_PATH or system library path in order to load it with dlopen .
          Hide
          Roman Shaposhnik added a comment -

          The patch could be revised to manually search java.library.path, I guess. Would that be worthwhile?

          Well, my concern is around all the clients that don't use hadoop launcher script but need to access snappy codec on the client side. Flume would be a good example here: since it launches the JVM directly it has to also makes sure it sets up LD_LIBRARY_PATH if we don't provide the manual search capability in core hadoop itself.

          I guess what I'm trying to say is that we have to have a solution for things like Flume. It would be nice if it worked automagically.

          Show
          Roman Shaposhnik added a comment - The patch could be revised to manually search java.library.path, I guess. Would that be worthwhile? Well, my concern is around all the clients that don't use hadoop launcher script but need to access snappy codec on the client side. Flume would be a good example here: since it launches the JVM directly it has to also makes sure it sets up LD_LIBRARY_PATH if we don't provide the manual search capability in core hadoop itself. I guess what I'm trying to say is that we have to have a solution for things like Flume. It would be nice if it worked automagically.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12544869/HADOOP-8756.004.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common:

          org.apache.hadoop.ha.TestZKFailoverController

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1444//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1444//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12544869/HADOOP-8756.004.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common: org.apache.hadoop.ha.TestZKFailoverController +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1444//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1444//console This message is automatically generated.
          Hide
          Colin Patrick McCabe added a comment -

          Roman:

          It would be nice if it [searched java.library.path]

          Let's file a separate JIRA for that. It's not really related to this JIRA, which is just about fixing a segfault. Smaller patches are easier for people to review, as well.

          Show
          Colin Patrick McCabe added a comment - Roman: It would be nice if it [searched java.library.path] Let's file a separate JIRA for that. It's not really related to this JIRA, which is just about fixing a segfault. Smaller patches are easier for people to review, as well.
          Hide
          Colin Patrick McCabe added a comment -

          Filed HADOOP-8806 to discuss searching java.library.path

          Show
          Colin Patrick McCabe added a comment - Filed HADOOP-8806 to discuss searching java.library.path
          Hide
          Andy Isaacson added a comment -

          +1

          I've reviewed HADOOP-8756.004.patch and I have no further issues. This is a good localized fix that is not dependent on nor obsoleted by the other patches under discussion or checked in. Without this patch a local "mvn -Pnative,dist clean package -Dmaven.javadoc.skip=true -DskipTests; mvn test -Dtest=TestCodec" fails.

          Running org.apache.hadoop.io.compress.TestCodec
          Tests run: 21, Failures: 1, Errors: 0, Skipped: 1, Time elapsed: 15.956 sec <<< FAILURE!
          
          Results :
          
          Failed tests:   testSnappyCodec(org.apache.hadoop.io.compress.TestCodec): Snappy native available but Hadoop native not
          
          Show
          Andy Isaacson added a comment - +1 I've reviewed HADOOP-8756 .004.patch and I have no further issues. This is a good localized fix that is not dependent on nor obsoleted by the other patches under discussion or checked in. Without this patch a local "mvn -Pnative,dist clean package -Dmaven.javadoc.skip=true -DskipTests; mvn test -Dtest=TestCodec" fails. Running org.apache.hadoop.io.compress.TestCodec Tests run: 21, Failures: 1, Errors: 0, Skipped: 1, Time elapsed: 15.956 sec <<< FAILURE! Results : Failed tests: testSnappyCodec(org.apache.hadoop.io.compress.TestCodec): Snappy native available but Hadoop native not
          Hide
          Eli Collins added a comment -

          +1 looks good to me as well

          For those who haven't been following along, we're segfaulting because the compressor/decompressor ignore failures in initIDS, we now detect this failure and check for it in SnappyCodec so we don't run with snappy when we failed to load it. We still require that libsnappy is present in LD_LIBRARY_PATH (HADOOP-8806 improves how it is located).

          Show
          Eli Collins added a comment - +1 looks good to me as well For those who haven't been following along, we're segfaulting because the compressor/decompressor ignore failures in initIDS, we now detect this failure and check for it in SnappyCodec so we don't run with snappy when we failed to load it. We still require that libsnappy is present in LD_LIBRARY_PATH ( HADOOP-8806 improves how it is located).
          Hide
          Eli Collins added a comment -

          Forgot to mention, I verified hadoop fs catting a snappy file works with a build with snappy bundled in.

          Show
          Eli Collins added a comment - Forgot to mention, I verified hadoop fs catting a snappy file works with a build with snappy bundled in.
          Hide
          Eli Collins added a comment -

          I've committed this and merged to branch-2. Thanks Colin!

          Show
          Eli Collins added a comment - I've committed this and merged to branch-2. Thanks Colin!
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #2865 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2865/)
          HADOOP-8756. Fix SEGV when libsnappy is in java.library.path but not LD_LIBRARY_PATH. Contributed by Colin Patrick McCabe (Revision 1393243)

          Result = SUCCESS
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1393243
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/CMakeLists.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/config.h.cmake
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/SnappyCodec.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/snappy/LoadSnappy.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/snappy/SnappyCompressor.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/snappy/SnappyDecompressor.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/NativeCodeLoader.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/util/NativeCodeLoader.c
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodec.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2865 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2865/ ) HADOOP-8756 . Fix SEGV when libsnappy is in java.library.path but not LD_LIBRARY_PATH. Contributed by Colin Patrick McCabe (Revision 1393243) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1393243 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/CMakeLists.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/config.h.cmake /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/SnappyCodec.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/snappy/LoadSnappy.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/snappy/SnappyCompressor.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/snappy/SnappyDecompressor.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/NativeCodeLoader.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/util/NativeCodeLoader.c /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodec.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #2803 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2803/)
          HADOOP-8756. Fix SEGV when libsnappy is in java.library.path but not LD_LIBRARY_PATH. Contributed by Colin Patrick McCabe (Revision 1393243)

          Result = SUCCESS
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1393243
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/CMakeLists.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/config.h.cmake
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/SnappyCodec.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/snappy/LoadSnappy.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/snappy/SnappyCompressor.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/snappy/SnappyDecompressor.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/NativeCodeLoader.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/util/NativeCodeLoader.c
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodec.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2803 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2803/ ) HADOOP-8756 . Fix SEGV when libsnappy is in java.library.path but not LD_LIBRARY_PATH. Contributed by Colin Patrick McCabe (Revision 1393243) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1393243 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/CMakeLists.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/config.h.cmake /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/SnappyCodec.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/snappy/LoadSnappy.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/snappy/SnappyCompressor.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/snappy/SnappyDecompressor.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/NativeCodeLoader.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/util/NativeCodeLoader.c /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodec.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #2826 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2826/)
          HADOOP-8756. Fix SEGV when libsnappy is in java.library.path but not LD_LIBRARY_PATH. Contributed by Colin Patrick McCabe (Revision 1393243)

          Result = FAILURE
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1393243
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/CMakeLists.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/config.h.cmake
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/SnappyCodec.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/snappy/LoadSnappy.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/snappy/SnappyCompressor.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/snappy/SnappyDecompressor.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/NativeCodeLoader.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/util/NativeCodeLoader.c
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodec.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2826 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2826/ ) HADOOP-8756 . Fix SEGV when libsnappy is in java.library.path but not LD_LIBRARY_PATH. Contributed by Colin Patrick McCabe (Revision 1393243) Result = FAILURE eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1393243 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/CMakeLists.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/config.h.cmake /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/SnappyCodec.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/snappy/LoadSnappy.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/snappy/SnappyCompressor.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/snappy/SnappyDecompressor.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/NativeCodeLoader.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/util/NativeCodeLoader.c /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodec.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #1184 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1184/)
          HADOOP-8756. Fix SEGV when libsnappy is in java.library.path but not LD_LIBRARY_PATH. Contributed by Colin Patrick McCabe (Revision 1393243)

          Result = SUCCESS
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1393243
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/CMakeLists.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/config.h.cmake
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/SnappyCodec.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/snappy/LoadSnappy.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/snappy/SnappyCompressor.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/snappy/SnappyDecompressor.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/NativeCodeLoader.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/util/NativeCodeLoader.c
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodec.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1184 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1184/ ) HADOOP-8756 . Fix SEGV when libsnappy is in java.library.path but not LD_LIBRARY_PATH. Contributed by Colin Patrick McCabe (Revision 1393243) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1393243 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/CMakeLists.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/config.h.cmake /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/SnappyCodec.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/snappy/LoadSnappy.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/snappy/SnappyCompressor.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/snappy/SnappyDecompressor.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/NativeCodeLoader.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/util/NativeCodeLoader.c /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodec.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1215 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1215/)
          HADOOP-8756. Fix SEGV when libsnappy is in java.library.path but not LD_LIBRARY_PATH. Contributed by Colin Patrick McCabe (Revision 1393243)

          Result = SUCCESS
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1393243
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/CMakeLists.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/config.h.cmake
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/SnappyCodec.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/snappy/LoadSnappy.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/snappy/SnappyCompressor.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/snappy/SnappyDecompressor.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/NativeCodeLoader.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/util/NativeCodeLoader.c
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodec.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1215 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1215/ ) HADOOP-8756 . Fix SEGV when libsnappy is in java.library.path but not LD_LIBRARY_PATH. Contributed by Colin Patrick McCabe (Revision 1393243) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1393243 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/CMakeLists.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/config.h.cmake /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/SnappyCodec.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/snappy/LoadSnappy.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/snappy/SnappyCompressor.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/snappy/SnappyDecompressor.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/NativeCodeLoader.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/util/NativeCodeLoader.c /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodec.java

            People

            • Assignee:
              Colin Patrick McCabe
              Reporter:
              Colin Patrick McCabe
            • Votes:
              0 Vote for this issue
              Watchers:
              14 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development