Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-8751

NPE in Token.toString() when Token is constructed using null identifier

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: security
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Token constructor allows null to be passed leading to NPE in Token.toString(). Simple fix is to check for null in constructor and use empty byte arrays.

      1. HADOOP-8751.patch
        3 kB
        Vlad Rozov
      2. HADOOP-8751-01.patch
        4 kB
        Kanaka Kumar Avvaru
      3. HADOOP-8751-01.patch
        4 kB
        Kanaka Kumar Avvaru
      4. HADOOP-8751-02.patch
        4 kB
        Kanaka Kumar Avvaru
      5. HADOOP-8751-03.patch
        3 kB
        Kanaka Kumar Avvaru

        Issue Links

          Activity

          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12543226/HADOOP-8751.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common:

          org.apache.hadoop.ha.TestZKFailoverController

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1391//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1391//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12543226/HADOOP-8751.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common: org.apache.hadoop.ha.TestZKFailoverController +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1391//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1391//console This message is automatically generated.
          Hide
          vrozov Vlad Rozov added a comment -

          Failure in TestZKFailoverController is caused HADOOP-8591.

          Show
          vrozov Vlad Rozov added a comment - Failure in TestZKFailoverController is caused HADOOP-8591 .
          Hide
          daryn Daryn Sharp added a comment -

          I'm not sure that we should prevent nulls for the various fields. Although I'm fine with handling a null identifier even though that's really an invalid use case.

          Show
          daryn Daryn Sharp added a comment - I'm not sure that we should prevent nulls for the various fields. Although I'm fine with handling a null identifier even though that's really an invalid use case.
          Hide
          vrozov Vlad Rozov added a comment -

          I don't think it is important to distinguish between null and empty fields in the Token class. Default constructor initializes to empty fields. For consistency and to avoid checks for nullness, IMHO it is easier to prevent fields to be null altogether.

          In the TestHftpDelegationToken test case both null and empty byte arrays are used to initialize identifier and password.

          Show
          vrozov Vlad Rozov added a comment - I don't think it is important to distinguish between null and empty fields in the Token class. Default constructor initializes to empty fields. For consistency and to avoid checks for nullness, IMHO it is easier to prevent fields to be null altogether. In the TestHftpDelegationToken test case both null and empty byte arrays are used to initialize identifier and password.
          Hide
          hadoopqa Hadoop QA added a comment -



          +1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 14m 35s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 30s There were no new javac warning messages.
          +1 javadoc 9m 39s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 4s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 32s mvn install still works.
          +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
          +1 findbugs 1m 39s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
          +1 common tests 22m 38s Tests passed in hadoop-common.
              59m 35s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12543226/HADOOP-8751.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / f1a152c
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6379/artifact/patchprocess/testrun_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6379/testReport/
          Java 1.7.0_55
          uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6379/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 35s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 30s There were no new javac warning messages. +1 javadoc 9m 39s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 4s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 32s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 1m 39s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 common tests 22m 38s Tests passed in hadoop-common.     59m 35s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12543226/HADOOP-8751.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / f1a152c hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6379/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6379/testReport/ Java 1.7.0_55 uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6379/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -



          +1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 14m 35s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 29s There were no new javac warning messages.
          +1 javadoc 9m 35s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 5s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 33s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 1m 40s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
          +1 common tests 22m 15s Tests passed in hadoop-common.
              59m 11s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12543226/HADOOP-8751.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / f1a152c
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6385/artifact/patchprocess/testrun_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6385/testReport/
          Java 1.7.0_55
          uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6385/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 35s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 29s There were no new javac warning messages. +1 javadoc 9m 35s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 5s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 40s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 common tests 22m 15s Tests passed in hadoop-common.     59m 11s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12543226/HADOOP-8751.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / f1a152c hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6385/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6385/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6385/console This message was automatically generated.
          Hide
          kanaka Kanaka Kumar Avvaru added a comment -

          Attaching patch with latest trunk code base. Also assinging to myself for further updates. Vlad Rozov, please free to assign back to you if you want to work on the JIRA

          Show
          kanaka Kanaka Kumar Avvaru added a comment - Attaching patch with latest trunk code base. Also assinging to myself for further updates. Vlad Rozov , please free to assign back to you if you want to work on the JIRA
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 15m 6s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 38s There were no new javac warning messages.
          +1 javadoc 9m 49s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 1m 6s The applied patch generated 1 new checkstyle issues (total was 10, now 11).
          -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 install 1m 32s mvn install still works.
          +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
          +1 findbugs 1m 40s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
          +1 common tests 22m 57s Tests passed in hadoop-common.
              60m 48s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12732172/HADOOP-8751-01.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 987abc9
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/6647/artifact/patchprocess/diffcheckstylehadoop-common.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/6647/artifact/patchprocess/whitespace.txt
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6647/artifact/patchprocess/testrun_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6647/testReport/
          Java 1.7.0_55
          uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6647/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 15m 6s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 38s There were no new javac warning messages. +1 javadoc 9m 49s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 6s The applied patch generated 1 new checkstyle issues (total was 10, now 11). -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 32s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 1m 40s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 common tests 22m 57s Tests passed in hadoop-common.     60m 48s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12732172/HADOOP-8751-01.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 987abc9 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/6647/artifact/patchprocess/diffcheckstylehadoop-common.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/6647/artifact/patchprocess/whitespace.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6647/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6647/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6647/console This message was automatically generated.
          Hide
          kanaka Kanaka Kumar Avvaru added a comment -

          Updating patch to fix Precomit build errors.

          Show
          kanaka Kanaka Kumar Avvaru added a comment - Updating patch to fix Precomit build errors.
          Hide
          hadoopqa Hadoop QA added a comment -



          +1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 14m 38s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 30s There were no new javac warning messages.
          +1 javadoc 9m 37s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 5s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 33s mvn install still works.
          +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
          +1 findbugs 1m 39s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
          +1 common tests 22m 26s Tests passed in hadoop-common.
              59m 25s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12732202/HADOOP-8751-02.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 360dff5
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6651/artifact/patchprocess/testrun_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6651/testReport/
          Java 1.7.0_55
          uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6651/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 38s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 30s There were no new javac warning messages. +1 javadoc 9m 37s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 5s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 1m 39s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 common tests 22m 26s Tests passed in hadoop-common.     59m 25s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12732202/HADOOP-8751-02.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 360dff5 hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6651/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6651/testReport/ Java 1.7.0_55 uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6651/console This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Kanaka Kumar Avvaru for taking this issue. Mostly looks good to me. Two comments:
          1. For Token.addBinaryBuffer, we can drop null check for bytes since the variable is guaranteed to be non null.

          +    assertEquals(token1, token2);
          +    assertEquals(token1.toString(), token2.toString());
          +    assertEquals(token1.encodeToUrlString(), token2.encodeToUrlString());
          

          2. I'm thinking comparing Token.toString() is redundant and can be removed.

          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Kanaka Kumar Avvaru for taking this issue. Mostly looks good to me. Two comments: 1. For Token.addBinaryBuffer, we can drop null check for bytes since the variable is guaranteed to be non null. + assertEquals(token1, token2); + assertEquals(token1.toString(), token2.toString()); + assertEquals(token1.encodeToUrlString(), token2.encodeToUrlString()); 2. I'm thinking comparing Token.toString() is redundant and can be removed.
          Hide
          kanaka Kanaka Kumar Avvaru added a comment -

          Thanks Akira Ajisaka for review. I have updated the patch as per comments, please review.

          Show
          kanaka Kanaka Kumar Avvaru added a comment - Thanks Akira Ajisaka for review. I have updated the patch as per comments, please review.
          Hide
          hadoopqa Hadoop QA added a comment -



          +1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 14m 40s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 28s There were no new javac warning messages.
          +1 javadoc 9m 34s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 7s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 34s mvn install still works.
          +1 eclipse:eclipse 0m 37s The patch built with eclipse:eclipse.
          +1 findbugs 1m 40s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 common tests 22m 20s Tests passed in hadoop-common.
              59m 25s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12735153/HADOOP-8751-03.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / ada233b
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6819/artifact/patchprocess/testrun_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6819/testReport/
          Java 1.7.0_55
          uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6819/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 40s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 28s There were no new javac warning messages. +1 javadoc 9m 34s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 7s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 37s The patch built with eclipse:eclipse. +1 findbugs 1m 40s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 22m 20s Tests passed in hadoop-common.     59m 25s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12735153/HADOOP-8751-03.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / ada233b hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6819/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6819/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6819/console This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          +1, committing this.

          Show
          ajisakaa Akira Ajisaka added a comment - +1, committing this.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committed this to trunk and branch-2. Thanks Kanaka Kumar Avvaru for contribution.

          Show
          ajisakaa Akira Ajisaka added a comment - Committed this to trunk and branch-2. Thanks Kanaka Kumar Avvaru for contribution.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #7900 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7900/)
          HADOOP-8751. NPE in Token.toString() when Token is constructed using null identifier. Contributed by kanaka kumar avvaru. (aajisaka: rev 56996a685e6201cb186cea866d22418289174574)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/Token.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/token/delegation/TestDelegationToken.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7900 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7900/ ) HADOOP-8751 . NPE in Token.toString() when Token is constructed using null identifier. Contributed by kanaka kumar avvaru. (aajisaka: rev 56996a685e6201cb186cea866d22418289174574) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/Token.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/token/delegation/TestDelegationToken.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #208 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/208/)
          HADOOP-8751. NPE in Token.toString() when Token is constructed using null identifier. Contributed by kanaka kumar avvaru. (aajisaka: rev 56996a685e6201cb186cea866d22418289174574)

          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/token/delegation/TestDelegationToken.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/Token.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #208 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/208/ ) HADOOP-8751 . NPE in Token.toString() when Token is constructed using null identifier. Contributed by kanaka kumar avvaru. (aajisaka: rev 56996a685e6201cb186cea866d22418289174574) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/token/delegation/TestDelegationToken.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/Token.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk #939 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/939/)
          HADOOP-8751. NPE in Token.toString() when Token is constructed using null identifier. Contributed by kanaka kumar avvaru. (aajisaka: rev 56996a685e6201cb186cea866d22418289174574)

          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/token/delegation/TestDelegationToken.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/Token.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #939 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/939/ ) HADOOP-8751 . NPE in Token.toString() when Token is constructed using null identifier. Contributed by kanaka kumar avvaru. (aajisaka: rev 56996a685e6201cb186cea866d22418289174574) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/token/delegation/TestDelegationToken.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/Token.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2137 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2137/)
          HADOOP-8751. NPE in Token.toString() when Token is constructed using null identifier. Contributed by kanaka kumar avvaru. (aajisaka: rev 56996a685e6201cb186cea866d22418289174574)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/token/delegation/TestDelegationToken.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/Token.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2137 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2137/ ) HADOOP-8751 . NPE in Token.toString() when Token is constructed using null identifier. Contributed by kanaka kumar avvaru. (aajisaka: rev 56996a685e6201cb186cea866d22418289174574) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/token/delegation/TestDelegationToken.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/Token.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #197 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/197/)
          HADOOP-8751. NPE in Token.toString() when Token is constructed using null identifier. Contributed by kanaka kumar avvaru. (aajisaka: rev 56996a685e6201cb186cea866d22418289174574)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/token/delegation/TestDelegationToken.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/Token.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #197 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/197/ ) HADOOP-8751 . NPE in Token.toString() when Token is constructed using null identifier. Contributed by kanaka kumar avvaru. (aajisaka: rev 56996a685e6201cb186cea866d22418289174574) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/token/delegation/TestDelegationToken.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/Token.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #207 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/207/)
          HADOOP-8751. NPE in Token.toString() when Token is constructed using null identifier. Contributed by kanaka kumar avvaru. (aajisaka: rev 56996a685e6201cb186cea866d22418289174574)

          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/token/delegation/TestDelegationToken.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/Token.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #207 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/207/ ) HADOOP-8751 . NPE in Token.toString() when Token is constructed using null identifier. Contributed by kanaka kumar avvaru. (aajisaka: rev 56996a685e6201cb186cea866d22418289174574) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/token/delegation/TestDelegationToken.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/Token.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2155 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2155/)
          HADOOP-8751. NPE in Token.toString() when Token is constructed using null identifier. Contributed by kanaka kumar avvaru. (aajisaka: rev 56996a685e6201cb186cea866d22418289174574)

          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/token/delegation/TestDelegationToken.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/Token.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2155 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2155/ ) HADOOP-8751 . NPE in Token.toString() when Token is constructed using null identifier. Contributed by kanaka kumar avvaru. (aajisaka: rev 56996a685e6201cb186cea866d22418289174574) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/token/delegation/TestDelegationToken.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/Token.java hadoop-common-project/hadoop-common/CHANGES.txt

            People

            • Assignee:
              kanaka Kanaka Kumar Avvaru
              Reporter:
              vrozov Vlad Rozov
            • Votes:
              0 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development