Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-8584

test-patch.sh should not immediately exit when no tests are added or modified

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-alpha, 3.0.0-alpha1
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      test-patch.sh should not immediately exit when no tests are added or modified.

      Although it's good to note whether or not a patch introduces or modifies tests, it's not good to abort the Jenkins patch process if it did not.

      1. HADOOP-8584.001.patch
        0.4 kB
        Colin P. McCabe

        Issue Links

          Activity

          Hide
          qwertymaniac Harsh J added a comment -

          Btw, was this change made to demand that all patches, unless doc or log changes, be provided with a patch?

          Show
          qwertymaniac Harsh J added a comment - Btw, was this change made to demand that all patches, unless doc or log changes, be provided with a patch?
          Hide
          cmccabe Colin P. McCabe added a comment -

          Btw, was this change made to demand that all patches, unless doc or log changes, be provided with a patch?

          No. It seems to have been an unintented issue introduced by the patch for HADOOP-8523.

          Show
          cmccabe Colin P. McCabe added a comment - Btw, was this change made to demand that all patches, unless doc or log changes, be provided with a patch? No. It seems to have been an unintented issue introduced by the patch for HADOOP-8523 .
          Hide
          eli Eli Collins added a comment -

          +1

          Show
          eli Eli Collins added a comment - +1
          Hide
          eli Eli Collins added a comment -

          I've committed this to trunk.

          Show
          eli Eli Collins added a comment - I've committed this to trunk.
          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #1100 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1100/)
          HADOOP-8584. test-patch.sh should not immediately exit when no tests are added or modified. Contributed by Colin Patrick McCabe (Revision 1359902)

          Result = FAILURE
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1359902
          Files :

          • /hadoop/common/trunk/dev-support/test-patch.sh
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1100 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1100/ ) HADOOP-8584 . test-patch.sh should not immediately exit when no tests are added or modified. Contributed by Colin Patrick McCabe (Revision 1359902) Result = FAILURE eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1359902 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1133 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1133/)
          HADOOP-8584. test-patch.sh should not immediately exit when no tests are added or modified. Contributed by Colin Patrick McCabe (Revision 1359902)

          Result = SUCCESS
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1359902
          Files :

          • /hadoop/common/trunk/dev-support/test-patch.sh
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1133 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1133/ ) HADOOP-8584 . test-patch.sh should not immediately exit when no tests are added or modified. Contributed by Colin Patrick McCabe (Revision 1359902) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1359902 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt

            People

            • Assignee:
              cmccabe Colin P. McCabe
              Reporter:
              cmccabe Colin P. McCabe
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development