Hadoop Common
  1. Hadoop Common
  2. HADOOP-8550

hadoop fs -touchz automatically created parent directories

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.3, 2.0.0-alpha, 3.0.0
    • Fix Version/s: 0.23.3, 2.0.2-alpha
    • Component/s: fs
    • Labels:
      None
    • Target Version/s:

      Description

      Recently many of the fsShell commands were updated to be more POSIX compliant. touchz appears to have been missed, or has regressed. If it has regressed then the target version should be 0.23.3.

      1. HADOOP-8550.patch
        0.9 kB
        Daryn Sharp
      2. HADOOP-8550.patch
        26 kB
        John George
      3. HADOOP-8550.patch
        26 kB
        John George
      4. HADOOP-8550.patch
        26 kB
        John George
      5. HADOOP-8550.patch
        26 kB
        John George

        Activity

        Robert Joseph Evans created issue -
        Hide
        Daryn Sharp added a comment -

        This should fix it, but need to write tests.

        Show
        Daryn Sharp added a comment - This should fix it, but need to write tests.
        Daryn Sharp made changes -
        Field Original Value New Value
        Attachment HADOOP-8550.patch [ 12536229 ]
        John George made changes -
        Attachment HADOOP-8550.patch [ 12537176 ]
        John George made changes -
        Assignee John George [ johnvijoe ]
        John George made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Daryn Sharp added a comment -

        @John: Many thanks for the tests! Unless I've missed it, would you please add a specific test to testHDFSConf.xml to verify the output?

        Show
        Daryn Sharp added a comment - @John: Many thanks for the tests! Unless I've missed it, would you please add a specific test to testHDFSConf.xml to verify the output?
        John George made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Hide
        John George added a comment -

        Adding the testcase Daryn suggested.

        Show
        John George added a comment - Adding the testcase Daryn suggested.
        John George made changes -
        Attachment HADOOP-8550.patch [ 12537200 ]
        John George made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Daryn Sharp added a comment -

        +1 Looks great!

        Show
        Daryn Sharp added a comment - +1 Looks great!
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12537176/HADOOP-8550.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 2 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:

        org.apache.hadoop.ha.TestZKFailoverController
        org.apache.hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1206//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1206//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12537176/HADOOP-8550.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.ha.TestZKFailoverController org.apache.hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1206//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1206//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12537200/HADOOP-8550.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 2 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:

        org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1208//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1208//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12537200/HADOOP-8550.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1208//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1208//console This message is automatically generated.
        Hide
        John George added a comment -

        Patch based on latest 2.0

        Show
        John George added a comment - Patch based on latest 2.0
        John George made changes -
        Attachment HADOOP-8550.patch [ 12537889 ]
        John George made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        John George made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        John George made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Hide
        John George added a comment -

        Reattaching the same patch to trigger hudson

        Show
        John George added a comment - Reattaching the same patch to trigger hudson
        John George made changes -
        Attachment HADOOP-8550.patch [ 12538166 ]
        John George made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12538166/HADOOP-8550.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 2 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:

        org.apache.hadoop.ha.TestZKFailoverController

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1223//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1223//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12538166/HADOOP-8550.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.ha.TestZKFailoverController +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1223//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1223//console This message is automatically generated.
        Hide
        Robert Joseph Evans added a comment -

        The changes look fine to me too +1. The test has been failing randomly for a while now. I'll check this in.

        Show
        Robert Joseph Evans added a comment - The changes look fine to me too +1. The test has been failing randomly for a while now. I'll check this in.
        Hide
        Robert Joseph Evans added a comment -

        Thanks John,

        I put this into trunk, branch-2, and branch-0.23

        Show
        Robert Joseph Evans added a comment - Thanks John, I put this into trunk, branch-2, and branch-0.23
        Robert Joseph Evans made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Fix Version/s 0.23.3 [ 12320059 ]
        Fix Version/s 3.0.0 [ 12320357 ]
        Fix Version/s 2.2.0-alpha [ 12322473 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2533 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2533/)
        HADOOP-8550. hadoop fs -touchz automatically created parent directories (John George via bobby) (Revision 1367202)

        Result = SUCCESS
        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1367202
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Touchz.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSShell.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2533 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2533/ ) HADOOP-8550 . hadoop fs -touchz automatically created parent directories (John George via bobby) (Revision 1367202) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1367202 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Touchz.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSShell.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2597 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2597/)
        HADOOP-8550. hadoop fs -touchz automatically created parent directories (John George via bobby) (Revision 1367202)

        Result = SUCCESS
        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1367202
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Touchz.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSShell.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2597 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2597/ ) HADOOP-8550 . hadoop fs -touchz automatically created parent directories (John George via bobby) (Revision 1367202) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1367202 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Touchz.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSShell.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #2553 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2553/)
        HADOOP-8550. hadoop fs -touchz automatically created parent directories (John George via bobby) (Revision 1367202)

        Result = FAILURE
        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1367202
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Touchz.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSShell.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2553 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2553/ ) HADOOP-8550 . hadoop fs -touchz automatically created parent directories (John George via bobby) (Revision 1367202) Result = FAILURE bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1367202 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Touchz.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSShell.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #330 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/330/)
        svn merge -c 1367202 FIXES: HADOOP-8550. hadoop fs -touchz automatically created parent directories (John George via bobby) (Revision 1367204)

        Result = SUCCESS
        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1367204
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Touchz.java
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSShell.java
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #330 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/330/ ) svn merge -c 1367202 FIXES: HADOOP-8550 . hadoop fs -touchz automatically created parent directories (John George via bobby) (Revision 1367204) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1367204 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Touchz.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSShell.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml
        Arun C Murthy made changes -
        Fix Version/s 3.0.0 [ 12320357 ]
        Arun C Murthy made changes -
        Affects Version/s 2.0.0-alpha [ 12320352 ]
        Affects Version/s 2.1.0-alpha [ 12321441 ]
        Arun C Murthy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Patch Available Patch Available Open Open
        8d 1h 56m 3 John George 27/Jul/12 17:12
        Open Open Patch Available Patch Available
        16d 27m 4 John George 27/Jul/12 17:13
        Patch Available Patch Available Resolved Resolved
        3d 2h 1 Robert Joseph Evans 30/Jul/12 19:14
        Resolved Resolved Closed Closed
        72d 23h 30m 1 Arun C Murthy 11/Oct/12 18:45

          People

          • Assignee:
            John George
            Reporter:
            Robert Joseph Evans
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development