Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.2-alpha
    • Component/s: native
    • Labels:
      None
    • Environment:

      gcc version 4.6.3 (Ubuntu/Linaro 4.6.3-1ubuntu5)

    • Hadoop Flags:
      Reviewed

      Description

      CMake native builds fail with this error:

      cc1: error: unrecognized command line option '-m32'

      -m32 is only defined by GCC for x86, PowerPC, and SPARC.

      The following files specify -m32 when the JVM data model is 32-bit:

      hadoop-common-project/hadoop-common/src/CMakeLists.txt
      hadoop-hdfs-project/hadoop-hdfs/src/CMakeLists.txt
      hadoop-tools/hadoop-pipes/src/CMakeLists.txt
      hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/CMakeLists.txt

      This is a partial regression of HDFS-1920.

      1. hadoop-cmake.patch
        4 kB
        Trevor Robinson

        Issue Links

          Activity

          Trevor Robinson created issue -
          Trevor Robinson made changes -
          Field Original Value New Value
          Link This issue is related to HADOOP-8368 [ HADOOP-8368 ]
          Trevor Robinson made changes -
          Link This issue is related to HDFS-1920 [ HDFS-1920 ]
          Hide
          Trevor Robinson added a comment -

          Patch CMake files to add -m32 compile/link flag only when using GCC on 64-bit platforms. Verified that native libraries build correctly on amd64 with 32-bit and 64-bit JVM and on ARM.

          Show
          Trevor Robinson added a comment - Patch CMake files to add -m32 compile/link flag only when using GCC on 64-bit platforms. Verified that native libraries build correctly on amd64 with 32-bit and 64-bit JVM and on ARM.
          Trevor Robinson made changes -
          Attachment hadoop-cmake.patch [ 12533763 ]
          Trevor Robinson made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12533763/hadoop-cmake.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager:

          org.apache.hadoop.fs.viewfs.TestViewFsTrash
          org.apache.hadoop.hdfs.TestDatanodeBlockScanner

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1146//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1146//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12533763/hadoop-cmake.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager: org.apache.hadoop.fs.viewfs.TestViewFsTrash org.apache.hadoop.hdfs.TestDatanodeBlockScanner +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1146//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1146//console This message is automatically generated.
          Eli Collins made changes -
          Assignee Trevor Robinson [ scurrilous ]
          Hide
          Trevor Robinson added a comment -

          The 2 test failures appear to be unrelated known issues:

          HADOOP-8110: junit.framework.AssertionFailedError: -expunge failed expected:<0> but was:<1>
          https://builds.apache.org/job/PreCommit-HADOOP-Build/1146/testReport/org.apache.hadoop.fs.viewfs/TestViewFsTrash/testTrash/

          HDFS-2881: java.util.concurrent.TimeoutException: Timed out waiting for corrupt replicas. Waiting for 2, but only found 0
          https://builds.apache.org/job/PreCommit-HADOOP-Build/1146/testReport/org.apache.hadoop.hdfs/TestDatanodeBlockScanner/testBlockCorruptionRecoveryPolicy2/

          Show
          Trevor Robinson added a comment - The 2 test failures appear to be unrelated known issues: HADOOP-8110 : junit.framework.AssertionFailedError: -expunge failed expected:<0> but was:<1> https://builds.apache.org/job/PreCommit-HADOOP-Build/1146/testReport/org.apache.hadoop.fs.viewfs/TestViewFsTrash/testTrash/ HDFS-2881 : java.util.concurrent.TimeoutException: Timed out waiting for corrupt replicas. Waiting for 2, but only found 0 https://builds.apache.org/job/PreCommit-HADOOP-Build/1146/testReport/org.apache.hadoop.hdfs/TestDatanodeBlockScanner/testBlockCorruptionRecoveryPolicy2/
          Hide
          Colin Patrick McCabe added a comment -

          +1, looks good

          Show
          Colin Patrick McCabe added a comment - +1, looks good
          Hide
          Eli Collins added a comment -

          +1 lgtm as well

          Show
          Eli Collins added a comment - +1 lgtm as well
          Hide
          Eli Collins added a comment -

          I've committed this to trunk and merged to branch-2. Thanks Trevor!

          Show
          Eli Collins added a comment - I've committed this to trunk and merged to branch-2. Thanks Trevor!
          Eli Collins made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags Reviewed [ 10343 ]
          Fix Version/s 2.0.1-alpha [ 12321441 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #2486 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2486/)
          HADOOP-8538. CMake builds fail on ARM. Contributed by Trevor Robinson (Revision 1356041)

          Result = SUCCESS
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1356041
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/CMakeLists.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/CMakeLists.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/CMakeLists.txt
          • /hadoop/common/trunk/hadoop-tools/hadoop-pipes/src/CMakeLists.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2486 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2486/ ) HADOOP-8538 . CMake builds fail on ARM. Contributed by Trevor Robinson (Revision 1356041) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1356041 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/CMakeLists.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/CMakeLists.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/CMakeLists.txt /hadoop/common/trunk/hadoop-tools/hadoop-pipes/src/CMakeLists.txt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #2418 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2418/)
          HADOOP-8538. CMake builds fail on ARM. Contributed by Trevor Robinson (Revision 1356041)

          Result = SUCCESS
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1356041
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/CMakeLists.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/CMakeLists.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/CMakeLists.txt
          • /hadoop/common/trunk/hadoop-tools/hadoop-pipes/src/CMakeLists.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2418 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2418/ ) HADOOP-8538 . CMake builds fail on ARM. Contributed by Trevor Robinson (Revision 1356041) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1356041 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/CMakeLists.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/CMakeLists.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/CMakeLists.txt /hadoop/common/trunk/hadoop-tools/hadoop-pipes/src/CMakeLists.txt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #2435 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2435/)
          HADOOP-8538. CMake builds fail on ARM. Contributed by Trevor Robinson (Revision 1356041)

          Result = FAILURE
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1356041
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/CMakeLists.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/CMakeLists.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/CMakeLists.txt
          • /hadoop/common/trunk/hadoop-tools/hadoop-pipes/src/CMakeLists.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2435 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2435/ ) HADOOP-8538 . CMake builds fail on ARM. Contributed by Trevor Robinson (Revision 1356041) Result = FAILURE eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1356041 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/CMakeLists.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/CMakeLists.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/CMakeLists.txt /hadoop/common/trunk/hadoop-tools/hadoop-pipes/src/CMakeLists.txt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #1093 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1093/)
          HADOOP-8538. CMake builds fail on ARM. Contributed by Trevor Robinson (Revision 1356041)

          Result = FAILURE
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1356041
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/CMakeLists.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/CMakeLists.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/CMakeLists.txt
          • /hadoop/common/trunk/hadoop-tools/hadoop-pipes/src/CMakeLists.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1093 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1093/ ) HADOOP-8538 . CMake builds fail on ARM. Contributed by Trevor Robinson (Revision 1356041) Result = FAILURE eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1356041 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/CMakeLists.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/CMakeLists.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/CMakeLists.txt /hadoop/common/trunk/hadoop-tools/hadoop-pipes/src/CMakeLists.txt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1127 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1127/)
          HADOOP-8538. CMake builds fail on ARM. Contributed by Trevor Robinson (Revision 1356041)

          Result = SUCCESS
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1356041
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/CMakeLists.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/CMakeLists.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/CMakeLists.txt
          • /hadoop/common/trunk/hadoop-tools/hadoop-pipes/src/CMakeLists.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1127 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1127/ ) HADOOP-8538 . CMake builds fail on ARM. Contributed by Trevor Robinson (Revision 1356041) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1356041 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/CMakeLists.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/CMakeLists.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/CMakeLists.txt /hadoop/common/trunk/hadoop-tools/hadoop-pipes/src/CMakeLists.txt
          Arun C Murthy made changes -
          Fix Version/s 2.0.2-alpha [ 12322473 ]
          Fix Version/s 2.1.0-alpha [ 12321441 ]
          Arun C Murthy made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          1h 39m 1 Trevor Robinson 28/Jun/12 03:03
          Patch Available Patch Available Resolved Resolved
          3d 20h 48m 1 Eli Collins 01/Jul/12 23:51
          Resolved Resolved Closed Closed
          101d 18h 53m 1 Arun C Murthy 11/Oct/12 18:45

            People

            • Assignee:
              Trevor Robinson
              Reporter:
              Trevor Robinson
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development