Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0
    • Fix Version/s: 2.0.2-alpha
    • Component/s: io
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      TestTFileJClassComparatorByteArrays and TestTFileByteArrays are failing in some recent patch builds (seems to have started in the middle of May). These tests previously failed in HADOOP-7111 - perhaps something regressed there?

        Issue Links

          Activity

          Hide
          Todd Lipcon added a comment -
          Show
          Todd Lipcon added a comment - https://builds.apache.org/job/PreCommit-HDFS-Build/2707//testReport/ is one example of a build which failed
          Show
          Eli Collins added a comment - Another example: https://builds.apache.org/job/PreCommit-HDFS-Build/2779/testReport/org.apache.hadoop.io.file.tfile/TestTFileByteArrays/
          Hide
          Todd Lipcon added a comment -

          I think this is failing for similar reasons to HADOOP-7111. That patch added the following:

            private int records1stBlock = NativeCodeLoader.isNativeCodeLoaded() ? 5674 : 4480;
            private int records2ndBlock = NativeCodeLoader.isNativeCodeLoaded() ? 5574 : 4263;
          

          But the condition is wrong. If the native libs are present but they don't have gzip support compiled in (eg the gzip devel libraries weren't present at compile time), then it should use the non-native expected values. Instead we should check specifically for the zlib native code.

          Show
          Todd Lipcon added a comment - I think this is failing for similar reasons to HADOOP-7111 . That patch added the following: private int records1stBlock = NativeCodeLoader.isNativeCodeLoaded() ? 5674 : 4480; private int records2ndBlock = NativeCodeLoader.isNativeCodeLoaded() ? 5574 : 4263; But the condition is wrong. If the native libs are present but they don't have gzip support compiled in (eg the gzip devel libraries weren't present at compile time), then it should use the non-native expected values. Instead we should check specifically for the zlib native code.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12536902/hadoop-8537.txt
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common:

          org.apache.hadoop.ha.TestZKFailoverController

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1201//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1201//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12536902/hadoop-8537.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common: org.apache.hadoop.ha.TestZKFailoverController +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1201//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1201//console This message is automatically generated.
          Hide
          Aaron T. Myers added a comment -

          +1, the patch looks good to me.

          Show
          Aaron T. Myers added a comment - +1, the patch looks good to me.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #2513 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2513/)
          HADOOP-8537. Fix TFile tests to pass even when native zlib support is not compiled. Contributed by Todd Lipcon. (Revision 1362729)

          Result = FAILURE
          todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1362729
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/TestTFileByteArrays.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2513 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2513/ ) HADOOP-8537 . Fix TFile tests to pass even when native zlib support is not compiled. Contributed by Todd Lipcon. (Revision 1362729) Result = FAILURE todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1362729 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/TestTFileByteArrays.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #2557 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2557/)
          HADOOP-8537. Fix TFile tests to pass even when native zlib support is not compiled. Contributed by Todd Lipcon. (Revision 1362729)

          Result = SUCCESS
          todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1362729
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/TestTFileByteArrays.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2557 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2557/ ) HADOOP-8537 . Fix TFile tests to pass even when native zlib support is not compiled. Contributed by Todd Lipcon. (Revision 1362729) Result = SUCCESS todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1362729 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/TestTFileByteArrays.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #2492 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2492/)
          HADOOP-8537. Fix TFile tests to pass even when native zlib support is not compiled. Contributed by Todd Lipcon. (Revision 1362729)

          Result = SUCCESS
          todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1362729
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/TestTFileByteArrays.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2492 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2492/ ) HADOOP-8537 . Fix TFile tests to pass even when native zlib support is not compiled. Contributed by Todd Lipcon. (Revision 1362729) Result = SUCCESS todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1362729 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/TestTFileByteArrays.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #1107 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1107/)
          HADOOP-8537. Fix TFile tests to pass even when native zlib support is not compiled. Contributed by Todd Lipcon. (Revision 1362729)

          Result = FAILURE
          todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1362729
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/TestTFileByteArrays.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1107 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1107/ ) HADOOP-8537 . Fix TFile tests to pass even when native zlib support is not compiled. Contributed by Todd Lipcon. (Revision 1362729) Result = FAILURE todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1362729 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/TestTFileByteArrays.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1140 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1140/)
          HADOOP-8537. Fix TFile tests to pass even when native zlib support is not compiled. Contributed by Todd Lipcon. (Revision 1362729)

          Result = FAILURE
          todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1362729
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/TestTFileByteArrays.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1140 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1140/ ) HADOOP-8537 . Fix TFile tests to pass even when native zlib support is not compiled. Contributed by Todd Lipcon. (Revision 1362729) Result = FAILURE todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1362729 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/TestTFileByteArrays.java

            People

            • Assignee:
              Todd Lipcon
              Reporter:
              Todd Lipcon
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development