[HADOOP-8533] Remove Parallel Call in IPC - ASF JIRA

Details

Type: Improvement
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 1.0.0, 2.0.0-alpha, 3.0.0-alpha1
Fix Version/s: 2.0.2-alpha
Component/s: ipc
Labels:
None

Hadoop Flags:

Reviewed
Release Note:
Merged the change to branch-2

Description

From what I know, I do not think anyone uses Parallel Call. I also think it is not tested very well.

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending

Attachments

HADOOP-8533.patch

29/Jun/12 22:22

15 kB

Brandon Li

Issue Links

is related to

HADOOP-8530 Potential deadlock in IPC

Resolved

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Todd Lipcon added a comment - 26/Jun/12 20:40

+1, let's rip it out and redo it if we need it.

Show

Todd Lipcon added a comment - 26/Jun/12 20:40 +1, let's rip it out and redo it if we need it.

Hide

Permalink

Hadoop QA added a comment - 29/Jun/12 23:02

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12534060/HADOOP-8533.patch
against trunk revision .

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 2 new or modified test files.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 eclipse:eclipse. The patch built with eclipse:eclipse.

+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

-1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common:

org.apache.hadoop.fs.viewfs.TestViewFsTrash

+1 contrib tests. The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1157//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1157//console

This message is automatically generated.

Show

Hadoop QA added a comment - 29/Jun/12 23:02 -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12534060/HADOOP-8533.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common: org.apache.hadoop.fs.viewfs.TestViewFsTrash +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1157//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1157//console This message is automatically generated.

Hide

Permalink

Brandon Li added a comment - 30/Jun/12 02:35

The test failure was not introduced by this patch. The same test passed in my local test.

Show

Brandon Li added a comment - 30/Jun/12 02:35 The test failure was not introduced by this patch. The same test passed in my local test.

Hide

Permalink

Suresh Srinivas added a comment - 02/Jul/12 22:12

+1 for the patch.

Show

Suresh Srinivas added a comment - 02/Jul/12 22:12 +1 for the patch.

Hide

Permalink

Suresh Srinivas added a comment - 02/Jul/12 22:15

I committed the patch. Thank you Brandon.

Show

Suresh Srinivas added a comment - 02/Jul/12 22:15 I committed the patch. Thank you Brandon.

Hide

Permalink

Eli Collins added a comment - 02/Jul/12 22:51

Hey Suresh, how about merging this to branch-2? Helps keep the diffs inline and as you point out is not used or well tested.

Show

Eli Collins added a comment - 02/Jul/12 22:51 Hey Suresh, how about merging this to branch-2? Helps keep the diffs inline and as you point out is not used or well tested.

Hide

Permalink

Suresh Srinivas added a comment - 02/Jul/12 22:54

sounds good.

Show

Suresh Srinivas added a comment - 02/Jul/12 22:54 sounds good.

Hide

Permalink

Hudson added a comment - 04/Jul/12 19:56

Integrated in Hadoop-Common-trunk-Commit #2422 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2422/)
Moving ~~HADOOP-8533~~ to release 2.0 section (Revision 1356857)

Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1356857
Files :

/hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt

Show

Hudson added a comment - 04/Jul/12 19:56 Integrated in Hadoop-Common-trunk-Commit #2422 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2422/ ) Moving HADOOP-8533 to release 2.0 section (Revision 1356857) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1356857 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt

Hide

Permalink

Hudson added a comment - 04/Jul/12 19:58

Integrated in Hadoop-Hdfs-trunk-Commit #2490 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2490/)
Moving ~~HADOOP-8533~~ to release 2.0 section (Revision 1356857)

Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1356857
Files :

/hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt

Show

Hudson added a comment - 04/Jul/12 19:58 Integrated in Hadoop-Hdfs-trunk-Commit #2490 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2490/ ) Moving HADOOP-8533 to release 2.0 section (Revision 1356857) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1356857 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt

Hide

Permalink

Hudson added a comment - 04/Jul/12 20:47

Integrated in Hadoop-Mapreduce-trunk-Commit #2439 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2439/)
Moving ~~HADOOP-8533~~ to release 2.0 section (Revision 1356857)

Result = FAILURE
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1356857
Files :

/hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt

Show

Hudson added a comment - 04/Jul/12 20:47 Integrated in Hadoop-Mapreduce-trunk-Commit #2439 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2439/ ) Moving HADOOP-8533 to release 2.0 section (Revision 1356857) Result = FAILURE suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1356857 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt

Hide

Permalink

Hudson added a comment - 05/Jul/12 11:39

Integrated in Hadoop-Hdfs-trunk #1094 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1094/)
Moving ~~HADOOP-8533~~ to release 2.0 section (Revision 1356857)
~~HADOOP-8533~~. Remove parallel call ununsed capability in RPC. Contributed by Brandon Li. (Revision 1356504)

Result = FAILURE
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1356857
Files :

/hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt

suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1356504
Files :

/hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RpcEngine.java
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPC.java
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java

Show

Hudson added a comment - 05/Jul/12 11:39 Integrated in Hadoop-Hdfs-trunk #1094 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1094/ ) Moving HADOOP-8533 to release 2.0 section (Revision 1356857) HADOOP-8533 . Remove parallel call ununsed capability in RPC. Contributed by Brandon Li. (Revision 1356504) Result = FAILURE suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1356857 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1356504 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RpcEngine.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPC.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java

Hide

Permalink

Hudson added a comment - 05/Jul/12 14:03

Integrated in Hadoop-Mapreduce-trunk #1127 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1127/)
Moving ~~HADOOP-8533~~ to release 2.0 section (Revision 1356857)
~~HADOOP-8533~~. Remove parallel call ununsed capability in RPC. Contributed by Brandon Li. (Revision 1356504)

Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1356857
Files :

/hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt

suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1356504
Files :

/hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RpcEngine.java
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPC.java
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java

Show

Hudson added a comment - 05/Jul/12 14:03 Integrated in Hadoop-Mapreduce-trunk #1127 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1127/ ) Moving HADOOP-8533 to release 2.0 section (Revision 1356857) HADOOP-8533 . Remove parallel call ununsed capability in RPC. Contributed by Brandon Li. (Revision 1356504) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1356857 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1356504 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RpcEngine.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPC.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java

People

Assignee:

Brandon Li

Reporter:

Suresh Srinivas

Votes:

0 Vote for this issue

Watchers:

11 Start watching this issue

Dates

Created:

26/Jun/12 20:28

Updated:

12/May/16 18:24

Resolved:

02/Jul/12 22:15

Development

Agile

View on Board