Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-8523

test-patch.sh doesn't validate patches before building

VotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 0.23.3, 2.0.0-alpha
    • 3.0.0-alpha1
    • build

    Description

      When running test-patch.sh with an invalid patch (not formatted properly) or one that doesn't compile, the script spends a lot of time building Hadoop before checking to see if the patch is invalid. It would help devs if it checked first just in case we run test-patch.sh with a bad patch file.

      Attachments

        1. Hadoop-8523.patch
          0.4 kB
          Jack Dintruff
        2. Hadoop-8523.patch
          0.5 kB
          Jack Dintruff
        3. HADOOP-8523.patch
          2 kB
          Jack Dintruff
        4. HADOOP-8523.patch
          1 kB
          Jack Dintruff

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            jackd Jack Dintruff
            jackd Jack Dintruff
            Votes:
            0 Vote for this issue
            Watchers:
            9 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment