Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.3
    • Fix Version/s: 0.23.3, 2.0.2-alpha
    • Component/s: ipc
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Target Version/s:

      Description

      RPC.getServerAddress was introduced in trunk/2.0 as part of larger HA changes. 0.23 does not have HA, but this non-HA specific method is needed.

      1. HADOOP-8373.patch
        9 kB
        Daryn Sharp
      2. TestRPC.trunk.patch
        1 kB
        Daryn Sharp

        Issue Links

          Activity

          Daryn Sharp created issue -
          Daryn Sharp made changes -
          Field Original Value New Value
          Link This issue blocks MAPREDUCE-4162 [ MAPREDUCE-4162 ]
          Hide
          Daryn Sharp added a comment -

          Minimal port of the method and required interface.

          Show
          Daryn Sharp added a comment - Minimal port of the method and required interface.
          Daryn Sharp made changes -
          Attachment HADOOP-8373.patch [ 12526172 ]
          Daryn Sharp made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12526172/HADOOP-8373.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/965//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12526172/HADOOP-8373.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/965//console This message is automatically generated.
          Hide
          Daryn Sharp added a comment -

          Trunk/2.0 is lacking a test for RPC.getServerAddress, so adding a patch for my new test.

          Show
          Daryn Sharp added a comment - Trunk/2.0 is lacking a test for RPC.getServerAddress , so adding a patch for my new test.
          Daryn Sharp made changes -
          Attachment TestRPC.trunk.patch [ 12526174 ]
          Hide
          Robert Joseph Evans added a comment -

          The patch looks good to me. My only concern is that it looks like you added in a test that was not a part of the original code. I would be great to have that test on more then just branch-0.23 Other then that +1. It compiles and passed my tests.

          I'll check the current patch into branch-0.23 now, and assuming you get a patch up for the test I'll throw that into trunk/branch-2 too.

          Show
          Robert Joseph Evans added a comment - The patch looks good to me. My only concern is that it looks like you added in a test that was not a part of the original code. I would be great to have that test on more then just branch-0.23 Other then that +1. It compiles and passed my tests. I'll check the current patch into branch-0.23 now, and assuming you get a patch up for the test I'll throw that into trunk/branch-2 too.
          Hide
          Aaron T. Myers added a comment -

          Small clarification: I believe this function was introduced via PB changes, not HA. That probably doesn't change your reasoning for wanting it in branch-0.23, but I figured I'd point it out.

          One question: why is it that this function is needed, if nothing is currently calling it in branch-0.23?

          Show
          Aaron T. Myers added a comment - Small clarification: I believe this function was introduced via PB changes, not HA. That probably doesn't change your reasoning for wanting it in branch-0.23, but I figured I'd point it out. One question: why is it that this function is needed, if nothing is currently calling it in branch-0.23?
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12526174/TestRPC.trunk.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/966//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/966//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12526174/TestRPC.trunk.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/966//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/966//console This message is automatically generated.
          Hide
          Daryn Sharp added a comment -

          Thanks for the clarification. The linked blocker MAPREDUCE-4162 will use the method. Specifically, it's used to get the address a proxy is connected to in order to correctly set the service for host-based tokens.

          Show
          Daryn Sharp added a comment - Thanks for the clarification. The linked blocker MAPREDUCE-4162 will use the method. Specifically, it's used to get the address a proxy is connected to in order to correctly set the service for host-based tokens.
          Hide
          Aaron T. Myers added a comment -

          Got it, makes sense. Thanks for the info. No objections from me.

          Show
          Aaron T. Myers added a comment - Got it, makes sense. Thanks for the info. No objections from me.
          Hide
          Robert Joseph Evans added a comment -

          Thanks for the fix Daryn,

          I put the full patch into branch-0.23, and pulled in just the new test into trunk and branch-2.

          Show
          Robert Joseph Evans added a comment - Thanks for the fix Daryn, I put the full patch into branch-0.23, and pulled in just the new test into trunk and branch-2.
          Robert Joseph Evans made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags Reviewed [ 10343 ]
          Fix Version/s 0.23.3 [ 12320059 ]
          Fix Version/s 2.0.0 [ 12320352 ]
          Fix Version/s 3.0.0 [ 12320357 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #2287 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2287/)
          HADOOP-8373. Port RPC.getServerAddress to 0.23 (Daryn Sharp via bobby) (Revision 1336299)

          Result = SUCCESS
          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1336299
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2287 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2287/ ) HADOOP-8373 . Port RPC.getServerAddress to 0.23 (Daryn Sharp via bobby) (Revision 1336299) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1336299 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #2212 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2212/)
          HADOOP-8373. Port RPC.getServerAddress to 0.23 (Daryn Sharp via bobby) (Revision 1336299)

          Result = SUCCESS
          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1336299
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2212 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2212/ ) HADOOP-8373 . Port RPC.getServerAddress to 0.23 (Daryn Sharp via bobby) (Revision 1336299) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1336299 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #2229 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2229/)
          HADOOP-8373. Port RPC.getServerAddress to 0.23 (Daryn Sharp via bobby) (Revision 1336299)

          Result = ABORTED
          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1336299
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2229 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2229/ ) HADOOP-8373 . Port RPC.getServerAddress to 0.23 (Daryn Sharp via bobby) (Revision 1336299) Result = ABORTED bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1336299 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1075 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1075/)
          HADOOP-8373. Port RPC.getServerAddress to 0.23 (Daryn Sharp via bobby) (Revision 1336299)

          Result = SUCCESS
          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1336299
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1075 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1075/ ) HADOOP-8373 . Port RPC.getServerAddress to 0.23 (Daryn Sharp via bobby) (Revision 1336299) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1336299 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-0.23-Build #253 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/253/)
          HADOOP-8373. Port RPC.getServerAddress to 0.23 (Daryn Sharp via bobby) (Revision 1336297)

          Result = SUCCESS
          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1336297
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryInvocationHandler.java
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RpcInvocationHandler.java
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #253 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/253/ ) HADOOP-8373 . Port RPC.getServerAddress to 0.23 (Daryn Sharp via bobby) (Revision 1336297) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1336297 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryInvocationHandler.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RpcInvocationHandler.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #1040 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1040/)
          HADOOP-8373. Port RPC.getServerAddress to 0.23 (Daryn Sharp via bobby) (Revision 1336299)

          Result = FAILURE
          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1336299
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1040 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1040/ ) HADOOP-8373 . Port RPC.getServerAddress to 0.23 (Daryn Sharp via bobby) (Revision 1336299) Result = FAILURE bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1336299 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
          Arun C Murthy made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Arun C Murthy made changes -
          Fix Version/s 2.0.2-alpha [ 12322473 ]
          Fix Version/s 2.0.0-alpha [ 12320352 ]
          Fix Version/s 3.0.0 [ 12320357 ]

            People

            • Assignee:
              Daryn Sharp
              Reporter:
              Daryn Sharp
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development