Hadoop Common
  1. Hadoop Common
  2. HADOOP-8367

Improve documentation of declaringClassProtocolName in rpc headers

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-alpha
    • Fix Version/s: 2.0.2-alpha
    • Component/s: None
    • Labels:
      None
    1. hadoop-8367-2.patch
      5 kB
      Sanjay Radia
    2. hadoop-8367-1.patch
      4 kB
      Sanjay Radia

      Issue Links

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #2303 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2303/)
        HADOOP-8367 Improve documentation of declaringClassProtocolName in rpc headers (Sanjay Radia) (Revision 1342051)

        Result = FAILURE
        sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1342051
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/hadoop_rpc.proto
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2303 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2303/ ) HADOOP-8367 Improve documentation of declaringClassProtocolName in rpc headers (Sanjay Radia) (Revision 1342051) Result = FAILURE sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1342051 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/hadoop_rpc.proto
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2285 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2285/)
        HADOOP-8367 Improve documentation of declaringClassProtocolName in rpc headers (Sanjay Radia) (Revision 1342051)

        Result = SUCCESS
        sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1342051
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/hadoop_rpc.proto
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2285 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2285/ ) HADOOP-8367 Improve documentation of declaringClassProtocolName in rpc headers (Sanjay Radia) (Revision 1342051) Result = SUCCESS sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1342051 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/hadoop_rpc.proto
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2358 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2358/)
        HADOOP-8367 Improve documentation of declaringClassProtocolName in rpc headers (Sanjay Radia) (Revision 1342051)

        Result = SUCCESS
        sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1342051
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/hadoop_rpc.proto
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2358 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2358/ ) HADOOP-8367 Improve documentation of declaringClassProtocolName in rpc headers (Sanjay Radia) (Revision 1342051) Result = SUCCESS sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1342051 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/hadoop_rpc.proto
        Hide
        Sanjay Radia added a comment -

        New tests not needed - javadoc improvements.
        Committed.

        Show
        Sanjay Radia added a comment - New tests not needed - javadoc improvements. Committed.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12528763/hadoop-8367-2.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common:

        org.apache.hadoop.fs.viewfs.TestViewFsTrash

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1025//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1025//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12528763/hadoop-8367-2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common: org.apache.hadoop.fs.viewfs.TestViewFsTrash +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1025//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1025//console This message is automatically generated.
        Hide
        Suresh Srinivas added a comment -

        Minor comments:

        1. ProtobufRpcEngine.java
          • Typo differnt
          • The newly added comment is not very clear. Can you please add more information about what you mean by metaProtocols. Also the sentense does not read right. It might make sense to capture the same comments from hadoop_rpc.proto in here.
        2. hadoop_rpc.proto some lines are going beyond 80 characters. Also the last sentence in the newly added comment does not read right.
        Show
        Suresh Srinivas added a comment - Minor comments: ProtobufRpcEngine.java Typo differnt The newly added comment is not very clear. Can you please add more information about what you mean by metaProtocols. Also the sentense does not read right. It might make sense to capture the same comments from hadoop_rpc.proto in here. hadoop_rpc.proto some lines are going beyond 80 characters. Also the last sentence in the newly added comment does not read right.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12526594/hadoop-8367-1.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common:

        org.apache.hadoop.fs.viewfs.TestViewFsTrash

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/988//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/988//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12526594/hadoop-8367-1.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common: org.apache.hadoop.fs.viewfs.TestViewFsTrash +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/988//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/988//console This message is automatically generated.
        Hide
        Sanjay Radia added a comment -

        I was wrong here. Since the connection is reused, the declaringClassProtocolName is needed.
        Will better document this in the code; will change the jira title to do this.

        Show
        Sanjay Radia added a comment - I was wrong here. Since the connection is reused, the declaringClassProtocolName is needed. Will better document this in the code; will change the jira title to do this.
        Hide
        Sanjay Radia added a comment -

        The declaring-class name was added to the writable rpc engine's header to deal with the VersionedProtocol. Not needed for PB since version number is handled differently.

        Show
        Sanjay Radia added a comment - The declaring-class name was added to the writable rpc engine's header to deal with the VersionedProtocol. Not needed for PB since version number is handled differently.

          People

          • Assignee:
            Sanjay Radia
            Reporter:
            Sanjay Radia
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development