Hadoop Common
  1. Hadoop Common
  2. HADOOP-8354

test-patch findbugs may fail if a dependent module is changed

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      This can happen when code in a dependent module is changed, but the change isn't picked up. E.g.

      https://issues.apache.org/jira/browse/MAPREDUCE-4163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266867#comment-13266867

      We can fix this by running 'mvn install -DskipTests -Dmaven.javadoc.skip=true' first.

      1. HADOOP-8354.txt
        1 kB
        Robert Joseph Evans

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1040 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1040/)
        HADOOP-8354. test-patch findbugs may fail if a dependent module is changed Contributed by Tom White and Robert Evans. (Revision 1336213)

        Result = FAILURE
        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1336213
        Files :

        • /hadoop/common/trunk/dev-support/test-patch.sh
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1040 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1040/ ) HADOOP-8354 . test-patch findbugs may fail if a dependent module is changed Contributed by Tom White and Robert Evans. (Revision 1336213) Result = FAILURE bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1336213 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1075 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1075/)
        HADOOP-8354. test-patch findbugs may fail if a dependent module is changed Contributed by Tom White and Robert Evans. (Revision 1336213)

        Result = SUCCESS
        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1336213
        Files :

        • /hadoop/common/trunk/dev-support/test-patch.sh
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1075 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1075/ ) HADOOP-8354 . test-patch findbugs may fail if a dependent module is changed Contributed by Tom White and Robert Evans. (Revision 1336213) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1336213 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #2228 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2228/)
        HADOOP-8354. test-patch findbugs may fail if a dependent module is changed Contributed by Tom White and Robert Evans. (Revision 1336213)

        Result = ABORTED
        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1336213
        Files :

        • /hadoop/common/trunk/dev-support/test-patch.sh
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2228 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2228/ ) HADOOP-8354 . test-patch findbugs may fail if a dependent module is changed Contributed by Tom White and Robert Evans. (Revision 1336213) Result = ABORTED bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1336213 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2211 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2211/)
        HADOOP-8354. test-patch findbugs may fail if a dependent module is changed Contributed by Tom White and Robert Evans. (Revision 1336213)

        Result = SUCCESS
        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1336213
        Files :

        • /hadoop/common/trunk/dev-support/test-patch.sh
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2211 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2211/ ) HADOOP-8354 . test-patch findbugs may fail if a dependent module is changed Contributed by Tom White and Robert Evans. (Revision 1336213) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1336213 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2286 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2286/)
        HADOOP-8354. test-patch findbugs may fail if a dependent module is changed Contributed by Tom White and Robert Evans. (Revision 1336213)

        Result = SUCCESS
        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1336213
        Files :

        • /hadoop/common/trunk/dev-support/test-patch.sh
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2286 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2286/ ) HADOOP-8354 . test-patch findbugs may fail if a dependent module is changed Contributed by Tom White and Robert Evans. (Revision 1336213) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1336213 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        Robert Joseph Evans added a comment -

        @Tom,
        I am happy to help out how I can. Plus it's not like my contribution to this was all that hard. Copy and paste from the JIRA and verify that it did fix my issue.

        Show
        Robert Joseph Evans added a comment - @Tom, I am happy to help out how I can. Plus it's not like my contribution to this was all that hard. Copy and paste from the JIRA and verify that it did fix my issue.
        Hide
        Tom White added a comment -

        +1 Thanks for fixing this Robert.

        Show
        Tom White added a comment - +1 Thanks for fixing this Robert.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12526041/HADOOP-8354.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/962//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/962//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12526041/HADOOP-8354.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/962//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/962//console This message is automatically generated.
        Hide
        Robert Joseph Evans added a comment -

        I just verified that this fixed both the fidbugs and the junit issues. I will be uploading a patch shortly.

        Show
        Robert Joseph Evans added a comment - I just verified that this fixed both the fidbugs and the junit issues. I will be uploading a patch shortly.
        Hide
        Robert Joseph Evans added a comment -

        I just saw a very strange issue while running some of the tests.

        https://issues.apache.org/jira/browse/MAPREDUCE-4233?focusedCommentId=13270757&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13270757

        I am putting it here because I think it is for the same reason. The Jars were not installed first so the tests were run against an older version of the code, not the patched version.

        Show
        Robert Joseph Evans added a comment - I just saw a very strange issue while running some of the tests. https://issues.apache.org/jira/browse/MAPREDUCE-4233?focusedCommentId=13270757&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13270757 I am putting it here because I think it is for the same reason. The Jars were not installed first so the tests were run against an older version of the code, not the patched version.

          People

          • Assignee:
            Robert Joseph Evans
            Reporter:
            Tom White
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development