Hadoop Common
  1. Hadoop Common
  2. HADOOP-8339

jenkins complaining about 16 javadoc warnings

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0
    • Fix Version/s: 3.0.0
    • Component/s: build
    • Labels:
      None
    • Target Version/s:

      Description

      See any of the mapreduce/hadoop jenkins reports recently and they all complain about 16 javadoc warnings.

      -1 javadoc. The javadoc tool appears to have generated 16 warning messages.

      Which really means there are 24 since there are 8 that are supposed to be OK.

      1. HADOOP-8339.patch
        16 kB
        Tom White
      2. HADOOP-8339.txt
        18 kB
        Robert Joseph Evans
      3. HADOOP-8339.txt
        18 kB
        Robert Joseph Evans
      4. HADOOP-8339.txt
        18 kB
        Robert Joseph Evans

        Activity

        Hide
        Tsz Wo Nicholas Sze added a comment -

        I filed HADOOP-8375.

        Show
        Tsz Wo Nicholas Sze added a comment - I filed HADOOP-8375 .
        Hide
        Robert Joseph Evans added a comment -

        I agree that test-patch should stop on compilation errors. +1 for that.

        Show
        Robert Joseph Evans added a comment - I agree that test-patch should stop on compilation errors. +1 for that.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        There are compilation errors in HDFS-3369. The javadoc check may be confused by them.

        BTW, I think test-patch should stop immediately once it has found compilation errors. It was the behavior previously if I remember correctly.

        Show
        Tsz Wo Nicholas Sze added a comment - There are compilation errors in HDFS-3369 . The javadoc check may be confused by them. BTW, I think test-patch should stop immediately once it has found compilation errors. It was the behavior previously if I remember correctly.
        Hide
        Robert Joseph Evans added a comment -

        @Nicholas,

        Well I really don't know for sure what caused this, but the difference in the javadoc warnings are the following two lines are missing in HDFS-3369.

        [WARNING] hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/XmlEditsVisitor.java:32: warning: com.sun.org.apache.xml.internal.serialize.OutputFormat is Sun proprietary API and may be removed in a future release
        [WARNING] /hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/XmlEditsVisitor.java:33: warning: com.sun.org.apache.xml.internal.serialize.XMLSerializer is Sun proprietary API and may be removed in a future release
        

        The patch does not look like it did anything to fix the issues, so I really don't know why the disappeared. HADOOP-8344 should hopefully help with this issue.

        Show
        Robert Joseph Evans added a comment - @Nicholas, Well I really don't know for sure what caused this, but the difference in the javadoc warnings are the following two lines are missing in HDFS-3369 . [WARNING] hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/XmlEditsVisitor.java:32: warning: com.sun.org.apache.xml.internal.serialize.OutputFormat is Sun proprietary API and may be removed in a future release [WARNING] /hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/XmlEditsVisitor.java:33: warning: com.sun.org.apache.xml.internal.serialize.XMLSerializer is Sun proprietary API and may be removed in a future release The patch does not look like it did anything to fix the issues, so I really don't know why the disappeared. HADOOP-8344 should hopefully help with this issue.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        We got a funny "-1 javadoc. The javadoc tool appears to have generated -2 warning messages." in HDFS-3369. What to do in order to fix it?

        Show
        Tsz Wo Nicholas Sze added a comment - We got a funny "-1 javadoc. The javadoc tool appears to have generated -2 warning messages." in HDFS-3369 . What to do in order to fix it?
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1067 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1067/)
        HADOOP-8339. jenkins complaining about 16 javadoc warnings (Tom White and Robert Evans via tgraves) (Revision 1332853)

        Result = FAILURE
        tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332853
        Files :

        • /hadoop/common/trunk/dev-support/test-patch.properties
        • /hadoop/common/trunk/dev-support/test-patch.sh
        • /hadoop/common/trunk/hadoop-common-project/dev-support/test-patch.properties
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/FenceMethod.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/HAServiceProtocol.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/resources/test-patch.properties
        • /hadoop/common/trunk/hadoop-hdfs-project/dev-support/test-patch.properties
        • /hadoop/common/trunk/hadoop-mapreduce-project/dev-support/test-patch.properties
        • /hadoop/common/trunk/hadoop-tools/hadoop-extras/src/main/java/org/apache/hadoop/mapred/tools/package-info.java
        • /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/CurrentJHParser.java
        • /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/LoggedTaskAttempt.java
        • /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/datatypes/util/MapReduceJobPropertiesParser.java
        • /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/package-info.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1067 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1067/ ) HADOOP-8339 . jenkins complaining about 16 javadoc warnings (Tom White and Robert Evans via tgraves) (Revision 1332853) Result = FAILURE tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332853 Files : /hadoop/common/trunk/dev-support/test-patch.properties /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/dev-support/test-patch.properties /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/FenceMethod.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/HAServiceProtocol.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/resources/test-patch.properties /hadoop/common/trunk/hadoop-hdfs-project/dev-support/test-patch.properties /hadoop/common/trunk/hadoop-mapreduce-project/dev-support/test-patch.properties /hadoop/common/trunk/hadoop-tools/hadoop-extras/src/main/java/org/apache/hadoop/mapred/tools/package-info.java /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/CurrentJHParser.java /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/LoggedTaskAttempt.java /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/datatypes/util/MapReduceJobPropertiesParser.java /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/package-info.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1032 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1032/)
        HADOOP-8339. jenkins complaining about 16 javadoc warnings (Tom White and Robert Evans via tgraves) (Revision 1332853)

        Result = FAILURE
        tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332853
        Files :

        • /hadoop/common/trunk/dev-support/test-patch.properties
        • /hadoop/common/trunk/dev-support/test-patch.sh
        • /hadoop/common/trunk/hadoop-common-project/dev-support/test-patch.properties
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/FenceMethod.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/HAServiceProtocol.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/resources/test-patch.properties
        • /hadoop/common/trunk/hadoop-hdfs-project/dev-support/test-patch.properties
        • /hadoop/common/trunk/hadoop-mapreduce-project/dev-support/test-patch.properties
        • /hadoop/common/trunk/hadoop-tools/hadoop-extras/src/main/java/org/apache/hadoop/mapred/tools/package-info.java
        • /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/CurrentJHParser.java
        • /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/LoggedTaskAttempt.java
        • /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/datatypes/util/MapReduceJobPropertiesParser.java
        • /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/package-info.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1032 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1032/ ) HADOOP-8339 . jenkins complaining about 16 javadoc warnings (Tom White and Robert Evans via tgraves) (Revision 1332853) Result = FAILURE tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332853 Files : /hadoop/common/trunk/dev-support/test-patch.properties /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/dev-support/test-patch.properties /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/FenceMethod.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/HAServiceProtocol.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/resources/test-patch.properties /hadoop/common/trunk/hadoop-hdfs-project/dev-support/test-patch.properties /hadoop/common/trunk/hadoop-mapreduce-project/dev-support/test-patch.properties /hadoop/common/trunk/hadoop-tools/hadoop-extras/src/main/java/org/apache/hadoop/mapred/tools/package-info.java /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/CurrentJHParser.java /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/LoggedTaskAttempt.java /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/datatypes/util/MapReduceJobPropertiesParser.java /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/package-info.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #2186 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2186/)
        HADOOP-8339. jenkins complaining about 16 javadoc warnings (Tom White and Robert Evans via tgraves) (Revision 1332853)

        Result = FAILURE
        tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332853
        Files :

        • /hadoop/common/trunk/dev-support/test-patch.properties
        • /hadoop/common/trunk/dev-support/test-patch.sh
        • /hadoop/common/trunk/hadoop-common-project/dev-support/test-patch.properties
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/FenceMethod.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/HAServiceProtocol.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/resources/test-patch.properties
        • /hadoop/common/trunk/hadoop-hdfs-project/dev-support/test-patch.properties
        • /hadoop/common/trunk/hadoop-mapreduce-project/dev-support/test-patch.properties
        • /hadoop/common/trunk/hadoop-tools/hadoop-extras/src/main/java/org/apache/hadoop/mapred/tools/package-info.java
        • /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/CurrentJHParser.java
        • /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/LoggedTaskAttempt.java
        • /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/datatypes/util/MapReduceJobPropertiesParser.java
        • /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/package-info.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2186 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2186/ ) HADOOP-8339 . jenkins complaining about 16 javadoc warnings (Tom White and Robert Evans via tgraves) (Revision 1332853) Result = FAILURE tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332853 Files : /hadoop/common/trunk/dev-support/test-patch.properties /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/dev-support/test-patch.properties /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/FenceMethod.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/HAServiceProtocol.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/resources/test-patch.properties /hadoop/common/trunk/hadoop-hdfs-project/dev-support/test-patch.properties /hadoop/common/trunk/hadoop-mapreduce-project/dev-support/test-patch.properties /hadoop/common/trunk/hadoop-tools/hadoop-extras/src/main/java/org/apache/hadoop/mapred/tools/package-info.java /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/CurrentJHParser.java /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/LoggedTaskAttempt.java /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/datatypes/util/MapReduceJobPropertiesParser.java /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/package-info.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2170 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2170/)
        HADOOP-8339. jenkins complaining about 16 javadoc warnings (Tom White and Robert Evans via tgraves) (Revision 1332853)

        Result = SUCCESS
        tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332853
        Files :

        • /hadoop/common/trunk/dev-support/test-patch.properties
        • /hadoop/common/trunk/dev-support/test-patch.sh
        • /hadoop/common/trunk/hadoop-common-project/dev-support/test-patch.properties
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/FenceMethod.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/HAServiceProtocol.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/resources/test-patch.properties
        • /hadoop/common/trunk/hadoop-hdfs-project/dev-support/test-patch.properties
        • /hadoop/common/trunk/hadoop-mapreduce-project/dev-support/test-patch.properties
        • /hadoop/common/trunk/hadoop-tools/hadoop-extras/src/main/java/org/apache/hadoop/mapred/tools/package-info.java
        • /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/CurrentJHParser.java
        • /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/LoggedTaskAttempt.java
        • /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/datatypes/util/MapReduceJobPropertiesParser.java
        • /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/package-info.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2170 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2170/ ) HADOOP-8339 . jenkins complaining about 16 javadoc warnings (Tom White and Robert Evans via tgraves) (Revision 1332853) Result = SUCCESS tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332853 Files : /hadoop/common/trunk/dev-support/test-patch.properties /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/dev-support/test-patch.properties /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/FenceMethod.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/HAServiceProtocol.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/resources/test-patch.properties /hadoop/common/trunk/hadoop-hdfs-project/dev-support/test-patch.properties /hadoop/common/trunk/hadoop-mapreduce-project/dev-support/test-patch.properties /hadoop/common/trunk/hadoop-tools/hadoop-extras/src/main/java/org/apache/hadoop/mapred/tools/package-info.java /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/CurrentJHParser.java /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/LoggedTaskAttempt.java /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/datatypes/util/MapReduceJobPropertiesParser.java /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/package-info.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2244 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2244/)
        HADOOP-8339. jenkins complaining about 16 javadoc warnings (Tom White and Robert Evans via tgraves) (Revision 1332853)

        Result = SUCCESS
        tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332853
        Files :

        • /hadoop/common/trunk/dev-support/test-patch.properties
        • /hadoop/common/trunk/dev-support/test-patch.sh
        • /hadoop/common/trunk/hadoop-common-project/dev-support/test-patch.properties
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/FenceMethod.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/HAServiceProtocol.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/resources/test-patch.properties
        • /hadoop/common/trunk/hadoop-hdfs-project/dev-support/test-patch.properties
        • /hadoop/common/trunk/hadoop-mapreduce-project/dev-support/test-patch.properties
        • /hadoop/common/trunk/hadoop-tools/hadoop-extras/src/main/java/org/apache/hadoop/mapred/tools/package-info.java
        • /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/CurrentJHParser.java
        • /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/LoggedTaskAttempt.java
        • /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/datatypes/util/MapReduceJobPropertiesParser.java
        • /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/package-info.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2244 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2244/ ) HADOOP-8339 . jenkins complaining about 16 javadoc warnings (Tom White and Robert Evans via tgraves) (Revision 1332853) Result = SUCCESS tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332853 Files : /hadoop/common/trunk/dev-support/test-patch.properties /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/dev-support/test-patch.properties /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/FenceMethod.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/HAServiceProtocol.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/resources/test-patch.properties /hadoop/common/trunk/hadoop-hdfs-project/dev-support/test-patch.properties /hadoop/common/trunk/hadoop-mapreduce-project/dev-support/test-patch.properties /hadoop/common/trunk/hadoop-tools/hadoop-extras/src/main/java/org/apache/hadoop/mapred/tools/package-info.java /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/CurrentJHParser.java /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/LoggedTaskAttempt.java /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/datatypes/util/MapReduceJobPropertiesParser.java /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/package-info.java
        Hide
        Thomas Graves added a comment -

        +1 lgtm. I see the findbugs will be handled by HADOOP-8341. Thanks Bobby and Tom!

        Show
        Thomas Graves added a comment - +1 lgtm. I see the findbugs will be handled by HADOOP-8341 . Thanks Bobby and Tom!
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12525215/HADOOP-8339.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        -1 findbugs. The patch appears to introduce 10 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-tools/hadoop-extras hadoop-tools/hadoop-rumen.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/916//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/916//artifact/trunk/trunk/patchprocess/newPatchFindbugsWarningshadoop-rumen.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/916//artifact/trunk/trunk/patchprocess/newPatchFindbugsWarningshadoop-extras.html
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/916//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12525215/HADOOP-8339.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. -1 findbugs. The patch appears to introduce 10 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-tools/hadoop-extras hadoop-tools/hadoop-rumen. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/916//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/916//artifact/trunk/trunk/patchprocess/newPatchFindbugsWarningshadoop-rumen.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/916//artifact/trunk/trunk/patchprocess/newPatchFindbugsWarningshadoop-extras.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/916//console This message is automatically generated.
        Hide
        Tom White added a comment -

        Robert - your latest change looks good to me.

        Show
        Tom White added a comment - Robert - your latest change looks good to me.
        Hide
        Robert Joseph Evans added a comment -

        I feel dumb I had a -eq when it should have been a -ne. Thanks for seeing that Tom.

        Show
        Robert Joseph Evans added a comment - I feel dumb I had a -eq when it should have been a -ne. Thanks for seeing that Tom.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12525206/HADOOP-8339.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        -1 findbugs. The patch appears to introduce 10 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-tools/hadoop-extras hadoop-tools/hadoop-rumen.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/914//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/914//artifact/trunk/trunk/patchprocess/newPatchFindbugsWarningshadoop-rumen.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/914//artifact/trunk/trunk/patchprocess/newPatchFindbugsWarningshadoop-extras.html
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/914//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12525206/HADOOP-8339.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. -1 findbugs. The patch appears to introduce 10 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-tools/hadoop-extras hadoop-tools/hadoop-rumen. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/914//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/914//artifact/trunk/trunk/patchprocess/newPatchFindbugsWarningshadoop-rumen.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/914//artifact/trunk/trunk/patchprocess/newPatchFindbugsWarningshadoop-extras.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/914//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12525204/HADOOP-8339.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        -1 findbugs. The patch appears to introduce 10 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-tools/hadoop-extras hadoop-tools/hadoop-rumen.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/913//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/913//artifact/trunk/trunk/patchprocess/newPatchFindbugsWarningshadoop-rumen.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/913//artifact/trunk/trunk/patchprocess/newPatchFindbugsWarningshadoop-extras.html
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/913//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12525204/HADOOP-8339.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. -1 findbugs. The patch appears to introduce 10 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-tools/hadoop-extras hadoop-tools/hadoop-rumen. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/913//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/913//artifact/trunk/trunk/patchprocess/newPatchFindbugsWarningshadoop-rumen.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/913//artifact/trunk/trunk/patchprocess/newPatchFindbugsWarningshadoop-extras.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/913//console This message is automatically generated.
        Hide
        Robert Joseph Evans added a comment -

        Oops I forgot to remove a shortcut I added for testing. This patch should be good.

        Show
        Robert Joseph Evans added a comment - Oops I forgot to remove a shortcut I added for testing. This patch should be good.
        Hide
        Robert Joseph Evans added a comment -

        This is really just a copy of Tom White's patch with the 6 allowable javadoc warnings set, and and -eq instead of a -gt. All I really did was test this.

        Show
        Robert Joseph Evans added a comment - This is really just a copy of Tom White's patch with the 6 allowable javadoc warnings set, and and -eq instead of a -gt. All I really did was test this.
        Hide
        Jonathan Eagles added a comment -

        Minor thought. Can the greater-than check for warnings be changed to not-equal-to? This will give us better visibility, for example, when javadoc warnings are reduced in code but not in the properties file.

        Show
        Jonathan Eagles added a comment - Minor thought. Can the greater-than check for warnings be changed to not-equal-to? This will give us better visibility, for example, when javadoc warnings are reduced in code but not in the properties file.
        Hide
        Tom White added a comment -

        I had a look at this earlier - here's the patch I came up with. Note that we can remove all but the top-level test-patch.properties. Also, we still need to record the allowed number of javadoc warnings (6) since the ones resulting from use of com.sun packages cannot be easily suppressed.

        Show
        Tom White added a comment - I had a look at this earlier - here's the patch I came up with. Note that we can remove all but the top-level test-patch.properties. Also, we still need to record the allowed number of javadoc warnings (6) since the ones resulting from use of com.sun packages cannot be easily suppressed.
        Hide
        Thomas Graves added a comment -

        It looks like the test-patch.properties file at the top level /dev-support needs to be updated to take into account each sub project. 6 of the warnings are from rumen, which never got built before.

        Also the sub-project test-patch.properties need to be udpated too as common and hdfs have more then its actually generating.

        Show
        Thomas Graves added a comment - It looks like the test-patch.properties file at the top level /dev-support needs to be updated to take into account each sub project. 6 of the warnings are from rumen, which never got built before. Also the sub-project test-patch.properties need to be udpated too as common and hdfs have more then its actually generating.

          People

          • Assignee:
            Robert Joseph Evans
            Reporter:
            Thomas Graves
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development