Hadoop Common
  1. Hadoop Common
  2. HADOOP-8334

HttpServer sometimes returns incorrect port

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.3, 0.24.0, 2.0.0-alpha
    • Fix Version/s: 0.23.3, 2.0.2-alpha
    • Component/s: None
    • Labels:
      None

      Description

      HttpServer is not always returning the correct listening port.

        Issue Links

          Activity

          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          5m 4s 1 Daryn Sharp 30/Apr/12 19:27
          Patch Available Patch Available Resolved Resolved
          35m 20s 1 Robert Joseph Evans 30/Apr/12 20:02
          Resolved Resolved Closed Closed
          23d 1h 12m 1 Arun C Murthy 23/May/12 21:15
          Arun C Murthy made changes -
          Fix Version/s 2.0.2-alpha [ 12322473 ]
          Fix Version/s 2.0.0-alpha [ 12320352 ]
          Fix Version/s 3.0.0 [ 12320357 ]
          Arun C Murthy made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1066 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1066/)
          HADOOP-8334. HttpServer sometimes returns incorrect port (Daryn Sharp via bobby) (Revision 1332336)

          Result = FAILURE
          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332336
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/HttpServerFunctionalTest.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServer.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1066 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1066/ ) HADOOP-8334 . HttpServer sometimes returns incorrect port (Daryn Sharp via bobby) (Revision 1332336) Result = FAILURE bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332336 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/HttpServerFunctionalTest.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServer.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #1031 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1031/)
          HADOOP-8334. HttpServer sometimes returns incorrect port (Daryn Sharp via bobby) (Revision 1332336)

          Result = FAILURE
          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332336
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/HttpServerFunctionalTest.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServer.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1031 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1031/ ) HADOOP-8334 . HttpServer sometimes returns incorrect port (Daryn Sharp via bobby) (Revision 1332336) Result = FAILURE bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332336 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/HttpServerFunctionalTest.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServer.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-0.23-Build #244 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/244/)
          svn merge -c 1332336. FIXES: HADOOP-8334. HttpServer sometimes returns incorrect port (Daryn Sharp via bobby) (Revision 1332338)

          Result = SUCCESS
          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332338
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/HttpServerFunctionalTest.java
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServer.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #244 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/244/ ) svn merge -c 1332336. FIXES: HADOOP-8334 . HttpServer sometimes returns incorrect port (Daryn Sharp via bobby) (Revision 1332338) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332338 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/HttpServerFunctionalTest.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServer.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #2171 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2171/)
          HADOOP-8334. HttpServer sometimes returns incorrect port (Daryn Sharp via bobby) (Revision 1332336)

          Result = ABORTED
          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332336
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/HttpServerFunctionalTest.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServer.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2171 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2171/ ) HADOOP-8334 . HttpServer sometimes returns incorrect port (Daryn Sharp via bobby) (Revision 1332336) Result = ABORTED bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332336 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/HttpServerFunctionalTest.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServer.java
          Daryn Sharp made changes -
          Link This issue is required by MAPREDUCE-3659 [ MAPREDUCE-3659 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #2154 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2154/)
          HADOOP-8334. HttpServer sometimes returns incorrect port (Daryn Sharp via bobby) (Revision 1332336)

          Result = SUCCESS
          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332336
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/HttpServerFunctionalTest.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServer.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2154 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2154/ ) HADOOP-8334 . HttpServer sometimes returns incorrect port (Daryn Sharp via bobby) (Revision 1332336) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332336 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/HttpServerFunctionalTest.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServer.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #2228 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2228/)
          HADOOP-8334. HttpServer sometimes returns incorrect port (Daryn Sharp via bobby) (Revision 1332336)

          Result = SUCCESS
          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332336
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/HttpServerFunctionalTest.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServer.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2228 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2228/ ) HADOOP-8334 . HttpServer sometimes returns incorrect port (Daryn Sharp via bobby) (Revision 1332336) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332336 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/HttpServerFunctionalTest.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServer.java
          Robert Joseph Evans made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Fix Version/s 0.23.3 [ 12320059 ]
          Fix Version/s 2.0.0 [ 12320352 ]
          Fix Version/s 3.0.0 [ 12320357 ]
          Resolution Fixed [ 1 ]
          Hide
          Robert Joseph Evans added a comment -

          Thanks Daryn,

          I put this into trunk, branch-2, and branch-0.23

          Show
          Robert Joseph Evans added a comment - Thanks Daryn, I put this into trunk, branch-2, and branch-0.23
          Hide
          Robert Joseph Evans added a comment -

          Yes, you are right once it is bound your really don't need to do any more then that. +1 (looks like there is already a JIRA for TestSequenceFile)

          Show
          Robert Joseph Evans added a comment - Yes, you are right once it is bound your really don't need to do any more then that. +1 (looks like there is already a JIRA for TestSequenceFile)
          Hide
          Daryn Sharp added a comment -

          I haven't brought this up on a full cluster, but yarn tests appear ok. This is only about successfully binding, so there aren't host issues to worry about.

          Show
          Daryn Sharp added a comment - I haven't brought this up on a full cluster, but yarn tests appear ok. This is only about successfully binding, so there aren't host issues to worry about.
          Hide
          Robert Joseph Evans added a comment -

          The changes look good, and a lot simpler then they were before. I like the new tests, and if everything passes I think it is OK. Have you tested this on a cluster?

          Show
          Robert Joseph Evans added a comment - The changes look good, and a lot simpler then they were before. I like the new tests, and if everything passes I think it is OK. Have you tested this on a cluster?
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12525089/HADOOP-8334.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 2 new or modified test files.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.io.TestSequenceFile

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/905//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/905//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12525089/HADOOP-8334.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified test files. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.io.TestSequenceFile +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/905//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/905//console This message is automatically generated.
          Daryn Sharp made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Daryn Sharp made changes -
          Field Original Value New Value
          Attachment HADOOP-8334.patch [ 12525089 ]
          Hide
          Daryn Sharp added a comment -

          During some pending yarn work, HttpServer was returning -1 for the listening port on some of the tests. I found that -1 is only returned if the socket is not bound. This simplifies the logic of ensuring the port is bound.

          Show
          Daryn Sharp added a comment - During some pending yarn work, HttpServer was returning -1 for the listening port on some of the tests. I found that -1 is only returned if the socket is not bound. This simplifies the logic of ensuring the port is bound.
          Daryn Sharp created issue -

            People

            • Assignee:
              Daryn Sharp
              Reporter:
              Daryn Sharp
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development