Hadoop Common
  1. Hadoop Common
  2. HADOOP-8323

Revert HADOOP-7940 and improve javadocs and test for Text.clear()

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-alpha
    • Fix Version/s: 2.0.2-alpha
    • Component/s: io
    • Labels:

      Description

      Per Jim Donofrio's comments on HADOOP-7940, we should revert it as it has caused a performance regression (for scenarios where Text is reused, popular in MR).

      The clear() works as intended, as the API also offers a current length API.

      1. HADOOP-8323.patch
        3 kB
        Harsh J
      2. HADOOP-8323.patch
        3 kB
        Harsh J
      3. HADOOP-8323.patch
        3 kB
        Harsh J

        Issue Links

          Activity

          Hide
          Harsh J added a comment -

          Actually, I looked at the API and this would only impact the Text usage iff clear() is called upon it. I do not think we should revert this. Clear must work as intended - and clear the byte array states inside. There wouldn't be any other way to free the memory if we didn't do this.

          I do not see clear() being used in MR directly. So the largest length is still maintained but thats not an issue (except that clear may be called for memory gains if the user wants that).

          I'm resolving this as Won't Fix (Won't revert). But if I've missed addressing something, please reopen.

          Show
          Harsh J added a comment - Actually, I looked at the API and this would only impact the Text usage iff clear() is called upon it. I do not think we should revert this. Clear must work as intended - and clear the byte array states inside. There wouldn't be any other way to free the memory if we didn't do this. I do not see clear() being used in MR directly. So the largest length is still maintained but thats not an issue (except that clear may be called for memory gains if the user wants that). I'm resolving this as Won't Fix (Won't revert). But if I've missed addressing something, please reopen.
          Hide
          Jim Donofrio added a comment -

          > Clear call ought to clear memory and thats what this change actually intends to do (though the test case may lead you astray - filed HADOOP-8324).
          > The current javadocs indeed cover the getBytes usage behavior as you've pointed out. So if you'd like to keep the size in its increased state, why clear() it?

          /**

          • Resets the <code>count</code> field of this byte array output
          • stream to zero, so that all currently accumulated output in the
          • output stream is discarded. The output stream can be used again,
          • reusing the already allocated buffer space.
            *
          • @see java.io.ByteArrayInputStream#count
            */
            public synchronized void reset() { count = 0; }

          I would like to clear it so that the next time I call append, it will start at the beginning of the internal array without having to scale up the size of the array again. The ByteArrayOutputStream class in java.io which is every similar to Text has a reset method similar to clear that just sets the internal length to 0 instead of freeing the allocated internal buffer.

          However, I understand the need to free memory so why not leave clear as it is and add a clearBytes method which sets the length to 0 and sets the bytes to EMPTY_BYTES.

          Show
          Jim Donofrio added a comment - > Clear call ought to clear memory and thats what this change actually intends to do (though the test case may lead you astray - filed HADOOP-8324 ). > The current javadocs indeed cover the getBytes usage behavior as you've pointed out. So if you'd like to keep the size in its increased state, why clear() it? /** Resets the <code>count</code> field of this byte array output stream to zero, so that all currently accumulated output in the output stream is discarded. The output stream can be used again, reusing the already allocated buffer space. * @see java.io.ByteArrayInputStream#count */ public synchronized void reset() { count = 0; } I would like to clear it so that the next time I call append, it will start at the beginning of the internal array without having to scale up the size of the array again. The ByteArrayOutputStream class in java.io which is every similar to Text has a reset method similar to clear that just sets the internal length to 0 instead of freeing the allocated internal buffer. However, I understand the need to free memory so why not leave clear as it is and add a clearBytes method which sets the length to 0 and sets the bytes to EMPTY_BYTES.
          Hide
          Todd Lipcon added a comment -

          I agree with Jim - if we want a call which totally frees the memory, we should add a new one for it. But I don't see a big use case for that – if you want to free the memory, why not just drop the reference to the Text object itself and start with a new one? Or call text.set(new byte[0])?

          +1 for reverting HADOOP-7940.

          Show
          Todd Lipcon added a comment - I agree with Jim - if we want a call which totally frees the memory, we should add a new one for it. But I don't see a big use case for that – if you want to free the memory, why not just drop the reference to the Text object itself and start with a new one? Or call text.set(new byte [0] ) ? +1 for reverting HADOOP-7940 .
          Hide
          Harsh J added a comment -

          Attached patch reverts HADOOP-7940, adds a note about the actual behavior of clear(), a workaround in case freeing memory within the same object is required, and also improves test to catch regressions of this behavior.

          Show
          Harsh J added a comment - Attached patch reverts HADOOP-7940 , adds a note about the actual behavior of clear(), a workaround in case freeing memory within the same object is required, and also improves test to catch regressions of this behavior.
          Hide
          Jim Donofrio added a comment -

          +1 patch looks good to me

          Show
          Jim Donofrio added a comment - +1 patch looks good to me
          Hide
          Todd Lipcon added a comment -
          • in the Javadoc use HTML like <em>Note</em> instead of Note (hopefully JIRA doesn't mangle my comment here.. saying to use the 'em' HTML tag)
          • for the code example, use the 'code' html tag in the javadoc instead of double quotes
          • for the assertions, I think it's clearer for the provided string to state the expected behavior instead of the error behavior. for example: "String should empty after clear()" instead of "String isn't empty after clear"
          Show
          Todd Lipcon added a comment - in the Javadoc use HTML like <em>Note</em> instead of Note (hopefully JIRA doesn't mangle my comment here.. saying to use the 'em' HTML tag) for the code example, use the 'code' html tag in the javadoc instead of double quotes for the assertions, I think it's clearer for the provided string to state the expected behavior instead of the error behavior. for example: "String should empty after clear()" instead of "String isn't empty after clear"
          Hide
          Harsh J added a comment -

          New patch addresses all of Todd's comments.

          Show
          Harsh J added a comment - New patch addresses all of Todd's comments.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12525019/HADOOP-8323.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.io.TestSequenceFile

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/904//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/904//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12525019/HADOOP-8323.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.io.TestSequenceFile +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/904//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/904//console This message is automatically generated.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          Why reverting HADOOP-7940 is not done by the svn revert command but a separated patch?

          Show
          Tsz Wo Nicholas Sze added a comment - Why reverting HADOOP-7940 is not done by the svn revert command but a separated patch?
          Hide
          Harsh J added a comment -

          I'm unsure if I can revert a single commit back in history out. Is that possible to do Nicholas?

          I can as well do a svn revert, and then add in javadocs+freshtests via this JIRA. Would that be the right thing?

          Show
          Harsh J added a comment - I'm unsure if I can revert a single commit back in history out. Is that possible to do Nicholas? I can as well do a svn revert, and then add in javadocs+freshtests via this JIRA. Would that be the right thing?
          Hide
          Tsz Wo Nicholas Sze added a comment -

          Hi Harsh,

          You can do it by

          $svn merge -c -1295061 .
          --- Reverse-merging r1295061 into 'hadoop-common-project/hadoop-common/CHANGES.txt':
          U    hadoop-common-project/hadoop-common/CHANGES.txt
          --- Reverse-merging r1295061 into '.':
          U    hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestText.java
          --- Reverse-merging r1295061 into 'hadoop-common-project/hadoop-common/src/main/java':
          U    hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/Text.java
          

          Yes, the right thing is to first revert r1295061 and the commits to the branches, and then commit the new javadoc/test changes.

          Show
          Tsz Wo Nicholas Sze added a comment - Hi Harsh, You can do it by $svn merge -c -1295061 . --- Reverse-merging r1295061 into 'hadoop-common-project/hadoop-common/CHANGES.txt': U hadoop-common-project/hadoop-common/CHANGES.txt --- Reverse-merging r1295061 into '.': U hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestText.java --- Reverse-merging r1295061 into 'hadoop-common-project/hadoop-common/src/main/java': U hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/Text.java Yes, the right thing is to first revert r1295061 and the commits to the branches, and then commit the new javadoc/test changes.
          Hide
          Jim Donofrio added a comment -

          Shouldnt HADOOP-7940 get reverted before the 2.0.0-alpha1 release?

          Show
          Jim Donofrio added a comment - Shouldnt HADOOP-7940 get reverted before the 2.0.0-alpha1 release?
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #2268 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2268/)
          HADOOP-8323. Revert HADOOP-7940, cause it may cause a performance regression. (harsh) (Revision 1334603)

          Result = SUCCESS
          harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1334603
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/Text.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestText.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2268 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2268/ ) HADOOP-8323 . Revert HADOOP-7940 , cause it may cause a performance regression. (harsh) (Revision 1334603) Result = SUCCESS harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1334603 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/Text.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestText.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #2193 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2193/)
          HADOOP-8323. Revert HADOOP-7940, cause it may cause a performance regression. (harsh) (Revision 1334603)

          Result = SUCCESS
          harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1334603
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/Text.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestText.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2193 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2193/ ) HADOOP-8323 . Revert HADOOP-7940 , cause it may cause a performance regression. (harsh) (Revision 1334603) Result = SUCCESS harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1334603 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/Text.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestText.java
          Hide
          Harsh J added a comment -

          Reverting at the moment. Will attach new patch after that.

          Show
          Harsh J added a comment - Reverting at the moment. Will attach new patch after that.
          Hide
          Harsh J added a comment -

          (Successfully reverted from trunk and branch-2. Javadoc and new test patch to follow)

          Show
          Harsh J added a comment - (Successfully reverted from trunk and branch-2. Javadoc and new test patch to follow)
          Hide
          Harsh J added a comment -

          New patch that just adds a test + javadoc note.

          mvn clean test -Dtest=TestText passes.
          mvn javadoc:javadoc throws up only HADOOP-8359's two warnings.

          Show
          Harsh J added a comment - New patch that just adds a test + javadoc note. mvn clean test -Dtest=TestText passes. mvn javadoc:javadoc throws up only HADOOP-8359 's two warnings.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #2211 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2211/)
          HADOOP-8323. Revert HADOOP-7940, cause it may cause a performance regression. (harsh) (Revision 1334603)

          Result = ABORTED
          harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1334603
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/Text.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestText.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2211 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2211/ ) HADOOP-8323 . Revert HADOOP-7940 , cause it may cause a performance regression. (harsh) (Revision 1334603) Result = ABORTED harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1334603 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/Text.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestText.java
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12525770/HADOOP-8323.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          -1 javadoc. The javadoc tool appears to have generated 2 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/945//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/945//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12525770/HADOOP-8323.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. -1 javadoc. The javadoc tool appears to have generated 2 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/945//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/945//console This message is automatically generated.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #1036 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1036/)
          HADOOP-8323. Revert HADOOP-7940, cause it may cause a performance regression. (harsh) (Revision 1334603)

          Result = FAILURE
          harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1334603
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/Text.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestText.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1036 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1036/ ) HADOOP-8323 . Revert HADOOP-7940 , cause it may cause a performance regression. (harsh) (Revision 1334603) Result = FAILURE harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1334603 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/Text.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestText.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1071 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1071/)
          HADOOP-8323. Revert HADOOP-7940, cause it may cause a performance regression. (harsh) (Revision 1334603)

          Result = SUCCESS
          harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1334603
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/Text.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestText.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1071 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1071/ ) HADOOP-8323 . Revert HADOOP-7940 , cause it may cause a performance regression. (harsh) (Revision 1334603) Result = SUCCESS harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1334603 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/Text.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestText.java
          Hide
          Harsh J added a comment -

          -1 javadoc. The javadoc tool appears to have generated 2 warning messages.

          This is HADOOP-8359, not this patch.

          Show
          Harsh J added a comment - -1 javadoc. The javadoc tool appears to have generated 2 warning messages. This is HADOOP-8359 , not this patch.
          Hide
          Harsh J added a comment -

          Any further comments on the test and javadocs? If not, given that it is a trivial non-breaking addition I shall commit it in by Monday.

          Show
          Harsh J added a comment - Any further comments on the test and javadocs? If not, given that it is a trivial non-breaking addition I shall commit it in by Monday.
          Hide
          Harsh J added a comment -

          This is no longer a bug (since the bug was reverted). So marking as an improvement.

          Show
          Harsh J added a comment - This is no longer a bug (since the bug was reverted). So marking as an improvement.
          Hide
          Harsh J added a comment -

          Committed these trivial additions to branch-2 and trunk.

          Show
          Harsh J added a comment - Committed these trivial additions to branch-2 and trunk.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #1056 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1056/)
          HADOOP-8323. Add javadoc and tests for Text.clear() behavior (harsh) (Revision 1342514)

          Result = SUCCESS
          harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1342514
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/Text.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestText.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1056 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1056/ ) HADOOP-8323 . Add javadoc and tests for Text.clear() behavior (harsh) (Revision 1342514) Result = SUCCESS harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1342514 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/Text.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestText.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1090 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1090/)
          HADOOP-8323. Add javadoc and tests for Text.clear() behavior (harsh) (Revision 1342514)

          Result = ABORTED
          harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1342514
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/Text.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestText.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1090 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1090/ ) HADOOP-8323 . Add javadoc and tests for Text.clear() behavior (harsh) (Revision 1342514) Result = ABORTED harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1342514 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/Text.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestText.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #2361 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2361/)
          HADOOP-8323. Add javadoc and tests for Text.clear() behavior (harsh) (Revision 1342514)

          Result = SUCCESS
          harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1342514
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/Text.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestText.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2361 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2361/ ) HADOOP-8323 . Add javadoc and tests for Text.clear() behavior (harsh) (Revision 1342514) Result = SUCCESS harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1342514 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/Text.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestText.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #2288 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2288/)
          HADOOP-8323. Add javadoc and tests for Text.clear() behavior (harsh) (Revision 1342514)

          Result = SUCCESS
          harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1342514
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/Text.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestText.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2288 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2288/ ) HADOOP-8323 . Add javadoc and tests for Text.clear() behavior (harsh) (Revision 1342514) Result = SUCCESS harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1342514 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/Text.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestText.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #2307 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2307/)
          HADOOP-8323. Add javadoc and tests for Text.clear() behavior (harsh) (Revision 1342514)

          Result = FAILURE
          harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1342514
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/Text.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestText.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2307 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2307/ ) HADOOP-8323 . Add javadoc and tests for Text.clear() behavior (harsh) (Revision 1342514) Result = FAILURE harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1342514 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/Text.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestText.java

            People

            • Assignee:
              Harsh J
              Reporter:
              Harsh J
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development