Hadoop Common
  1. Hadoop Common
  2. HADOOP-8320

FileSystem#checkPath and AbstractFileSystem#checkPath should share code

    Details

    • Type: Improvement Improvement
    • Status: Patch Available
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: 2.0.0-alpha
    • Fix Version/s: None
    • Component/s: fs
    • Labels:
    • Release Note:
      Hide
      Moved the checkPath logic from the AbstractFileSystem and FileSystem classes to a "checkFileSystemPath" method in the Path class. The AbstracFileSystem and FileSystem checkPath method will call the common code in checkFileSystemPath (adapter pattern). This is because the two classes aren't derived from any common ancestor.

      There are no new test cases because existing test cases test the functionality that is being refactored. Adding new test cases would be redundant.
      Show
      Moved the checkPath logic from the AbstractFileSystem and FileSystem classes to a "checkFileSystemPath" method in the Path class. The AbstracFileSystem and FileSystem checkPath method will call the common code in checkFileSystemPath (adapter pattern). This is because the two classes aren't derived from any common ancestor. There are no new test cases because existing test cases test the functionality that is being refactored. Adding new test cases would be redundant.

      Description

      Per the discussion on HADOOP-8310, these two methods can be refactored to share some code.

      1. HADOOP-8320.007.patch
        8 kB
        Vijay Bhat
      2. HADOOP-8320.005.patch
        8 kB
        Vijay Bhat
      3. HADOOP-8320.004.patch
        7 kB
        Vijay Bhat
      4. HADOOP-8320.003.patch
        7 kB
        Vijay Bhat
      5. HADOOP-8320.002.patch
        7 kB
        Vijay Bhat
      6. HADOOP-8320.001.patch
        7 kB
        Vijay Bhat

        Activity

        No work has yet been logged on this issue.

          People

          • Assignee:
            Vijay Bhat
            Reporter:
            Aaron T. Myers
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:

              Development