Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.23.2, 2.0.0-alpha, 3.0.0
    • Fix Version/s: 2.0.0-alpha
    • Component/s: None
    • Labels:
      None

      Description

      $ yarn daemonlog

      USAGES:
      java org.apache.hadoop.log.LogLevel -getlevel <host:port> <name>
      java org.apache.hadoop.log.LogLevel -setlevel <host:port> <name> <level>

      The usage shouldn't print java org.apache.hadoop.log.LogLevel

      1. HADOOP-8296-1.patch
        0.9 kB
        Devaraj K
      2. HADOOP-8296.patch
        0.9 kB
        Devaraj K

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1061 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1061/)
        HADOOP-8296. hadoop/yarn daemonlog usage wrong (Devaraj K via tgraves) (Revision 1330445)

        Result = FAILURE
        tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1330445
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/log/LogLevel.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1061 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1061/ ) HADOOP-8296 . hadoop/yarn daemonlog usage wrong (Devaraj K via tgraves) (Revision 1330445) Result = FAILURE tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1330445 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/log/LogLevel.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1026 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1026/)
        HADOOP-8296. hadoop/yarn daemonlog usage wrong (Devaraj K via tgraves) (Revision 1330445)

        Result = FAILURE
        tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1330445
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/log/LogLevel.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1026 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1026/ ) HADOOP-8296 . hadoop/yarn daemonlog usage wrong (Devaraj K via tgraves) (Revision 1330445) Result = FAILURE tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1330445 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/log/LogLevel.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #2146 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2146/)
        HADOOP-8296. hadoop/yarn daemonlog usage wrong (Devaraj K via tgraves) (Revision 1330445)

        Result = SUCCESS
        tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1330445
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/log/LogLevel.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2146 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2146/ ) HADOOP-8296 . hadoop/yarn daemonlog usage wrong (Devaraj K via tgraves) (Revision 1330445) Result = SUCCESS tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1330445 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/log/LogLevel.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2130 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2130/)
        HADOOP-8296. hadoop/yarn daemonlog usage wrong (Devaraj K via tgraves) (Revision 1330445)

        Result = SUCCESS
        tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1330445
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/log/LogLevel.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2130 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2130/ ) HADOOP-8296 . hadoop/yarn daemonlog usage wrong (Devaraj K via tgraves) (Revision 1330445) Result = SUCCESS tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1330445 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/log/LogLevel.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2204 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2204/)
        HADOOP-8296. hadoop/yarn daemonlog usage wrong (Devaraj K via tgraves) (Revision 1330445)

        Result = SUCCESS
        tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1330445
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/log/LogLevel.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2204 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2204/ ) HADOOP-8296 . hadoop/yarn daemonlog usage wrong (Devaraj K via tgraves) (Revision 1330445) Result = SUCCESS tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1330445 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/log/LogLevel.java
        Hide
        Thomas Graves added a comment -

        committed this to trunk and branch-2.

        Show
        Thomas Graves added a comment - committed this to trunk and branch-2.
        Hide
        Thomas Graves added a comment -

        +1 lgtm. Thanks Devaraj!

        Show
        Thomas Graves added a comment - +1 lgtm. Thanks Devaraj!
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12524280/HADOOP-8296-1.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/887//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/887//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12524280/HADOOP-8296-1.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/887//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/887//console This message is automatically generated.
        Hide
        Devaraj K added a comment -

        Thanks Uma and Thomas for looking into the patch.

        I have updated patch.

        Show
        Devaraj K added a comment - Thanks Uma and Thomas for looking into the patch. I have updated patch.
        Hide
        Thomas Graves added a comment -

        Its unfortunately hadoop doesn't have a consistent usage output for its commands. I think what is here is better though. My only comment would be, can we put the options in brackets similar to hadoop fs/unix. like:

        [-getlevel <host:httpPort> <name>]
        [-setlevel <host:httpPort> <name> <level>]

        Show
        Thomas Graves added a comment - Its unfortunately hadoop doesn't have a consistent usage output for its commands. I think what is here is better though. My only comment would be, can we put the options in brackets similar to hadoop fs/unix. like: [-getlevel <host:httpPort> <name>] [-setlevel <host:httpPort> <name> <level>]
        Hide
        Uma Maheswara Rao G added a comment -

        Thanks Deva, patch looks good.

        @Thomas, do you have any comments?

        Show
        Uma Maheswara Rao G added a comment - Thanks Deva, patch looks good. @Thomas, do you have any comments?
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12523460/HADOOP-8296.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.fs.viewfs.TestViewFsTrash

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/872//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/872//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12523460/HADOOP-8296.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.fs.viewfs.TestViewFsTrash +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/872//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/872//console This message is automatically generated.
        Hide
        Devaraj K added a comment -

        Attached patch to address this issue.

        Show
        Devaraj K added a comment - Attached patch to address this issue.
        Hide
        Devaraj K added a comment -

        Moving it to common since it is issue in other components as well and changes involve in common.

        Show
        Devaraj K added a comment - Moving it to common since it is issue in other components as well and changes involve in common.

          People

          • Assignee:
            Devaraj K
            Reporter:
            Thomas Graves
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development