Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.1
    • Fix Version/s: 2.0.2-alpha
    • Component/s: conf
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      The etc/hadoop directory in the tarball is missing hadoop-env.sh. It should be copied over like the other files in share/hadoop/common/templates/conf. Noticed templates/conf also contains mapred-site.xml and taskcontroller.cfg, we should remove those while we're at it.

        Issue Links

          Activity

          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1083 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1083/)
          HADOOP-8287. etc/hadoop is missing hadoop-env.sh. Contributed by Eli Collins (Revision 1339906)

          Result = SUCCESS
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1339906
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/conf/hadoop-env.sh
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1083 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1083/ ) HADOOP-8287 . etc/hadoop is missing hadoop-env.sh. Contributed by Eli Collins (Revision 1339906) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1339906 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/conf/hadoop-env.sh
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #1049 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1049/)
          HADOOP-8287. etc/hadoop is missing hadoop-env.sh. Contributed by Eli Collins (Revision 1339906)

          Result = SUCCESS
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1339906
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/conf/hadoop-env.sh
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1049 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1049/ ) HADOOP-8287 . etc/hadoop is missing hadoop-env.sh. Contributed by Eli Collins (Revision 1339906) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1339906 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/conf/hadoop-env.sh
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #2283 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2283/)
          HADOOP-8287. etc/hadoop is missing hadoop-env.sh. Contributed by Eli Collins (Revision 1339906)

          Result = FAILURE
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1339906
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/conf/hadoop-env.sh
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2283 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2283/ ) HADOOP-8287 . etc/hadoop is missing hadoop-env.sh. Contributed by Eli Collins (Revision 1339906) Result = FAILURE eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1339906 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/conf/hadoop-env.sh
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #2265 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2265/)
          HADOOP-8287. etc/hadoop is missing hadoop-env.sh. Contributed by Eli Collins (Revision 1339906)

          Result = SUCCESS
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1339906
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/conf/hadoop-env.sh
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2265 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2265/ ) HADOOP-8287 . etc/hadoop is missing hadoop-env.sh. Contributed by Eli Collins (Revision 1339906) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1339906 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/conf/hadoop-env.sh
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #2338 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2338/)
          HADOOP-8287. etc/hadoop is missing hadoop-env.sh. Contributed by Eli Collins (Revision 1339906)

          Result = SUCCESS
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1339906
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/conf/hadoop-env.sh
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2338 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2338/ ) HADOOP-8287 . etc/hadoop is missing hadoop-env.sh. Contributed by Eli Collins (Revision 1339906) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1339906 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/conf/hadoop-env.sh
          Hide
          Eli Collins added a comment -

          err, I mean branch-2.

          Show
          Eli Collins added a comment - err, I mean branch-2.
          Hide
          Eli Collins added a comment -

          I've committed this and merged to trunk.

          Show
          Eli Collins added a comment - I've committed this and merged to trunk.
          Hide
          Todd Lipcon added a comment -

          +1

          Show
          Todd Lipcon added a comment - +1
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12527891/hadoop-8287.txt
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 javadoc. The javadoc tool appears to have generated 2 warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1002//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1002//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12527891/hadoop-8287.txt against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 javadoc. The javadoc tool appears to have generated 2 warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1002//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1002//console This message is automatically generated.
          Hide
          Eli Collins added a comment -

          Verified etc/hadoop in the tarball now contains hadoop-env.sh

          Show
          Eli Collins added a comment - Verified etc/hadoop in the tarball now contains hadoop-env.sh
          Hide
          Eli Collins added a comment -

          Patch attached. Adds hadoop-env.sh (from the templates dir) to src/main/conf, these files get copied to etc/hadoop/conf in the dist step. HADOOP-8407 tracks not having the packaging duplicate the conf dir.

          Show
          Eli Collins added a comment - Patch attached. Adds hadoop-env.sh (from the templates dir) to src/main/conf, these files get copied to etc/hadoop/conf in the dist step. HADOOP-8407 tracks not having the packaging duplicate the conf dir.

            People

            • Assignee:
              Eli Collins
              Reporter:
              Eli Collins
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development