Hadoop Common
  1. Hadoop Common
  2. HADOOP-8284

clover integration broken, also mapreduce poms are pulling in clover as a dependency

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      companion to MAPREDUCE-4141 - clover is broken on trunk.

      1. HADOOP-8284.patch
        1 kB
        Patrick Hunt
      2. HADOOP-8284.patch
        2 kB
        Patrick Hunt
      3. HADOOP-8284.patch
        2 kB
        Patrick Hunt

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1059 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1059/)
        HADOOP-8284. clover integration broken, also mapreduce poms are pulling in clover as a dependency. (phunt via tucu) (Revision 1329490)

        Result = FAILURE
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1329490
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-project/pom.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1059 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1059/ ) HADOOP-8284 . clover integration broken, also mapreduce poms are pulling in clover as a dependency. (phunt via tucu) (Revision 1329490) Result = FAILURE tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1329490 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-project/pom.xml
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1024 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1024/)
        HADOOP-8284. clover integration broken, also mapreduce poms are pulling in clover as a dependency. (phunt via tucu) (Revision 1329490)

        Result = FAILURE
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1329490
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-project/pom.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1024 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1024/ ) HADOOP-8284 . clover integration broken, also mapreduce poms are pulling in clover as a dependency. (phunt via tucu) (Revision 1329490) Result = FAILURE tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1329490 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-project/pom.xml
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #2137 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2137/)
        HADOOP-8284. clover integration broken, also mapreduce poms are pulling in clover as a dependency. (phunt via tucu) (Revision 1329490)

        Result = SUCCESS
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1329490
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-project/pom.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2137 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2137/ ) HADOOP-8284 . clover integration broken, also mapreduce poms are pulling in clover as a dependency. (phunt via tucu) (Revision 1329490) Result = SUCCESS tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1329490 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-project/pom.xml
        Hide
        Alejandro Abdelnur added a comment -

        thanks patrick. committed to trunk and branch-2

        Show
        Alejandro Abdelnur added a comment - thanks patrick. committed to trunk and branch-2
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2195 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2195/)
        HADOOP-8284. clover integration broken, also mapreduce poms are pulling in clover as a dependency. (phunt via tucu) (Revision 1329490)

        Result = SUCCESS
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1329490
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-project/pom.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2195 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2195/ ) HADOOP-8284 . clover integration broken, also mapreduce poms are pulling in clover as a dependency. (phunt via tucu) (Revision 1329490) Result = SUCCESS tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1329490 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-project/pom.xml
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2121 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2121/)
        HADOOP-8284. clover integration broken, also mapreduce poms are pulling in clover as a dependency. (phunt via tucu) (Revision 1329490)

        Result = SUCCESS
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1329490
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-project/pom.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2121 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2121/ ) HADOOP-8284 . clover integration broken, also mapreduce poms are pulling in clover as a dependency. (phunt via tucu) (Revision 1329490) Result = SUCCESS tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1329490 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-project/pom.xml
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12523268/HADOOP-8284.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/868//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12523268/HADOOP-8284.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/868//console This message is automatically generated.
        Hide
        Alejandro Abdelnur added a comment -

        +1 lgtm

        Show
        Alejandro Abdelnur added a comment - +1 lgtm
        Hide
        Patrick Hunt added a comment -

        Yes, will do. I had removed it during my original changes, then added it back based on your feedback (just not at the original location, didn't realize).

        Show
        Patrick Hunt added a comment - Yes, will do. I had removed it during my original changes, then added it back based on your feedback (just not at the original location, didn't realize).
        Hide
        Alejandro Abdelnur added a comment -

        @patrick, It seems you patch is removing the def of clover plugin from the pluginManagement section to add it again a few lines down. would you please revert that change?

        Show
        Alejandro Abdelnur added a comment - @patrick, It seems you patch is removing the def of clover plugin from the pluginManagement section to add it again a few lines down. would you please revert that change?
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12523266/HADOOP-8284.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/867//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12523266/HADOOP-8284.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/867//console This message is automatically generated.
        Hide
        Patrick Hunt added a comment -

        Updated with Alejandro's comments.

        Show
        Patrick Hunt added a comment - Updated with Alejandro's comments.
        Hide
        Alejandro Abdelnur added a comment -

        The <pluginManagement> section should define:

                  <plugin>
                    <groupId>com.atlassian.maven.plugins</groupId>
                    <artifactId>maven-clover2-plugin</artifactId>
                    <version>3.0.5</version>
                  </plugin>
        

        And the plugin usage in the clover profile should not have the version specified.

        Other than that seems OK.

        Show
        Alejandro Abdelnur added a comment - The <pluginManagement> section should define: <plugin> <groupId>com.atlassian.maven.plugins</groupId> <artifactId>maven-clover2-plugin</artifactId> <version>3.0.5</version> </plugin> And the plugin usage in the clover profile should not have the version specified. Other than that seems OK.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12522799/HADOOP-8284.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/856//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12522799/HADOOP-8284.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/856//console This message is automatically generated.
        Hide
        Patrick Hunt added a comment -

        need both this patch and MAPREDUCE-4141 to address the issue, please commit both at the same time.

        I've tested this out with a full build and clover test. It was able to generate clover output and view in a browser fine. Fixed the issue with pb changes (itself has code gen phase) by pushing clover into process-sources phase - which makes more sense anyway. I also tested generating the distro and it gen'd that fine as well (w/o including clover jar)

        Show
        Patrick Hunt added a comment - need both this patch and MAPREDUCE-4141 to address the issue, please commit both at the same time. I've tested this out with a full build and clover test. It was able to generate clover output and view in a browser fine. Fixed the issue with pb changes (itself has code gen phase) by pushing clover into process-sources phase - which makes more sense anyway. I also tested generating the distro and it gen'd that fine as well (w/o including clover jar)

          People

          • Assignee:
            Patrick Hunt
            Reporter:
            Patrick Hunt
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development