Hadoop Common
  1. Hadoop Common
  2. HADOOP-8263

Stringification of IPC calls not useful

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-alpha
    • Fix Version/s: 2.0.0-alpha
    • Component/s: ipc
    • Labels:
      None

      Description

      Since the Protobufification of Hadoop, the log messages on IPC exceptions on the server side now read like:

      12/04/09 16:04:06 INFO ipc.Server: IPC Server handler 9 on 8021, call org.apache.hadoop.ipc.ProtobufRpcEngine$RpcRequestWritable@7087e9bf from 127.0.0.1:47989: error: org.apache.hadoop.ipc.StandbyException: Operation category READ is not supported in state standby

      The call should instead stringify the method name and the request protobuf (perhaps abbreviated if it is longer than a few hundred chars)

      1. hadoop-8263.txt
        0.8 kB
        Todd Lipcon

        Activity

        Hide
        Todd Lipcon added a comment -

        Simple patch which just adds a toString method. It turns out it's easy to get the protocol name and method name, but actually getting to the method contents is difficult in this context. I elected to do the simple patch instead of the larger refactoring necessary to get the full parameter printed out.

        Show
        Todd Lipcon added a comment - Simple patch which just adds a toString method. It turns out it's easy to get the protocol name and method name, but actually getting to the method contents is difficult in this context. I elected to do the simple patch instead of the larger refactoring necessary to get the full parameter printed out.
        Hide
        Aaron T. Myers added a comment -

        +1 pending Jenkins.

        Show
        Aaron T. Myers added a comment - +1 pending Jenkins.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12522041/hadoop-8263.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/842//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/842//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12522041/hadoop-8263.txt against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/842//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/842//console This message is automatically generated.
        Hide
        Todd Lipcon added a comment -

        Committed to branch-2 and trunk. Thx.

        Show
        Todd Lipcon added a comment - Committed to branch-2 and trunk. Thx.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2033 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2033/)
        HADOOP-8263. Stringification of IPC calls not useful. Contributed by Todd Lipcon. (Revision 1311543)

        Result = SUCCESS
        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1311543
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2033 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2033/ ) HADOOP-8263 . Stringification of IPC calls not useful. Contributed by Todd Lipcon. (Revision 1311543) Result = SUCCESS todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1311543 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2108 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2108/)
        HADOOP-8263. Stringification of IPC calls not useful. Contributed by Todd Lipcon. (Revision 1311543)

        Result = SUCCESS
        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1311543
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2108 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2108/ ) HADOOP-8263 . Stringification of IPC calls not useful. Contributed by Todd Lipcon. (Revision 1311543) Result = SUCCESS todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1311543 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #2046 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2046/)
        HADOOP-8263. Stringification of IPC calls not useful. Contributed by Todd Lipcon. (Revision 1311543)

        Result = SUCCESS
        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1311543
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2046 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2046/ ) HADOOP-8263 . Stringification of IPC calls not useful. Contributed by Todd Lipcon. (Revision 1311543) Result = SUCCESS todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1311543 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1010 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1010/)
        HADOOP-8263. Stringification of IPC calls not useful. Contributed by Todd Lipcon. (Revision 1311543)

        Result = FAILURE
        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1311543
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1010 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1010/ ) HADOOP-8263 . Stringification of IPC calls not useful. Contributed by Todd Lipcon. (Revision 1311543) Result = FAILURE todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1311543 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1045 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1045/)
        HADOOP-8263. Stringification of IPC calls not useful. Contributed by Todd Lipcon. (Revision 1311543)

        Result = SUCCESS
        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1311543
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1045 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1045/ ) HADOOP-8263 . Stringification of IPC calls not useful. Contributed by Todd Lipcon. (Revision 1311543) Result = SUCCESS todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1311543 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java

          People

          • Assignee:
            Todd Lipcon
            Reporter:
            Todd Lipcon
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development