Hadoop Common
  1. Hadoop Common
  2. HADOOP-8261

Har file system doesn't deal with FS URIs with a host but no port

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-alpha
    • Fix Version/s: 2.0.0-alpha
    • Component/s: fs
    • Labels:
      None

      Description

      If you try to run an MR job with a Hadoop Archive as the input, but the URI you give it has no port specified (e.g. "hdfs://simon") the job will fail with an error like the following:

      java.io.IOException: Incomplete HDFS URI, no host: hdfs://simon:-1/user/atm/input.har/input
      
      1. HADOOP-8261-with-test-in-HDFS.patch
        4 kB
        Aaron T. Myers
      2. HADOOP-8261.patch
        0.9 kB
        Aaron T. Myers
      3. HADOOP-8261.patch
        4 kB
        Aaron T. Myers

        Activity

        Aaron T. Myers created issue -
        Hide
        Aaron T. Myers added a comment -

        Here's a patch which addresses the issue.

        I've written a test for this fix, but the test was easiest written in the HDFS project. I'm going to upload another patch in a moment which is the complete change, but uploading just the fix in Common here so that test-patch can run.

        Show
        Aaron T. Myers added a comment - Here's a patch which addresses the issue. I've written a test for this fix, but the test was easiest written in the HDFS project. I'm going to upload another patch in a moment which is the complete change, but uploading just the fix in Common here so that test-patch can run.
        Aaron T. Myers made changes -
        Field Original Value New Value
        Attachment HADOOP-8261.patch [ 12521806 ]
        Aaron T. Myers made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Aaron T. Myers added a comment -

        Here's the complete patch, including cross-project test in HDFS.

        Show
        Aaron T. Myers added a comment - Here's the complete patch, including cross-project test in HDFS.
        Aaron T. Myers made changes -
        Attachment HADOOP-8261-with-test-in-HDFS.patch [ 12521807 ]
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12521807/HADOOP-8261-with-test-in-HDFS.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/836//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/836//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12521807/HADOOP-8261-with-test-in-HDFS.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/836//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/836//console This message is automatically generated.
        Hide
        Todd Lipcon added a comment -

        Nit: spurious 'a' here at the end of the sentence

        +   * port specified, as is often the case with an HA setup.a
        

        Another nit: I think the test case should be capitalized "WithHA" instead of "WithHa" to match our other test cases which all have the keyword "HA" in them (makes it easy to run mvn test '-Dtest=HA')

        +1 once you fix these

        Show
        Todd Lipcon added a comment - Nit: spurious 'a' here at the end of the sentence + * port specified, as is often the case with an HA setup.a Another nit: I think the test case should be capitalized "WithHA" instead of "WithHa" to match our other test cases which all have the keyword "HA" in them (makes it easy to run mvn test '-Dtest= HA ') +1 once you fix these
        Hide
        Aaron T. Myers added a comment -

        Thanks a lot for the review, Todd. Here's an updated patch which addresses your feedback. I'm going to commit this momentarily.

        Show
        Aaron T. Myers added a comment - Thanks a lot for the review, Todd. Here's an updated patch which addresses your feedback. I'm going to commit this momentarily.
        Aaron T. Myers made changes -
        Attachment HADOOP-8261.patch [ 12521910 ]
        Hide
        Aaron T. Myers added a comment -

        I've just committed this to trunk and branch-2. Thanks again for the review, Todd.

        Show
        Aaron T. Myers added a comment - I've just committed this to trunk and branch-2. Thanks again for the review, Todd.
        Aaron T. Myers made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Fix Version/s 2.0.0 [ 12320352 ]
        Resolution Fixed [ 1 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12521910/HADOOP-8261.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.fs.viewfs.TestViewFsTrash

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/839//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/839//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12521910/HADOOP-8261.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.fs.viewfs.TestViewFsTrash +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/839//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/839//console This message is automatically generated.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2103 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2103/)
        HADOOP-8261. Har file system doesn't deal with FS URIs with a host but no port. Contributed by Aaron T. Myers. (Revision 1311133)

        Result = SUCCESS
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1311133
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/HarFileSystem.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestHarFileSystemWithHA.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2103 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2103/ ) HADOOP-8261 . Har file system doesn't deal with FS URIs with a host but no port. Contributed by Aaron T. Myers. (Revision 1311133) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1311133 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/HarFileSystem.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestHarFileSystemWithHA.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2028 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2028/)
        HADOOP-8261. Har file system doesn't deal with FS URIs with a host but no port. Contributed by Aaron T. Myers. (Revision 1311133)

        Result = SUCCESS
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1311133
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/HarFileSystem.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestHarFileSystemWithHA.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2028 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2028/ ) HADOOP-8261 . Har file system doesn't deal with FS URIs with a host but no port. Contributed by Aaron T. Myers. (Revision 1311133) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1311133 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/HarFileSystem.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestHarFileSystemWithHA.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #2039 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2039/)
        HADOOP-8261. Har file system doesn't deal with FS URIs with a host but no port. Contributed by Aaron T. Myers. (Revision 1311133)

        Result = SUCCESS
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1311133
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/HarFileSystem.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestHarFileSystemWithHA.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2039 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2039/ ) HADOOP-8261 . Har file system doesn't deal with FS URIs with a host but no port. Contributed by Aaron T. Myers. (Revision 1311133) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1311133 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/HarFileSystem.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestHarFileSystemWithHA.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1009 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1009/)
        HADOOP-8261. Har file system doesn't deal with FS URIs with a host but no port. Contributed by Aaron T. Myers. (Revision 1311133)

        Result = FAILURE
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1311133
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/HarFileSystem.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestHarFileSystemWithHA.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1009 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1009/ ) HADOOP-8261 . Har file system doesn't deal with FS URIs with a host but no port. Contributed by Aaron T. Myers. (Revision 1311133) Result = FAILURE atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1311133 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/HarFileSystem.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestHarFileSystemWithHA.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1044 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1044/)
        HADOOP-8261. Har file system doesn't deal with FS URIs with a host but no port. Contributed by Aaron T. Myers. (Revision 1311133)

        Result = SUCCESS
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1311133
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/HarFileSystem.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestHarFileSystemWithHA.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1044 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1044/ ) HADOOP-8261 . Har file system doesn't deal with FS URIs with a host but no port. Contributed by Aaron T. Myers. (Revision 1311133) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1311133 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/HarFileSystem.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestHarFileSystemWithHA.java
        Arun C Murthy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        5h 58m 1 Aaron T. Myers 07/Apr/12 07:15
        Patch Available Patch Available Resolved Resolved
        1d 23h 47m 1 Aaron T. Myers 09/Apr/12 07:03
        Resolved Resolved Closed Closed
        44d 14h 12m 1 Arun C Murthy 23/May/12 21:16

          People

          • Assignee:
            Aaron T. Myers
            Reporter:
            Aaron T. Myers
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development