Hadoop Common
  1. Hadoop Common
  2. HADOOP-8260

Auto-HA: Replace ClientBaseWithFixes with our own modified copy of the class

    Details

      Description

      The class ClientBaseWithFixes is an attempt to add some workaround code to avoid spurious failures due to ZOOKEEPER-1438. But, even after making those workarounds, I've seen a few Jenkins failures due to that issue. Until ZK fixes this issue, I'd like to just copy the test infrastructure into our own code, and remove the problematic JMXEnv verifications.

      1. hadoop-8260.txt
        16 kB
        Todd Lipcon

        Activity

        Hide
        Todd Lipcon added a comment -

        Committed to branch. I ran all of the tests which inherit from this class before committing.

        Show
        Todd Lipcon added a comment - Committed to branch. I ran all of the tests which inherit from this class before committing.
        Hide
        Eli Collins added a comment -

        Agree this makes sense. +1 patch looks good

        Show
        Eli Collins added a comment - Agree this makes sense. +1 patch looks good
        Hide
        Todd Lipcon added a comment -

        Simple patch. This copy-pastes the class from the ZK 3.4.2 (the one we're depending on). I also removed some of the utility functions that we're not making use of, to minimize the amount of copy-paste.

        It's a shame we have to do this, but seems prudent since it may take some time to figure out the underlying ZK bug, and it's only a test issue rather than part of the actual code.

        Show
        Todd Lipcon added a comment - Simple patch. This copy-pastes the class from the ZK 3.4.2 (the one we're depending on). I also removed some of the utility functions that we're not making use of, to minimize the amount of copy-paste. It's a shame we have to do this, but seems prudent since it may take some time to figure out the underlying ZK bug, and it's only a test issue rather than part of the actual code.

          People

          • Assignee:
            Todd Lipcon
            Reporter:
            Todd Lipcon
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development