Hadoop Common
  1. Hadoop Common
  2. HADOOP-8244

Improve comments on ByteBufferReadable.read

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.2-alpha
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      There are a couple of ways in which the comment on ByteBufferReadable.read can be improved. Since this is a public-facing API with potentially many implementations, it's worth taking the time to get it right.

      • We should describe what can become of the byte buffer state in the case of an exception (is the limit changed? where's the position?). For the DFSInputStream implementation, position and limit are unchanged if there is an error, but I don't think that's the right think to mandate for all implementations.
      • We should mention explicitly that 0-byte reads are legitimate - this is particularly important in light of HDFS-3110 which detects support for direct reads by issuing a 0-byte read from libhdfs.
      1. HADOOP-8244.1.patch
        2 kB
        Henry Robinson
      2. HADOOP-8244.0.patch
        2 kB
        Henry Robinson

        Activity

        Henry Robinson created issue -
        Henry Robinson made changes -
        Field Original Value New Value
        Attachment HADOOP-8244.0.patch [ 12521203 ]
        Henry Robinson made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Henry Robinson made changes -
        Attachment HADOOP-8244.1.patch [ 12521416 ]
        Aaron T. Myers made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Target Version/s 0.24.0 [ 12317652 ]
        Fix Version/s 0.24.0 [ 12317652 ]
        Resolution Fixed [ 1 ]
        Todd Lipcon made changes -
        Target Version/s 0.24.0 [ 12317652 ] 2.0.1-alpha [ 12321441 ]
        Todd Lipcon made changes -
        Fix Version/s 2.0.1-alpha [ 12321441 ]
        Fix Version/s 0.24.0 [ 12317652 ]
        Arun C Murthy made changes -
        Fix Version/s 2.0.2-alpha [ 12322473 ]
        Fix Version/s 2.1.0-alpha [ 12321441 ]
        Arun C Murthy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Henry Robinson
            Reporter:
            Henry Robinson
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development