Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: native
    • Labels:
      None
    • Target Version/s:
    1. hadoop-8223.patch
      71 kB
      Sanjay Radia
    2. hadoop-8223-2.patch
      71 kB
      Sanjay Radia

      Activity

      Hide
      Sanjay Radia added a comment -

      A slightly cleaned up version of David's patch from Hadoop-8079

      Show
      Sanjay Radia added a comment - A slightly cleaned up version of David's patch from Hadoop-8079
      Hide
      Doug Cutting added a comment -

      Duplicating all of the command line logic will make things harder to maintain.

      I wonder if it's time to revisit an approach like that of HADOOP-61, to move as much of the command line logic as possible out of shell scripts and into Java?

      Show
      Doug Cutting added a comment - Duplicating all of the command line logic will make things harder to maintain. I wonder if it's time to revisit an approach like that of HADOOP-61 , to move as much of the command line logic as possible out of shell scripts and into Java?
      Hide
      Sanjay Radia added a comment -

      Doug, in several cases at the end you have to execute a shell command on windows or unix (or native code) because the operation is not implementable in pure java. Do you mean more like the approach of DU.java (to get disk usage)? With Du.java the the mainline code just calls Du.java but Du.java calls the unix shell or the windows cmd.

      Show
      Sanjay Radia added a comment - Doug, in several cases at the end you have to execute a shell command on windows or unix (or native code) because the operation is not implementable in pure java. Do you mean more like the approach of DU.java (to get disk usage)? With Du.java the the mainline code just calls Du.java but Du.java calls the unix shell or the windows cmd.
      Hide
      Sanjay Radia added a comment -

      Change Variable name from DISABLEWINDOWS to DISABLEWINDOWS_TEMPORARILY - this should be more obvious to readers

      Show
      Sanjay Radia added a comment - Change Variable name from DISABLEWINDOWS to DISABLEWINDOWS_TEMPORARILY - this should be more obvious to readers
      Hide
      Doug Cutting added a comment -

      Sanjay, yes, in some cases we do need OS-specific code. But we should minimize it and avoid duplication of logic when possible. This patch duplicates a lot of logic in the startup scripts that might instead be moved from scripts into Java.

      Show
      Doug Cutting added a comment - Sanjay, yes, in some cases we do need OS-specific code. But we should minimize it and avoid duplication of logic when possible. This patch duplicates a lot of logic in the startup scripts that might instead be moved from scripts into Java.
      Hide
      Sanjay Radia added a comment -

      The plan (as mentioned in HADOOP-8079) is to commit to branch and over time clean up the work based on feedback and reviews.
      Doug I would like to move your comment/discussion to the main Jira (Hadoop-8079) so that it does not get lost when we I close this jira after committing the patch.

      Show
      Sanjay Radia added a comment - The plan (as mentioned in HADOOP-8079 ) is to commit to branch and over time clean up the work based on feedback and reviews. Doug I would like to move your comment/discussion to the main Jira (Hadoop-8079) so that it does not get lost when we I close this jira after committing the patch.
      Hide
      Alexander Stojanovic added a comment -

      @Doug Your points are valid ones. We have been thinking about a holistic approach to this that works in a cross-platform manner. Windows (sans Cygwin) has Powershell and Windows Command Shell as scripting/automation environments. I would love to see a discussion as Sanjay points out on the main Jira (Hadoop-8079) around this. We are totally open to how we might as a community refactor the work between pure Java and native platform scripting environments.

      Show
      Alexander Stojanovic added a comment - @Doug Your points are valid ones. We have been thinking about a holistic approach to this that works in a cross-platform manner. Windows (sans Cygwin) has Powershell and Windows Command Shell as scripting/automation environments. I would love to see a discussion as Sanjay points out on the main Jira (Hadoop-8079) around this. We are totally open to how we might as a community refactor the work between pure Java and native platform scripting environments.

        People

        • Assignee:
          Unassigned
          Reporter:
          Sanjay Radia
        • Votes:
          0 Vote for this issue
          Watchers:
          8 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development