Hadoop Common
  1. Hadoop Common
  2. HADOOP-8216

address log4j.properties inconsistencies btw main and template dirs

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: None
    • Component/s: conf
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Target Version/s:

      Description

      DRFAAUDIT is in ./hadoop-common-project/hadoop-common/src/main/packages/templates/conf/log4j.properties but not in ./hadoop-common-project/hadoop-common/src/main/conf/log4j.properties (although it's used in hadoop-env.sh)

      lesser issues but I noticed:

      I see MRAUDIT commented out of main, but it's uncommented in template. (the conversion pattern also differs).

      afaict the other appenders (JSA, MRAUDIT, TLA, etc...) are all still being used and should not be removed.

      Should we be renaming some of these? JSA is being used by the history server for example.

        Issue Links

          Activity

          Hide
          Eli Collins added a comment -

          I think we should just use the values from templates/conf/log4j.properties in main/conf/log4j.properties, the former look the most up2date, and they're mostly the same (ie just different order in some places, and removing things that are commented out).

          Show
          Eli Collins added a comment - I think we should just use the values from templates/conf/log4j.properties in main/conf/log4j.properties, the former look the most up2date, and they're mostly the same (ie just different order in some places, and removing things that are commented out).
          Hide
          Patrick Hunt added a comment -

          I checked over the template and it seemed a superset of main, so I've gone ahead and done as Eli suggested. I was able to start a cluster w/o issues and run a basic jobs. The generated logs looked fine to me.

          Show
          Patrick Hunt added a comment - I checked over the template and it seemed a superset of main, so I've gone ahead and done as Eli suggested. I was able to start a cluster w/o issues and run a basic jobs. The generated logs looked fine to me.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12520037/HADOOP-8216.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.fs.viewfs.TestViewFsTrash

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/787//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/787//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12520037/HADOOP-8216.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.fs.viewfs.TestViewFsTrash +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/787//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/787//console This message is automatically generated.
          Hide
          Eli Collins added a comment -

          +1 looks good

          Show
          Eli Collins added a comment - +1 looks good
          Hide
          Eli Collins added a comment -

          Forgot to mention, the test failure is unrelated. I've committed and merged to branch-23. Thanks Pat!

          Show
          Eli Collins added a comment - Forgot to mention, the test failure is unrelated. I've committed and merged to branch-23. Thanks Pat!
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #2011 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2011/)
          HADOOP-8216. Address log4j.properties inconsistencies btw main and template dirs. Contributed by Patrick Hunt (Revision 1305891)

          Result = SUCCESS
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1305891
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/conf/log4j.properties
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2011 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2011/ ) HADOOP-8216 . Address log4j.properties inconsistencies btw main and template dirs. Contributed by Patrick Hunt (Revision 1305891) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1305891 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/conf/log4j.properties
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-0.23-Commit #724 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/724/)
          HADOOP-8216. svn merge -c 1305891 from trunk (Revision 1305892)

          Result = SUCCESS
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1305892
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-common-project
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/conf/log4j.properties
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Commit #724 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/724/ ) HADOOP-8216 . svn merge -c 1305891 from trunk (Revision 1305892) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1305892 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/conf/log4j.properties /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-0.23-Commit #734 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/734/)
          HADOOP-8216. svn merge -c 1305891 from trunk (Revision 1305892)

          Result = SUCCESS
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1305892
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-common-project
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/conf/log4j.properties
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core
          Show
          Hudson added a comment - Integrated in Hadoop-Common-0.23-Commit #734 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/734/ ) HADOOP-8216 . svn merge -c 1305891 from trunk (Revision 1305892) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1305892 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/conf/log4j.properties /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #1936 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1936/)
          HADOOP-8216. Address log4j.properties inconsistencies btw main and template dirs. Contributed by Patrick Hunt (Revision 1305891)

          Result = SUCCESS
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1305891
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/conf/log4j.properties
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1936 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1936/ ) HADOOP-8216 . Address log4j.properties inconsistencies btw main and template dirs. Contributed by Patrick Hunt (Revision 1305891) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1305891 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/conf/log4j.properties
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-0.23-Commit #744 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/744/)
          HADOOP-8216. svn merge -c 1305891 from trunk (Revision 1305892)

          Result = ABORTED
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1305892
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-common-project
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/conf/log4j.properties
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Commit #744 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/744/ ) HADOOP-8216 . svn merge -c 1305891 from trunk (Revision 1305892) Result = ABORTED eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1305892 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/conf/log4j.properties /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #1949 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1949/)
          HADOOP-8216. Address log4j.properties inconsistencies btw main and template dirs. Contributed by Patrick Hunt (Revision 1305891)

          Result = ABORTED
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1305891
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/conf/log4j.properties
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1949 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1949/ ) HADOOP-8216 . Address log4j.properties inconsistencies btw main and template dirs. Contributed by Patrick Hunt (Revision 1305891) Result = ABORTED eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1305891 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/conf/log4j.properties
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #998 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/998/)
          HADOOP-8216. Address log4j.properties inconsistencies btw main and template dirs. Contributed by Patrick Hunt (Revision 1305891)

          Result = FAILURE
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1305891
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/conf/log4j.properties
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #998 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/998/ ) HADOOP-8216 . Address log4j.properties inconsistencies btw main and template dirs. Contributed by Patrick Hunt (Revision 1305891) Result = FAILURE eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1305891 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/conf/log4j.properties
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1033 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1033/)
          HADOOP-8216. Address log4j.properties inconsistencies btw main and template dirs. Contributed by Patrick Hunt (Revision 1305891)

          Result = FAILURE
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1305891
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/conf/log4j.properties
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1033 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1033/ ) HADOOP-8216 . Address log4j.properties inconsistencies btw main and template dirs. Contributed by Patrick Hunt (Revision 1305891) Result = FAILURE eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1305891 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/conf/log4j.properties

            People

            • Assignee:
              Patrick Hunt
              Reporter:
              Patrick Hunt
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development