Hadoop Common
  1. Hadoop Common
  2. HADOOP-8214

make hadoop script recognize a full set of deprecated commands

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.1
    • Fix Version/s: 2.0.0-alpha, 0.23.7
    • Component/s: scripts
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      bin/hadoop launcher script does a nice job of recognizing deprecated usage and vectoring users towards the proper command line tools (hdfs, mapred). It would be nice if we can take care of the following deprecated commands that don't get the same special treatment:

        oiv                  apply the offline fsimage viewer to an fsimage
        dfsgroups            get the groups which users belong to on the Name Node
        mrgroups             get the groups which users belong to on the Job Tracker
        mradmin              run a Map-Reduce admin client
        jobtracker           run the MapReduce job Tracker node
        tasktracker          run a MapReduce task Tracker node
      

      Here's what I propos to do with them:

      1. oiv – issue DEPRECATED warning and run hdfs oiv
      2. dfsgroups – issue DEPRECATED warning and run hdfs groups
      3. mrgroups – issue DEPRECATED warning and run mapred groups
      4. mradmin – issue DEPRECATED warning and run yarn rmadmin
      5. jobtracker – issue DEPRECATED warning and do nothing
      6. tasktracker-- issue DEPRECATED warning and do nothing

      Thoughts?

      1. HADOOP-8214.patch.txt
        2 kB
        Roman Shaposhnik

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #513 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/513/)
        HADOOP-8214. make hadoop script recognize a full set of deprecated commands(rvs via tgraves) (Revision 1441502)

        Result = SUCCESS
        tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1441502
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/bin/hadoop
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #513 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/513/ ) HADOOP-8214 . make hadoop script recognize a full set of deprecated commands(rvs via tgraves) (Revision 1441502) Result = SUCCESS tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1441502 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/bin/hadoop
        Thomas Graves made changes -
        Fix Version/s 0.23.7 [ 12323956 ]
        Arun C Murthy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1068 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1068/)
        HADOOP-8214. make hadoop script recognize a full set of deprecated commands (rvs via tucu) (Revision 1333231)

        Result = FAILURE
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1333231
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/bin/hadoop
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1068 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1068/ ) HADOOP-8214 . make hadoop script recognize a full set of deprecated commands (rvs via tucu) (Revision 1333231) Result = FAILURE tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1333231 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/bin/hadoop
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1033 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1033/)
        HADOOP-8214. make hadoop script recognize a full set of deprecated commands (rvs via tucu) (Revision 1333231)

        Result = FAILURE
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1333231
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/bin/hadoop
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1033 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1033/ ) HADOOP-8214 . make hadoop script recognize a full set of deprecated commands (rvs via tucu) (Revision 1333231) Result = FAILURE tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1333231 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/bin/hadoop
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #2192 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2192/)
        HADOOP-8214. make hadoop script recognize a full set of deprecated commands (rvs via tucu) (Revision 1333231)

        Result = ABORTED
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1333231
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/bin/hadoop
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2192 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2192/ ) HADOOP-8214 . make hadoop script recognize a full set of deprecated commands (rvs via tucu) (Revision 1333231) Result = ABORTED tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1333231 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/bin/hadoop
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2175 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2175/)
        HADOOP-8214. make hadoop script recognize a full set of deprecated commands (rvs via tucu) (Revision 1333231)

        Result = SUCCESS
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1333231
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/bin/hadoop
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2175 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2175/ ) HADOOP-8214 . make hadoop script recognize a full set of deprecated commands (rvs via tucu) (Revision 1333231) Result = SUCCESS tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1333231 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/bin/hadoop
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2249 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2249/)
        HADOOP-8214. make hadoop script recognize a full set of deprecated commands (rvs via tucu) (Revision 1333231)

        Result = SUCCESS
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1333231
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/bin/hadoop
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2249 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2249/ ) HADOOP-8214 . make hadoop script recognize a full set of deprecated commands (rvs via tucu) (Revision 1333231) Result = SUCCESS tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1333231 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/bin/hadoop
        Alejandro Abdelnur made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Fix Version/s 2.0.0 [ 12320352 ]
        Fix Version/s 0.23.2 [ 12319855 ]
        Resolution Fixed [ 1 ]
        Hide
        Alejandro Abdelnur added a comment -

        thanks Roman. committed to trunk and branch-2

        Show
        Alejandro Abdelnur added a comment - thanks Roman. committed to trunk and branch-2
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12525332/HADOOP-8214.patch.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 javadoc. The javadoc tool appears to have generated 2 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/921//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/921//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12525332/HADOOP-8214.patch.txt against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javadoc. The javadoc tool appears to have generated 2 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/921//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/921//console This message is automatically generated.
        Hide
        Alejandro Abdelnur added a comment -

        +1

        Show
        Alejandro Abdelnur added a comment - +1
        Roman Shaposhnik made changes -
        Attachment HADOOP-8214.patch.txt [ 12525332 ]
        Roman Shaposhnik made changes -
        Attachment HADOOP-8214.patch.txt [ 12525330 ]
        Roman Shaposhnik made changes -
        Attachment HADOOP-8214.patch.txt [ 12525330 ]
        Roman Shaposhnik made changes -
        Attachment HADOOP-8214.patch.txt [ 12525329 ]
        Roman Shaposhnik made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Roman Shaposhnik made changes -
        Field Original Value New Value
        Attachment HADOOP-8214.patch.txt [ 12525329 ]
        Roman Shaposhnik created issue -

          People

          • Assignee:
            Roman Shaposhnik
            Reporter:
            Roman Shaposhnik
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development