Hadoop Common
  1. Hadoop Common
  2. HADOOP-8197

Configuration logs WARNs on every use of a deprecated key

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 0.23.3, 0.24.0
    • Fix Version/s: 0.23.3, 2.0.2-alpha
    • Component/s: conf
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The logic to do print a warning only once per deprecated key does not work:

      2012-03-21 22:32:58,121  WARN Configuration:661 - user.name is deprecated. Instead, use mapreduce.job.user.name
      ....
      2012-03-21 22:32:58,123  WARN Configuration:661 - fs.default.name is deprecated. Instead, use fs.defaultFS
      ...
      2012-03-21 22:32:58,130  WARN Configuration:661 - mapred.job.tracker is deprecated. Instead, use mapreduce.jobtracker.address
      2012-03-21 22:32:58,351  WARN Configuration:345 - fs.default.name is deprecated. Instead, use fs.defaultFS
      ...
      2012-03-21 22:32:58,843  WARN Configuration:661 - user.name is deprecated. Instead, use mapreduce.job.user.name
      2012-03-21 22:32:58,844  WARN Configuration:661 - mapred.job.tracker is deprecated. Instead, use mapreduce.jobtracker.address
      2012-03-21 22:32:58,844  WARN Configuration:661 - fs.default.name is deprecated. Instead, use fs.defaultFS
      
      1. HADOOP-8197.patch
        3 kB
        Alejandro Abdelnur
      2. HADOOP-8197.patch
        3 kB
        Alejandro Abdelnur

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #330 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/330/)
        svn merge -c 1301551,1300642,1332821,1303884 FIXES:MAPREDUCE-4010,HADOOP-8167,HADOOP-8172,HADOOP-8197 Patches to fix OOZIE-761 (Revision 1367102)

        Result = SUCCESS
        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1367102
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfigurationDeprecation.java
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestDeprecatedKeys.java
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestWritableJobConf.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #330 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/330/ ) svn merge -c 1301551,1300642,1332821,1303884 FIXES: MAPREDUCE-4010 , HADOOP-8167 , HADOOP-8172 , HADOOP-8197 Patches to fix OOZIE-761 (Revision 1367102) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1367102 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfigurationDeprecation.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestDeprecatedKeys.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestWritableJobConf.java
        Hide
        Robert Joseph Evans added a comment -

        Pulled this into branch-0.23

        Show
        Robert Joseph Evans added a comment - Pulled this into branch-0.23
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1028 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1028/)
        HADOOP-8197. Configuration logs WARNs on every use of a deprecated key (tucu) (Revision 1303884)

        Result = SUCCESS
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1303884
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestDeprecatedKeys.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1028 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1028/ ) HADOOP-8197 . Configuration logs WARNs on every use of a deprecated key (tucu) (Revision 1303884) Result = SUCCESS tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1303884 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestDeprecatedKeys.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Build #234 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/234/)
        Merge -r 1303883:1303884 from trunk to branch. FIXES: HADOOP-8197 (Revision 1303886)

        Result = FAILURE
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1303886
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestDeprecatedKeys.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Build #234 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/234/ ) Merge -r 1303883:1303884 from trunk to branch. FIXES: HADOOP-8197 (Revision 1303886) Result = FAILURE tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1303886 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestDeprecatedKeys.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #206 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/206/)
        Merge -r 1303883:1303884 from trunk to branch. FIXES: HADOOP-8197 (Revision 1303886)

        Result = SUCCESS
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1303886
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestDeprecatedKeys.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #206 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/206/ ) Merge -r 1303883:1303884 from trunk to branch. FIXES: HADOOP-8197 (Revision 1303886) Result = SUCCESS tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1303886 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestDeprecatedKeys.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #993 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/993/)
        HADOOP-8197. Configuration logs WARNs on every use of a deprecated key (tucu) (Revision 1303884)

        Result = FAILURE
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1303884
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestDeprecatedKeys.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #993 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/993/ ) HADOOP-8197 . Configuration logs WARNs on every use of a deprecated key (tucu) (Revision 1303884) Result = FAILURE tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1303884 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestDeprecatedKeys.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Commit #722 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/722/)
        Merge -r 1303883:1303884 from trunk to branch. FIXES: HADOOP-8197 (Revision 1303886)

        Result = ABORTED
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1303886
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestDeprecatedKeys.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Commit #722 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/722/ ) Merge -r 1303883:1303884 from trunk to branch. FIXES: HADOOP-8197 (Revision 1303886) Result = ABORTED tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1303886 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestDeprecatedKeys.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #1924 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1924/)
        HADOOP-8197. Configuration logs WARNs on every use of a deprecated key (tucu) (Revision 1303884)

        Result = ABORTED
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1303884
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestDeprecatedKeys.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1924 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1924/ ) HADOOP-8197 . Configuration logs WARNs on every use of a deprecated key (tucu) (Revision 1303884) Result = ABORTED tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1303884 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestDeprecatedKeys.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Commit #705 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/705/)
        Merge -r 1303883:1303884 from trunk to branch. FIXES: HADOOP-8197 (Revision 1303886)

        Result = SUCCESS
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1303886
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestDeprecatedKeys.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Commit #705 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/705/ ) Merge -r 1303883:1303884 from trunk to branch. FIXES: HADOOP-8197 (Revision 1303886) Result = SUCCESS tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1303886 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestDeprecatedKeys.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-0.23-Commit #714 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/714/)
        Merge -r 1303883:1303884 from trunk to branch. FIXES: HADOOP-8197 (Revision 1303886)

        Result = SUCCESS
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1303886
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestDeprecatedKeys.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-0.23-Commit #714 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/714/ ) Merge -r 1303883:1303884 from trunk to branch. FIXES: HADOOP-8197 (Revision 1303886) Result = SUCCESS tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1303886 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestDeprecatedKeys.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #1915 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1915/)
        HADOOP-8197. Configuration logs WARNs on every use of a deprecated key (tucu) (Revision 1303884)

        Result = SUCCESS
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1303884
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestDeprecatedKeys.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1915 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1915/ ) HADOOP-8197 . Configuration logs WARNs on every use of a deprecated key (tucu) (Revision 1303884) Result = SUCCESS tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1303884 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestDeprecatedKeys.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #1989 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1989/)
        HADOOP-8197. Configuration logs WARNs on every use of a deprecated key (tucu) (Revision 1303884)

        Result = SUCCESS
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1303884
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestDeprecatedKeys.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1989 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1989/ ) HADOOP-8197 . Configuration logs WARNs on every use of a deprecated key (tucu) (Revision 1303884) Result = SUCCESS tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1303884 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestDeprecatedKeys.java
        Hide
        Alejandro Abdelnur added a comment -

        Committed to trunk and branch-0.23

        Show
        Alejandro Abdelnur added a comment - Committed to trunk and branch-0.23
        Hide
        Alejandro Abdelnur added a comment -

        same patch renaming method per Harsh's suggestion

        Show
        Alejandro Abdelnur added a comment - same patch renaming method per Harsh's suggestion
        Hide
        Harsh J added a comment -

        +1, patch looks good.

        One optional nitpick though: Would warnOnceIfDeprecated be a better method name?

        Show
        Harsh J added a comment - +1, patch looks good. One optional nitpick though: Would warnOnceIfDeprecated be a better method name?
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12519449/HADOOP-8197.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/744//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/744//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12519449/HADOOP-8197.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/744//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/744//console This message is automatically generated.
        Hide
        Alejandro Abdelnur added a comment -

        verified visually that log WARNs are written once

        Show
        Alejandro Abdelnur added a comment - verified visually that log WARNs are written once

          People

          • Assignee:
            Alejandro Abdelnur
            Reporter:
            Alejandro Abdelnur
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development