Hadoop Common
  1. Hadoop Common
  2. HADOOP-8189

LdapGroupsMapping shouldn't throw away IOException

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.3
    • Fix Version/s: 2.0.0-alpha
    • Component/s: security
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      When extracting a password from a file during the config setup, the LdapGroupsMapping throws a RuntimeException, but doesn't bubble up the IOException that caused it

      1. HADOOP-8189.patch
        0.8 kB
        Jonathan Natkins
      2. HADOOP-8189.patch
        0.8 kB
        Jonathan Natkins

        Activity

        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12518997/HADOOP-8189.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.fs.viewfs.TestViewFsTrash

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/733//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/733//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12518997/HADOOP-8189.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.fs.viewfs.TestViewFsTrash +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/733//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/733//console This message is automatically generated.
        Hide
        Aaron T. Myers added a comment -

        Patch looks good to me. One tiny nit:

        1. Please rename the exception variable to "ioe", as is standard in the Hadoop code.

        +1 once this is addressed and Jenkins comes back clean.

        Show
        Aaron T. Myers added a comment - Patch looks good to me. One tiny nit: Please rename the exception variable to "ioe", as is standard in the Hadoop code. +1 once this is addressed and Jenkins comes back clean.
        Hide
        Jonathan Natkins added a comment -

        Attaching patch that renames exception variable to ioe

        Show
        Jonathan Natkins added a comment - Attaching patch that renames exception variable to ioe
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12519003/HADOOP-8189.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/734//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/734//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12519003/HADOOP-8189.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/734//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/734//console This message is automatically generated.
        Hide
        Aaron T. Myers added a comment -

        I've just committed this to trunk and branch-0.23. Thanks a lot, Natty.

        Show
        Aaron T. Myers added a comment - I've just committed this to trunk and branch-0.23. Thanks a lot, Natty.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Build #231 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/231/)
        HADOOP-8189. LdapGroupsMapping shouldn't throw away IOException. Contributed by Jonathan Natkins. (Revision 1302784)

        Result = FAILURE
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1302784
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/LdapGroupsMapping.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Build #231 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/231/ ) HADOOP-8189 . LdapGroupsMapping shouldn't throw away IOException. Contributed by Jonathan Natkins. (Revision 1302784) Result = FAILURE atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1302784 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/LdapGroupsMapping.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-0.23-Commit #708 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/708/)
        HADOOP-8189. LdapGroupsMapping shouldn't throw away IOException. Contributed by Jonathan Natkins. (Revision 1302784)

        Result = SUCCESS
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1302784
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/LdapGroupsMapping.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-0.23-Commit #708 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/708/ ) HADOOP-8189 . LdapGroupsMapping shouldn't throw away IOException. Contributed by Jonathan Natkins. (Revision 1302784) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1302784 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/LdapGroupsMapping.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #1907 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1907/)
        HADOOP-8189. LdapGroupsMapping shouldn't throw away IOException. Contributed by Jonathan Natkins. (Revision 1302783)

        Result = SUCCESS
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1302783
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/LdapGroupsMapping.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1907 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1907/ ) HADOOP-8189 . LdapGroupsMapping shouldn't throw away IOException. Contributed by Jonathan Natkins. (Revision 1302783) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1302783 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/LdapGroupsMapping.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Commit #699 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/699/)
        HADOOP-8189. LdapGroupsMapping shouldn't throw away IOException. Contributed by Jonathan Natkins. (Revision 1302784)

        Result = SUCCESS
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1302784
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/LdapGroupsMapping.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Commit #699 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/699/ ) HADOOP-8189 . LdapGroupsMapping shouldn't throw away IOException. Contributed by Jonathan Natkins. (Revision 1302784) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1302784 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/LdapGroupsMapping.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #1981 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1981/)
        HADOOP-8189. LdapGroupsMapping shouldn't throw away IOException. Contributed by Jonathan Natkins. (Revision 1302783)

        Result = SUCCESS
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1302783
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/LdapGroupsMapping.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1981 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1981/ ) HADOOP-8189 . LdapGroupsMapping shouldn't throw away IOException. Contributed by Jonathan Natkins. (Revision 1302783) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1302783 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/LdapGroupsMapping.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1025 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1025/)
        HADOOP-8189. LdapGroupsMapping shouldn't throw away IOException. Contributed by Jonathan Natkins. (Revision 1302783)

        Result = SUCCESS
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1302783
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/LdapGroupsMapping.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1025 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1025/ ) HADOOP-8189 . LdapGroupsMapping shouldn't throw away IOException. Contributed by Jonathan Natkins. (Revision 1302783) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1302783 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/LdapGroupsMapping.java

          People

          • Assignee:
            Jonathan Natkins
            Reporter:
            Jonathan Natkins
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development