Hadoop Common
  1. Hadoop Common
  2. HADOOP-8185

Update namenode -format documentation and add -nonInteractive and -force

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-alpha
    • Fix Version/s: 2.0.0-alpha
    • Component/s: documentation
    • Labels:
      None

      Description

      documentation changes related to HDFS-3094

      1. HADOOP-8185.patch
        2 kB
        Arpit Gupta
      2. HADOOP-8185.patch
        2 kB
        Arpit Gupta
      3. HADOOP-8185.patch
        2 kB
        Arpit Gupta
      4. HADOOP-8185.patch
        2 kB
        Arpit Gupta

        Issue Links

          Activity

          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12518950/HADOOP-8185.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.fs.viewfs.TestViewFsTrash

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/730//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/730//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12518950/HADOOP-8185.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.fs.viewfs.TestViewFsTrash +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/730//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/730//console This message is automatically generated.
          Hide
          Arpit Gupta added a comment -

          no tests included as this is just a documentation patch.

          The test failure is un related to this patch.

          Show
          Arpit Gupta added a comment - no tests included as this is just a documentation patch. The test failure is un related to this patch.
          Hide
          Aaron T. Myers added a comment -

          Looks pretty good to me, Arpit. Thanks for doing this. A few little typo corrections:

          1. "<td>Formats the namenode. It starts the namenode, formats it and then shut it down.<br/>" - s/shut/shuts/g
          2. "-nonInterActive: formats the namenode but will fail if directories exist on local filesyste.<br/>" - s/filesyste/filesystem/g
          Show
          Aaron T. Myers added a comment - Looks pretty good to me, Arpit. Thanks for doing this. A few little typo corrections: "<td>Formats the namenode. It starts the namenode, formats it and then shut it down.<br/>" - s/shut/shuts/g "-nonInterActive: formats the namenode but will fail if directories exist on local filesyste.<br/>" - s/filesyste/filesystem/g
          Hide
          Arpit Gupta added a comment -

          Thanks for the review Aaron. Made the appropriate changes.

          Show
          Arpit Gupta added a comment - Thanks for the review Aaron. Made the appropriate changes.
          Hide
          Aaron T. Myers added a comment -

          Sorry Arpit, I should have mentioned these earlier. Other changes that I'd like to see:

          1. I think you have a typo in the "-nonInteractive" option. "Interactive" is one word, and the "a" should not be capitalized.
          2. It's not obvious from the description of "-nonInteractive" how it's different from regular "-format". We should say explicitly something like "with no options given, prompt the user if there is a pre-existing name dir in the local file system." Likewise, "-nonInteractive" should say explicitly "do not prompt the user, but fail to format if directories already exist."
          Show
          Aaron T. Myers added a comment - Sorry Arpit, I should have mentioned these earlier. Other changes that I'd like to see: I think you have a typo in the "-nonInteractive" option. "Interactive" is one word, and the "a" should not be capitalized. It's not obvious from the description of "-nonInteractive" how it's different from regular "-format". We should say explicitly something like "with no options given, prompt the user if there is a pre-existing name dir in the local file system." Likewise, "-nonInteractive" should say explicitly "do not prompt the user, but fail to format if directories already exist."
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12518985/HADOOP-8185.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/731//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/731//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12518985/HADOOP-8185.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/731//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/731//console This message is automatically generated.
          Hide
          Arpit Gupta added a comment -

          Attached a patch and added more description to the format command.

          Show
          Arpit Gupta added a comment - Attached a patch and added more description to the format command.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12518993/HADOOP-8185.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/732//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/732//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12518993/HADOOP-8185.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/732//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/732//console This message is automatically generated.
          Hide
          Arpit Gupta added a comment -

          added more description for nonInteractive option.

          Show
          Arpit Gupta added a comment - added more description for nonInteractive option.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12519128/HADOOP-8185.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/738//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/738//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12519128/HADOOP-8185.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/738//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/738//console This message is automatically generated.
          Hide
          Arpit Gupta added a comment -

          Aaron HDFS-3094 is committed to trunk, when you get some time if you can review and commit the doc changes if it looks good.

          Show
          Arpit Gupta added a comment - Aaron HDFS-3094 is committed to trunk, when you get some time if you can review and commit the doc changes if it looks good.
          Hide
          Aaron T. Myers added a comment -

          Thanks a lot for the reminder, Arpit.

          +1, the latest patch looks good to me. I'll commit this momentarily.

          Show
          Aaron T. Myers added a comment - Thanks a lot for the reminder, Arpit. +1, the latest patch looks good to me. I'll commit this momentarily.
          Hide
          Aaron T. Myers added a comment -

          I've just committed this to branch-2 and trunk. Thanks a lot for the contribution, Arpit.

          Show
          Aaron T. Myers added a comment - I've just committed this to branch-2 and trunk. Thanks a lot for the contribution, Arpit.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #2173 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2173/)
          HADOOP-8185. Update namenode -format documentation and add -nonInteractive and -force. Contributed by Arpit Gupta. (Revision 1333141)

          Result = SUCCESS
          atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1333141
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/docs/src/documentation/content/xdocs/commands_manual.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2173 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2173/ ) HADOOP-8185 . Update namenode -format documentation and add -nonInteractive and -force. Contributed by Arpit Gupta. (Revision 1333141) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1333141 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/docs/src/documentation/content/xdocs/commands_manual.xml
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #2247 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2247/)
          HADOOP-8185. Update namenode -format documentation and add -nonInteractive and -force. Contributed by Arpit Gupta. (Revision 1333141)

          Result = SUCCESS
          atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1333141
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/docs/src/documentation/content/xdocs/commands_manual.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2247 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2247/ ) HADOOP-8185 . Update namenode -format documentation and add -nonInteractive and -force. Contributed by Arpit Gupta. (Revision 1333141) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1333141 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/docs/src/documentation/content/xdocs/commands_manual.xml
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #2189 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2189/)
          HADOOP-8185. Update namenode -format documentation and add -nonInteractive and -force. Contributed by Arpit Gupta. (Revision 1333141)

          Result = ABORTED
          atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1333141
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/docs/src/documentation/content/xdocs/commands_manual.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2189 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2189/ ) HADOOP-8185 . Update namenode -format documentation and add -nonInteractive and -force. Contributed by Arpit Gupta. (Revision 1333141) Result = ABORTED atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1333141 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/docs/src/documentation/content/xdocs/commands_manual.xml
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #1033 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1033/)
          HADOOP-8185. Update namenode -format documentation and add -nonInteractive and -force. Contributed by Arpit Gupta. (Revision 1333141)

          Result = FAILURE
          atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1333141
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/docs/src/documentation/content/xdocs/commands_manual.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1033 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1033/ ) HADOOP-8185 . Update namenode -format documentation and add -nonInteractive and -force. Contributed by Arpit Gupta. (Revision 1333141) Result = FAILURE atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1333141 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/docs/src/documentation/content/xdocs/commands_manual.xml
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1068 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1068/)
          HADOOP-8185. Update namenode -format documentation and add -nonInteractive and -force. Contributed by Arpit Gupta. (Revision 1333141)

          Result = FAILURE
          atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1333141
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/docs/src/documentation/content/xdocs/commands_manual.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1068 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1068/ ) HADOOP-8185 . Update namenode -format documentation and add -nonInteractive and -force. Contributed by Arpit Gupta. (Revision 1333141) Result = FAILURE atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1333141 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/docs/src/documentation/content/xdocs/commands_manual.xml

            People

            • Assignee:
              Arpit Gupta
              Reporter:
              Arpit Gupta
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development