Hadoop Common
  1. Hadoop Common
  2. HADOOP-8172

Configuration no longer sets all keys in a deprecated key list.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 0.23.3, 0.24.0
    • Fix Version/s: 0.23.3, 2.0.2-alpha
    • Component/s: conf
    • Labels:
      None

      Description

      I did not look at the patch for HADOOP-8167 previously, but I did in response to a recent test failure. The patch appears to have changed the following code (I am just paraphrasing the code)

      if(!deprecated(key)) {
        set(key, value);
      } else {
        for(String newKey: depricatedKeyMap.get(key)) {
          set(newKey, value);
        }
      }
      

      to be

      set(key, value);
      if(depricatedKeyMap.contains(key)) {
         set(deprecatedKeyMap.get(key)[0], value);
      } else if(reverseKeyMap.contains(key)) {
         set(reverseKeyMap.get(key), value);
      }
      

      If a key is deprecated and is mapped to more then one new key value only the first one in the list will be set, where as previously all of them would be set.

      1. HADOOP-8172-branch-2.patch
        12 kB
        Anupam Seth
      2. HADOOP-8172-branch-2.patch
        11 kB
        Anupam Seth

        Issue Links

          Activity

          Robert Joseph Evans created issue -
          Robert Joseph Evans made changes -
          Field Original Value New Value
          Assignee Robert Joseph Evans [ revans2 ]
          Anupam Seth made changes -
          Assignee Anupam Seth [ anupamseth ]
          Tsz Wo Nicholas Sze made changes -
          Link This issue is broken by HADOOP-8167 [ HADOOP-8167 ]
          Anupam Seth made changes -
          Attachment HADOOP-8172-branch-2.patch [ 12522820 ]
          Anupam Seth made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Anupam Seth made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Anupam Seth made changes -
          Attachment HADOOP-8172-branch-2.patch [ 12522826 ]
          Anupam Seth made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Robert Joseph Evans made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Robert Joseph Evans made changes -
          Priority Blocker [ 1 ] Critical [ 2 ]
          Robert Joseph Evans made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Fix Version/s 2.0.0 [ 12320352 ]
          Fix Version/s 3.0.0 [ 12320357 ]
          Resolution Fixed [ 1 ]
          Arun C Murthy made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Robert Joseph Evans made changes -
          Fix Version/s 0.23.3 [ 12320059 ]
          Arun C Murthy made changes -
          Fix Version/s 2.0.2-alpha [ 12322473 ]
          Fix Version/s 2.0.0-alpha [ 12320352 ]
          Fix Version/s 3.0.0 [ 12320357 ]

            People

            • Assignee:
              Anupam Seth
              Reporter:
              Robert Joseph Evans
            • Votes:
              0 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development