Hadoop Common
  1. Hadoop Common
  2. HADOOP-8160

HardLink.getLinkCount() is getting stuck in eclipse ( Cygwin) for long file names, due to MS-Dos style Path.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Not a Problem
    • Affects Version/s: 0.23.1, 0.24.0
    • Fix Version/s: 3.0.0, 2.1.0-beta
    • Component/s: util
    • Labels:
      None
    • Environment:

      Cygwin

      Description

      HardLink.getLinkCount() is getting stuck in cygwin for long file names, due to MS-DOS style path.

      1. HADOOP-8160.patch
        3 kB
        Vinayakumar B

        Activity

        Hide
        Vinayakumar B added a comment -

        Attached the Patch for the same.

        Show
        Vinayakumar B added a comment - Attached the Patch for the same.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12517879/HADOOP-8160.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.fs.TestHardLink

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/698//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/698//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12517879/HADOOP-8160.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.fs.TestHardLink +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/698//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/698//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12517880/HADOOP-8160.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.fs.viewfs.TestViewFsTrash
        org.apache.hadoop.fs.TestHardLink

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/699//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/699//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12517880/HADOOP-8160.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.fs.viewfs.TestViewFsTrash org.apache.hadoop.fs.TestHardLink +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/699//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/699//console This message is automatically generated.
        Hide
        Vinayakumar B added a comment -

        Attaching the Patch. Tested this patch in Linux and Windows (Cygwin).

        Show
        Vinayakumar B added a comment - Attaching the Patch. Tested this patch in Linux and Windows (Cygwin).
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12517888/HADOOP-8160.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/700//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/700//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12517888/HADOOP-8160.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/700//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/700//console This message is automatically generated.
        Hide
        Brandon Li added a comment -

        +1, the patch looks good to me.

        FYI, a significant effort has been done in branch-1-win to support HADOOP on Windows platform (without cygwin). You can check it out if you are interested.

        Show
        Brandon Li added a comment - +1, the patch looks good to me. FYI, a significant effort has been done in branch-1-win to support HADOOP on Windows platform (without cygwin). You can check it out if you are interested.
        Hide
        Brandon Li added a comment -

        I am so sorry that, after double checking the patch, I got a couple more comments.
        1. it would be nice to have a method to convert DOS path to CygWin path, and have a unit test to just test the conversion.
        2. can you document in the code why using another thread to getLinkCount?

        Show
        Brandon Li added a comment - I am so sorry that, after double checking the patch, I got a couple more comments. 1. it would be nice to have a method to convert DOS path to CygWin path, and have a unit test to just test the conversion. 2. can you document in the code why using another thread to getLinkCount?
        Hide
        Vinayakumar B added a comment -

        This is no more a problem as Windows support is implemented and hardlink count is found using winutils.exe.

        Closing as not a problem.

        Show
        Vinayakumar B added a comment - This is no more a problem as Windows support is implemented and hardlink count is found using winutils.exe. Closing as not a problem.

          People

          • Assignee:
            Vinayakumar B
            Reporter:
            Vinayakumar B
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 2m
              2m
              Remaining:
              Remaining Estimate - 2m
              2m
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development