Hadoop Common
  1. Hadoop Common
  2. HADOOP-8147

test-patch should run tests with -fn to avoid masking test failures

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.24.0
    • Fix Version/s: 3.0.0
    • Component/s: test
    • Labels:
      None

      Description

      If there are known failures, test-patch will bail out as soon as it sees them. This causes the precommit builds to potentially not find real issues with a patch, because the tests that would fail might come after a known failure. We should add -fn to just the mvn test command in test-patch to get the full list of failures.

      1. HADOOP-8147.txt
        1 kB
        Robert Joseph Evans
      2. HADOOP-8147.txt
        1 kB
        Robert Joseph Evans
      3. HADOOP-8147.txt
        1 kB
        Robert Joseph Evans

        Issue Links

          Activity

          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12517750/HADOOP-8147.txt
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 5 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/694//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12517750/HADOOP-8147.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 5 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/694//console This message is automatically generated.
          Hide
          Robert Joseph Evans added a comment -

          The -1 is because this is a change to the commit build script, and the commit build will not test changes outside of hadoop-common-project/

          Show
          Robert Joseph Evans added a comment - The -1 is because this is a change to the commit build script, and the commit build will not test changes outside of hadoop-common-project/
          Hide
          Suresh Srinivas added a comment -

          Some typos - "faile". Add space before With in #With.

          +1 with that change.

          Show
          Suresh Srinivas added a comment - Some typos - "faile". Add space before With in #With. +1 with that change.
          Hide
          Robert Joseph Evans added a comment -

          Canceling patch to address comments.

          Show
          Robert Joseph Evans added a comment - Canceling patch to address comments.
          Hide
          Robert Joseph Evans added a comment -

          I need to learn to read the comments fully before submitting a small update to a patch.

          Show
          Robert Joseph Evans added a comment - I need to learn to read the comments fully before submitting a small update to a patch.
          Hide
          Thomas Graves added a comment -

          +1 Thanks Bobby!

          Show
          Thomas Graves added a comment - +1 Thanks Bobby!
          Hide
          Thomas Graves added a comment -

          I committed this to trunk.

          Show
          Thomas Graves added a comment - I committed this to trunk.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #2126 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2126/)
          HADOOP-8147. test-patch should run tests with -fn to avoid masking test failures (Robert Evans via tgraves) (Revision 1324816)

          Result = SUCCESS
          tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1324816
          Files :

          • /hadoop/common/trunk/dev-support/test-patch.sh
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2126 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2126/ ) HADOOP-8147 . test-patch should run tests with -fn to avoid masking test failures (Robert Evans via tgraves) (Revision 1324816) Result = SUCCESS tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1324816 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #2052 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2052/)
          HADOOP-8147. test-patch should run tests with -fn to avoid masking test failures (Robert Evans via tgraves) (Revision 1324816)

          Result = SUCCESS
          tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1324816
          Files :

          • /hadoop/common/trunk/dev-support/test-patch.sh
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2052 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2052/ ) HADOOP-8147 . test-patch should run tests with -fn to avoid masking test failures (Robert Evans via tgraves) (Revision 1324816) Result = SUCCESS tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1324816 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #2065 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2065/)
          HADOOP-8147. test-patch should run tests with -fn to avoid masking test failures (Robert Evans via tgraves) (Revision 1324816)

          Result = SUCCESS
          tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1324816
          Files :

          • /hadoop/common/trunk/dev-support/test-patch.sh
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2065 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2065/ ) HADOOP-8147 . test-patch should run tests with -fn to avoid masking test failures (Robert Evans via tgraves) (Revision 1324816) Result = SUCCESS tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1324816 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #1012 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1012/)
          HADOOP-8147. test-patch should run tests with -fn to avoid masking test failures (Robert Evans via tgraves) (Revision 1324816)

          Result = FAILURE
          tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1324816
          Files :

          • /hadoop/common/trunk/dev-support/test-patch.sh
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1012 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1012/ ) HADOOP-8147 . test-patch should run tests with -fn to avoid masking test failures (Robert Evans via tgraves) (Revision 1324816) Result = FAILURE tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1324816 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1047 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1047/)
          HADOOP-8147. test-patch should run tests with -fn to avoid masking test failures (Robert Evans via tgraves) (Revision 1324816)

          Result = SUCCESS
          tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1324816
          Files :

          • /hadoop/common/trunk/dev-support/test-patch.sh
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1047 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1047/ ) HADOOP-8147 . test-patch should run tests with -fn to avoid masking test failures (Robert Evans via tgraves) (Revision 1324816) Result = SUCCESS tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1324816 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt

            People

            • Assignee:
              Robert Joseph Evans
              Reporter:
              Robert Joseph Evans
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development