Hadoop Common
  1. Hadoop Common
  2. HADOOP-8132

64bit secure datanodes do not start as the jsvc path is wrong

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.0.1
    • Fix Version/s: 1.0.2
    • Component/s: None
    • Labels:
      None
    • Target Version/s:

      Description

      64bit secure datanodes were looking for /usr/libexec/../libexec/jsvc. instead of /usr/libexec/../libexec/jsvc.amd64

        Issue Links

          Activity

          Hide
          Arpit Gupta added a comment -

          simple fix where determination of JAVA_ARCH is moved outside of the native code check.

          Show
          Arpit Gupta added a comment - simple fix where determination of JAVA_ARCH is moved outside of the native code check.
          Hide
          Arpit Gupta added a comment -

          i was able to start 32 and 64bit secure datanodes with this patch

          Show
          Arpit Gupta added a comment - i was able to start 32 and 64bit secure datanodes with this patch
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12516796/HADOOP-8132.branch-1.0.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/656//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12516796/HADOOP-8132.branch-1.0.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/656//console This message is automatically generated.
          Hide
          Arpit Gupta added a comment -

          this issue only exists on branch 1 as trunk is not using architecture specific jscv. In branch 1 the architecture is only determined inside the native code check and this patch moves it out to before that check.

          Show
          Arpit Gupta added a comment - this issue only exists on branch 1 as trunk is not using architecture specific jscv. In branch 1 the architecture is only determined inside the native code check and this patch moves it out to before that check.
          Hide
          Matt Foley added a comment -

          When HADOOP-8090 is fixed, should this also be changed to /usr/libexec/../libexec/jsvc.x86_64 ?

          Show
          Matt Foley added a comment - When HADOOP-8090 is fixed, should this also be changed to /usr/libexec/../libexec/jsvc.x86_64 ?
          Hide
          Arpit Gupta added a comment -

          The platform information is determined using

          JAVA_PLATFORM=`CLASSPATH=${CLASSPATH} ${JAVA} -Xmx32m ${HADOOP_JAVA_PLATFORM_OPTS} org.apache.hadoop.util.PlatformName | sed -e "s/ /_/g"`
          

          So unless this class returns x86_64 we should not make this change.

          Show
          Arpit Gupta added a comment - The platform information is determined using JAVA_PLATFORM=`CLASSPATH=${CLASSPATH} ${JAVA} -Xmx32m ${HADOOP_JAVA_PLATFORM_OPTS} org.apache.hadoop.util.PlatformName | sed -e "s/ /_/g" ` So unless this class returns x86_64 we should not make this change.
          Hide
          Devaraj Das added a comment -

          +1 (will commit it shortly)

          Show
          Devaraj Das added a comment - +1 (will commit it shortly)
          Hide
          Matt Foley added a comment -

          Committed to branch-1.0 and branch-1.
          Thanks, Arpit!

          Show
          Matt Foley added a comment - Committed to branch-1.0 and branch-1. Thanks, Arpit!

            People

            • Assignee:
              Arpit Gupta
              Reporter:
              Arpit Gupta
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development