Hadoop Common
  1. Hadoop Common
  2. HADOOP-8119

Fix javac warnings in TestAuthenticationFilter

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.20.205.0, 1.0.0, 0.23.0, 0.24.0
    • Fix Version/s: 2.0.0-alpha
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      There are 43 javac warnings in TestAuthenticationFilter.

      1. c8119_20120228.patch
        12 kB
        Tsz Wo Nicholas Sze

        Issue Links

          Activity

          Tsz Wo Nicholas Sze created issue -
          Hide
          Tsz Wo Nicholas Sze added a comment -

          c8119_20120228.patch: fixes the warnings.

          Show
          Tsz Wo Nicholas Sze added a comment - c8119_20120228.patch: fixes the warnings.
          Tsz Wo Nicholas Sze made changes -
          Field Original Value New Value
          Attachment c8119_20120228.patch [ 12516506 ]
          Tsz Wo Nicholas Sze made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Suresh Srinivas added a comment -

          +1 for the patch. Can you please set affects version field.

          Show
          Suresh Srinivas added a comment - +1 for the patch. Can you please set affects version field.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12516506/c8119_20120228.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/640//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/640//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12516506/c8119_20120228.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/640//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/640//console This message is automatically generated.
          Tsz Wo Nicholas Sze made changes -
          Link This issue is broken by HADOOP-7119 [ HADOOP-7119 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #1887 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1887/)
          HADOOP-8119. Fix javac warnings in TestAuthenticationFilter in hadoop-auth. (Revision 1295251)

          Result = SUCCESS
          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1295251
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/test/java/org/apache/hadoop/security/authentication/server/TestAuthenticationFilter.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1887 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1887/ ) HADOOP-8119 . Fix javac warnings in TestAuthenticationFilter in hadoop-auth. (Revision 1295251) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1295251 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/test/java/org/apache/hadoop/security/authentication/server/TestAuthenticationFilter.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-0.23-Commit #621 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/621/)
          svn merge -c 1295251 from trunk for HADOOP-8119. (Revision 1295252)

          Result = SUCCESS
          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1295252
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-common-project
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth/src/test/java/org/apache/hadoop/security/authentication/server/TestAuthenticationFilter.java
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Common-0.23-Commit #621 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/621/ ) svn merge -c 1295251 from trunk for HADOOP-8119 . (Revision 1295252) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1295252 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth/src/test/java/org/apache/hadoop/security/authentication/server/TestAuthenticationFilter.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #1812 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1812/)
          HADOOP-8119. Fix javac warnings in TestAuthenticationFilter in hadoop-auth. (Revision 1295251)

          Result = SUCCESS
          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1295251
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/test/java/org/apache/hadoop/security/authentication/server/TestAuthenticationFilter.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1812 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1812/ ) HADOOP-8119 . Fix javac warnings in TestAuthenticationFilter in hadoop-auth. (Revision 1295251) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1295251 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/test/java/org/apache/hadoop/security/authentication/server/TestAuthenticationFilter.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          Tsz Wo Nicholas Sze added a comment -

          Suresh,

          First, thanks for reviewing it.

          For the affects versions, most of the warnings (if not all) were from HADOOP-7119 which was committed to 0.20.205.0 and 0.23.0. So the affects versions are 0.20.205.0, 1.0.0, 0.23.0 and 0.24.0.

          Show
          Tsz Wo Nicholas Sze added a comment - Suresh, First, thanks for reviewing it. For the affects versions, most of the warnings (if not all) were from HADOOP-7119 which was committed to 0.20.205.0 and 0.23.0. So the affects versions are 0.20.205.0, 1.0.0, 0.23.0 and 0.24.0.
          Tsz Wo Nicholas Sze made changes -
          Fix Version/s 0.24.0 [ 12317652 ]
          Fix Version/s 0.23.3 [ 12320059 ]
          Affects Version/s 1.0.0 [ 12318244 ]
          Affects Version/s 0.23.0 [ 12315569 ]
          Affects Version/s 0.20.205.0 [ 12316390 ]
          Affects Version/s 0.24.0 [ 12317652 ]
          Hide
          Tsz Wo Nicholas Sze added a comment -

          I have committed this to trunk and 0.23.

          Show
          Tsz Wo Nicholas Sze added a comment - I have committed this to trunk and 0.23.
          Tsz Wo Nicholas Sze made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags Reviewed [ 10343 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-0.23-Commit #610 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/610/)
          svn merge -c 1295251 from trunk for HADOOP-8119. (Revision 1295252)

          Result = SUCCESS
          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1295252
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-common-project
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth/src/test/java/org/apache/hadoop/security/authentication/server/TestAuthenticationFilter.java
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Commit #610 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/610/ ) svn merge -c 1295251 from trunk for HADOOP-8119 . (Revision 1295252) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1295252 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth/src/test/java/org/apache/hadoop/security/authentication/server/TestAuthenticationFilter.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-0.23-Commit #620 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/620/)
          svn merge -c 1295251 from trunk for HADOOP-8119. (Revision 1295252)

          Result = ABORTED
          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1295252
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-common-project
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth/src/test/java/org/apache/hadoop/security/authentication/server/TestAuthenticationFilter.java
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Commit #620 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/620/ ) svn merge -c 1295251 from trunk for HADOOP-8119 . (Revision 1295252) Result = ABORTED szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1295252 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth/src/test/java/org/apache/hadoop/security/authentication/server/TestAuthenticationFilter.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #1818 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1818/)
          HADOOP-8119. Fix javac warnings in TestAuthenticationFilter in hadoop-auth. (Revision 1295251)

          Result = ABORTED
          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1295251
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/test/java/org/apache/hadoop/security/authentication/server/TestAuthenticationFilter.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1818 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1818/ ) HADOOP-8119 . Fix javac warnings in TestAuthenticationFilter in hadoop-auth. (Revision 1295251) Result = ABORTED szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1295251 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/test/java/org/apache/hadoop/security/authentication/server/TestAuthenticationFilter.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #971 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/971/)
          HADOOP-8119. Fix javac warnings in TestAuthenticationFilter in hadoop-auth. (Revision 1295251)

          Result = SUCCESS
          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1295251
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/test/java/org/apache/hadoop/security/authentication/server/TestAuthenticationFilter.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #971 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/971/ ) HADOOP-8119 . Fix javac warnings in TestAuthenticationFilter in hadoop-auth. (Revision 1295251) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1295251 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/test/java/org/apache/hadoop/security/authentication/server/TestAuthenticationFilter.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1006 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1006/)
          HADOOP-8119. Fix javac warnings in TestAuthenticationFilter in hadoop-auth. (Revision 1295251)

          Result = SUCCESS
          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1295251
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/test/java/org/apache/hadoop/security/authentication/server/TestAuthenticationFilter.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1006 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1006/ ) HADOOP-8119 . Fix javac warnings in TestAuthenticationFilter in hadoop-auth. (Revision 1295251) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1295251 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/test/java/org/apache/hadoop/security/authentication/server/TestAuthenticationFilter.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Arun C Murthy made changes -
          Fix Version/s 2.0.0 [ 12320352 ]
          Fix Version/s 0.24.0 [ 12317652 ]
          Fix Version/s 0.23.3 [ 12320059 ]
          Arun C Murthy made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          2m 25s 1 Tsz Wo Nicholas Sze 29/Feb/12 03:08
          Patch Available Patch Available Resolved Resolved
          17h 19m 1 Tsz Wo Nicholas Sze 29/Feb/12 20:28
          Resolved Resolved Closed Closed
          83d 23h 47m 1 Arun C Murthy 23/May/12 21:15

            People

            • Assignee:
              Tsz Wo Nicholas Sze
              Reporter:
              Tsz Wo Nicholas Sze
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development