Hadoop Common
  1. Hadoop Common
  2. HADOOP-8108

move method getHostPortString() from NameNode to NetUtils

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.23.3, 0.24.0
    • Fix Version/s: None
    • Component/s: util
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      This issue is the counter part of the issue HDFS-3003.

        Issue Links

          Activity

          Brandon Li created issue -
          Brandon Li made changes -
          Field Original Value New Value
          Attachment HADOOP-8108.patch [ 12515856 ]
          Brandon Li made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Jitendra Nath Pandey made changes -
          Link This issue blocks HDFS-3003 [ HDFS-3003 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12515856/HADOOP-8108.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.ipc.TestRPCCallBenchmark

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/626//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/626//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12515856/HADOOP-8108.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.ipc.TestRPCCallBenchmark +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/626//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/626//console This message is automatically generated.
          Hide
          Jitendra Nath Pandey added a comment -

          +1

          Show
          Jitendra Nath Pandey added a comment - +1
          Hide
          Jitendra Nath Pandey added a comment -

          I think unit tests are not needed, because the method is just moved to NetUtils from Namenode and will be sufficiently tested with HDFS-3003.
          I have committed this. Thanks to Brandon Li.

          Show
          Jitendra Nath Pandey added a comment - I think unit tests are not needed, because the method is just moved to NetUtils from Namenode and will be sufficiently tested with HDFS-3003 . I have committed this. Thanks to Brandon Li.
          Jitendra Nath Pandey made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags Reviewed [ 10343 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #1844 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1844/)
          HADOOP-8108. Move method getHostPortString() from NameNode to NetUtils. Contributed by Brandon Li. (Revision 1293128)

          Result = SUCCESS
          jitendra : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1293128
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetUtils.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1844 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1844/ ) HADOOP-8108 . Move method getHostPortString() from NameNode to NetUtils. Contributed by Brandon Li. (Revision 1293128) Result = SUCCESS jitendra : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1293128 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetUtils.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #1770 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1770/)
          HADOOP-8108. Move method getHostPortString() from NameNode to NetUtils. Contributed by Brandon Li. (Revision 1293128)

          Result = SUCCESS
          jitendra : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1293128
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetUtils.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1770 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1770/ ) HADOOP-8108 . Move method getHostPortString() from NameNode to NetUtils. Contributed by Brandon Li. (Revision 1293128) Result = SUCCESS jitendra : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1293128 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetUtils.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #1781 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1781/)
          HADOOP-8108. Move method getHostPortString() from NameNode to NetUtils. Contributed by Brandon Li. (Revision 1293128)

          Result = ABORTED
          jitendra : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1293128
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetUtils.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1781 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1781/ ) HADOOP-8108 . Move method getHostPortString() from NameNode to NetUtils. Contributed by Brandon Li. (Revision 1293128) Result = ABORTED jitendra : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1293128 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetUtils.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #965 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/965/)
          HADOOP-8108. Move method getHostPortString() from NameNode to NetUtils. Contributed by Brandon Li. (Revision 1293128)

          Result = SUCCESS
          jitendra : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1293128
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetUtils.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #965 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/965/ ) HADOOP-8108 . Move method getHostPortString() from NameNode to NetUtils. Contributed by Brandon Li. (Revision 1293128) Result = SUCCESS jitendra : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1293128 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetUtils.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1000 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1000/)
          HADOOP-8108. Move method getHostPortString() from NameNode to NetUtils. Contributed by Brandon Li. (Revision 1293128)

          Result = SUCCESS
          jitendra : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1293128
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetUtils.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1000 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1000/ ) HADOOP-8108 . Move method getHostPortString() from NameNode to NetUtils. Contributed by Brandon Li. (Revision 1293128) Result = SUCCESS jitendra : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1293128 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetUtils.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-0.23-Commit #667 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/667/)
          HADOOP-8108. Merge r1293128 from trunk to 0.23 (Revision 1298239)

          Result = SUCCESS
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298239
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetUtils.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Commit #667 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/667/ ) HADOOP-8108 . Merge r1293128 from trunk to 0.23 (Revision 1298239) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298239 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetUtils.java
          Suresh Srinivas made changes -
          Affects Version/s 0.23.3 [ 12320059 ]
          Target Version/s 0.23.3 [ 12320059 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #2160 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2160/)
          Pulled HADOOP-8108 into branch-0.23 (Revision 1327140)

          Result = SUCCESS
          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1327140
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2160 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2160/ ) Pulled HADOOP-8108 into branch-0.23 (Revision 1327140) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1327140 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #2087 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2087/)
          Pulled HADOOP-8108 into branch-0.23 (Revision 1327140)

          Result = SUCCESS
          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1327140
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2087 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2087/ ) Pulled HADOOP-8108 into branch-0.23 (Revision 1327140) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1327140 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #2101 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2101/)
          Pulled HADOOP-8108 into branch-0.23 (Revision 1327140)

          Result = ABORTED
          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1327140
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2101 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2101/ ) Pulled HADOOP-8108 into branch-0.23 (Revision 1327140) Result = ABORTED bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1327140 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-0.23-Build #231 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/231/)
          HADOOP-8108. Move method getHostPortString() from NameNode to NetUtils. Contributed by Brandon Li (Revision 1327139)

          Result = SUCCESS
          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1327139
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetUtils.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #231 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/231/ ) HADOOP-8108 . Move method getHostPortString() from NameNode to NetUtils. Contributed by Brandon Li (Revision 1327139) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1327139 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetUtils.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #1018 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1018/)
          Pulled HADOOP-8108 into branch-0.23 (Revision 1327140)

          Result = FAILURE
          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1327140
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1018 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1018/ ) Pulled HADOOP-8108 into branch-0.23 (Revision 1327140) Result = FAILURE bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1327140 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1053 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1053/)
          Pulled HADOOP-8108 into branch-0.23 (Revision 1327140)

          Result = SUCCESS
          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1327140
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1053 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1053/ ) Pulled HADOOP-8108 into branch-0.23 (Revision 1327140) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1327140 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt

            People

            • Assignee:
              Brandon Li
              Reporter:
              Brandon Li
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development