-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12514182/HADOOP-8057.patch
against trunk revision .

+1 @author. The patch does not contain any @author tags.

-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 eclipse:eclipse. The patch built with eclipse:eclipse.

+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

+1 core tests. The patch passed unit tests in .

+1 contrib tests. The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/598//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/598//console

This message is automatically generated.

looks OK to me, no tests for any scripts
+1

Patched in trunk ant 0.23; manual verification that the trailing spaces are missing in the patched source.

Integrated in Hadoop-Hdfs-trunk-Commit #1829 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1829/)
HADOOP-8057 hadoop-setup-conf.sh not working because of some extra spaces. (Revision 1290859)

Result = SUCCESS
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1290859
Files :

• /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
• /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/packages/hadoop-setup-conf.sh

Integrated in Hadoop-Common-0.23-Commit #576 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/576/)
HADOOP-8057 hadoop-setup-conf.sh not working because of some extra spaces. (Revision 1290858)

Result = SUCCESS
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1290858
Files :

• /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
• /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/packages/hadoop-setup-conf.sh

Integrated in Hadoop-Common-trunk-Commit #1755 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1755/)
HADOOP-8057 hadoop-setup-conf.sh not working because of some extra spaces. (Revision 1290859)

Result = FAILURE
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1290859
Files :

• /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
• /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/packages/hadoop-setup-conf.sh

Integrated in Hadoop-Hdfs-0.23-Commit #563 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/563/)
HADOOP-8057 hadoop-setup-conf.sh not working because of some extra spaces. (Revision 1290858)

Result = SUCCESS
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1290858
Files :

• /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
• /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/packages/hadoop-setup-conf.sh

Integrated in Hadoop-Mapreduce-trunk-Commit #1766 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1766/)
HADOOP-8057 hadoop-setup-conf.sh not working because of some extra spaces. (Revision 1290859)

Result = ABORTED
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1290859
Files :

• /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
• /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/packages/hadoop-setup-conf.sh

Integrated in Hadoop-Mapreduce-0.23-Commit #578 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/578/)
HADOOP-8057 hadoop-setup-conf.sh not working because of some extra spaces. (Revision 1290858)

Result = ABORTED
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1290858
Files :

• /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
• /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/packages/hadoop-setup-conf.sh

Integrated in Hadoop-Hdfs-trunk #960 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/960/)
HADOOP-8057 hadoop-setup-conf.sh not working because of some extra spaces. (Revision 1290859)

Result = SUCCESS
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1290859
Files :

• /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
• /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/packages/hadoop-setup-conf.sh

Integrated in Hadoop-Hdfs-0.23-Build #173 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/173/)
HADOOP-8057 hadoop-setup-conf.sh not working because of some extra spaces. (Revision 1290858)

Result = SUCCESS
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1290858
Files :

• /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
• /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/packages/hadoop-setup-conf.sh

Integrated in Hadoop-Mapreduce-trunk #995 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/995/)
HADOOP-8057 hadoop-setup-conf.sh not working because of some extra spaces. (Revision 1290859)

Result = SUCCESS
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1290859
Files :

• /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
• /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/packages/hadoop-setup-conf.sh

Integrated in Hadoop-Mapreduce-0.23-Build #201 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/201/)
HADOOP-8057 hadoop-setup-conf.sh not working because of some extra spaces. (Revision 1290858)

Result = FAILURE
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1290858
Files :

• /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
• /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/packages/hadoop-setup-conf.sh