Hadoop Common
  1. Hadoop Common
  2. HADOOP-8044

Unify ProtocolMetaInterface and ProtocolTranslator interface

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Invalid
    • Affects Version/s: HA Branch (HDFS-1623)
    • Fix Version/s: HA Branch (HDFS-1623)
    • Component/s: ha, ipc
    • Labels:
      None

      Description

      In the HA branch we have a "ProtocolTranslator" interface which we had to add, and it seems to have the same purpose as the "ProtocolMetaInterface" interface which got added in trunk in the meantime. We should unify the two.

        Activity

        Hide
        Jitendra Nath Pandey added a comment -

        ProtocolMetaInterface is supposed to be used to obtain information about underlying protocol e.g. to check if a method is supported on the server side. Its implementation creates ProtocolMetaInfoPB connection to server and gets protocol signatures. For (contrived)example, in future if we want to add a method to find how many versions of the given protocol are supported at the server, we could add a method in this interface.

        I think ProtocolTranslator was added as a mechanism to expose the proxy so as to reach the connectionId.
        They have two very different purposes.

        Show
        Jitendra Nath Pandey added a comment - ProtocolMetaInterface is supposed to be used to obtain information about underlying protocol e.g. to check if a method is supported on the server side. Its implementation creates ProtocolMetaInfoPB connection to server and gets protocol signatures. For (contrived)example, in future if we want to add a method to find how many versions of the given protocol are supported at the server, we could add a method in this interface. I think ProtocolTranslator was added as a mechanism to expose the proxy so as to reach the connectionId. They have two very different purposes.
        Hide
        Todd Lipcon added a comment -

        Gotcha, that makes sense. Resolving as invalid, sorry for the noise.

        Show
        Todd Lipcon added a comment - Gotcha, that makes sense. Resolving as invalid, sorry for the noise.

          People

          • Assignee:
            Aaron T. Myers
            Reporter:
            Todd Lipcon
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development