Hadoop Common
  1. Hadoop Common
  2. HADOOP-8015

ChRootFileSystem should extend FilterFileSystem

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.0, 0.24.0
    • Fix Version/s: 0.23.1
    • Component/s: fs
    • Labels:
      None

      Description

      ChRootFileSystem simply extends FileSystem, and attempts to delegate some methods to the underlying mount point. It is essentially the same as FilterFileSystem but it mangles the paths to include the chroot path. Unfortunately ChRootFileSystem is not delegating some methods that should be delegated. Changing the inheritance will prevent a copy-n-paste of code for HADOOP-8013 and HADOOP-8014 into both ChRootFileSystem and FilterFileSystem.

        Issue Links

          Activity

          Hide
          Daryn Sharp added a comment -

          No functional changes, so no tests included. Existing tests will prove it works.

          Show
          Daryn Sharp added a comment - No functional changes, so no tests included. Existing tests will prove it works.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12513043/HADOOP-8015.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/559//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/559//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12513043/HADOOP-8015.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/559//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/559//console This message is automatically generated.
          Hide
          Robert Joseph Evans added a comment -

          The patch looks good, and fairly simple too +1. Let me run the HDFS unit tests and then I will check it in.

          Show
          Robert Joseph Evans added a comment - The patch looks good, and fairly simple too +1. Let me run the HDFS unit tests and then I will check it in.
          Hide
          Robert Joseph Evans added a comment -

          I just checked this in to trunk and 0.23 Thanks for the patch.

          Show
          Robert Joseph Evans added a comment - I just checked this in to trunk and 0.23 Thanks for the patch.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-0.23-Commit #465 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/465/)
          svn merge -c 1239924 fixes HADOOP-8015

          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1239925
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Commit #465 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/465/ ) svn merge -c 1239924 fixes HADOOP-8015 bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1239925 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-0.23-Commit #475 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/475/)
          svn merge -c 1239924 fixes HADOOP-8015

          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1239925
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-0.23-Commit #475 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/475/ ) svn merge -c 1239924 fixes HADOOP-8015 bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1239925 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #1648 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1648/)
          HADOOP-8015 ChRootFileSystem should extend FilterFileSystem (Daryn Sharp via bobby)

          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1239924
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1648 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1648/ ) HADOOP-8015 ChRootFileSystem should extend FilterFileSystem (Daryn Sharp via bobby) bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1239924 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #1719 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1719/)
          HADOOP-8015 ChRootFileSystem should extend FilterFileSystem (Daryn Sharp via bobby)

          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1239924
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1719 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1719/ ) HADOOP-8015 ChRootFileSystem should extend FilterFileSystem (Daryn Sharp via bobby) bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1239924 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #1663 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1663/)
          HADOOP-8015 ChRootFileSystem should extend FilterFileSystem (Daryn Sharp via bobby)

          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1239924
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1663 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1663/ ) HADOOP-8015 ChRootFileSystem should extend FilterFileSystem (Daryn Sharp via bobby) bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1239924 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-0.23-Commit #489 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/489/)
          svn merge -c 1239924 fixes HADOOP-8015

          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1239925
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Commit #489 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/489/ ) svn merge -c 1239924 fixes HADOOP-8015 bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1239925 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #945 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/945/)
          HADOOP-8015 ChRootFileSystem should extend FilterFileSystem (Daryn Sharp via bobby)

          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1239924
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #945 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/945/ ) HADOOP-8015 ChRootFileSystem should extend FilterFileSystem (Daryn Sharp via bobby) bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1239924 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-0.23-Build #158 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/158/)
          svn merge -c 1239924 fixes HADOOP-8015

          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1239925
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #158 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/158/ ) svn merge -c 1239924 fixes HADOOP-8015 bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1239925 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-0.23-Build #180 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/180/)
          svn merge -c 1239924 fixes HADOOP-8015

          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1239925
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Build #180 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/180/ ) svn merge -c 1239924 fixes HADOOP-8015 bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1239925 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #978 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/978/)
          HADOOP-8015 ChRootFileSystem should extend FilterFileSystem (Daryn Sharp via bobby)

          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1239924
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #978 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/978/ ) HADOOP-8015 ChRootFileSystem should extend FilterFileSystem (Daryn Sharp via bobby) bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1239924 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java
          Hide
          Suresh Srinivas added a comment -

          Robert Joseph Evans Given that this is in 0.23, could you please merge this to branch-2 and branch-2.1.0-beta?

          Show
          Suresh Srinivas added a comment - Robert Joseph Evans Given that this is in 0.23, could you please merge this to branch-2 and branch-2.1.0-beta?

            People

            • Assignee:
              Daryn Sharp
              Reporter:
              Daryn Sharp
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development