Hadoop Common
  1. Hadoop Common
  2. HADOOP-8014

ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.0, 0.23.2, 0.24.0
    • Fix Version/s: 0.23.3, 2.0.2-alpha
    • Component/s: fs
    • Labels:
      None

      Description

      ViewFileSystem incorrectly returns the FileSystem default values for getDefaultBlockSize() and getDefaultReplication(). This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a Path so viewfs can resolve the mount point for a path.

      1. HADOOP-8014.patch
        14 kB
        John George
      2. HADOOP-8014.patch
        14 kB
        John George
      3. HADOOP-8014.patch
        15 kB
        John George
      4. HADOOP-8014.patch
        16 kB
        John George
      5. HADOOP-8014.patch
        16 kB
        John George
      6. HADOOP-8014.patch
        18 kB
        John George
      7. HADOOP-8014.patch
        18 kB
        John George

        Issue Links

          Activity

          Daryn Sharp created issue -
          Daryn Sharp made changes -
          Field Original Value New Value
          Link This issue requires HADOOP-8015 [ HADOOP-8015 ]
          Arun C Murthy made changes -
          Target Version/s 0.23.1, 0.24.0 [ 12318884, 12317652 ] 0.23.2 [ 12319855 ]
          John George made changes -
          Link This issue relates to HDFS-3121 [ HDFS-3121 ]
          Hide
          John George added a comment -

          JIRA for hdfs side tests for this change

          Show
          John George added a comment - JIRA for hdfs side tests for this change
          John George made changes -
          Attachment HADOOP-8014.patch [ 12520179 ]
          Hide
          John George added a comment -

          Thanks to Daryn for handing over the change he made in getDefaultBlockSize and getDefaultReplication. I am attaching a patch with getDefaultBlockSize, getDefaultReplication, and getContentSummary. The tests are added as part of HDFS-3121.

          Show
          John George added a comment - Thanks to Daryn for handing over the change he made in getDefaultBlockSize and getDefaultReplication. I am attaching a patch with getDefaultBlockSize, getDefaultReplication, and getContentSummary. The tests are added as part of HDFS-3121 .
          John George made changes -
          Summary ViewFileSystem does not correctly implement getDefaultBlockSize and getDefaultReplication ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
          Assignee Daryn Sharp [ daryn ] John George [ johnvijoe ]
          Affects Version/s 0.23.2 [ 12319855 ]
          John George made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Daryn Sharp added a comment -

          Just noticed that both of the getDefaultBlockSize methods in viewfs are throwing an exception as getDefaultReplication.

          Show
          Daryn Sharp added a comment - Just noticed that both of the getDefaultBlockSize methods in viewfs are throwing an exception as getDefaultReplication.
          John George made changes -
          Attachment HADOOP-8014.patch [ 12520183 ]
          Hide
          John George added a comment -

          Thanks for catching that Daryn. Attached a new patch.

          Show
          John George added a comment - Thanks for catching that Daryn. Attached a new patch.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12520179/HADOOP-8014.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.fs.TestFilterFileSystem
          org.apache.hadoop.ha.TestZKFailoverController
          org.apache.hadoop.fs.viewfs.TestViewFileSystemWithAuthorityLocalFileSystem
          org.apache.hadoop.fs.viewfs.TestFSMainOperationsLocalFileSystem
          org.apache.hadoop.fs.viewfs.TestViewFsTrash
          org.apache.hadoop.fs.viewfs.TestViewFileSystemLocalFileSystem
          org.apache.hadoop.ha.TestFailoverController

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/791//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/791//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12520179/HADOOP-8014.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.fs.TestFilterFileSystem org.apache.hadoop.ha.TestZKFailoverController org.apache.hadoop.fs.viewfs.TestViewFileSystemWithAuthorityLocalFileSystem org.apache.hadoop.fs.viewfs.TestFSMainOperationsLocalFileSystem org.apache.hadoop.fs.viewfs.TestViewFsTrash org.apache.hadoop.fs.viewfs.TestViewFileSystemLocalFileSystem org.apache.hadoop.ha.TestFailoverController +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/791//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/791//console This message is automatically generated.
          Hide
          Daryn Sharp added a comment -

          Please double check that internalGetServerDefaults is still necessary. I think it's a remnant of an earlier attempt.

          Show
          Daryn Sharp added a comment - Please double check that internalGetServerDefaults is still necessary. I think it's a remnant of an earlier attempt.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12520183/HADOOP-8014.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.fs.TestFilterFileSystem
          org.apache.hadoop.ha.TestZKFailoverController
          org.apache.hadoop.fs.viewfs.TestViewFileSystemWithAuthorityLocalFileSystem
          org.apache.hadoop.fs.viewfs.TestFSMainOperationsLocalFileSystem
          org.apache.hadoop.fs.viewfs.TestViewFileSystemLocalFileSystem
          org.apache.hadoop.ha.TestFailoverController

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/792//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/792//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12520183/HADOOP-8014.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.fs.TestFilterFileSystem org.apache.hadoop.ha.TestZKFailoverController org.apache.hadoop.fs.viewfs.TestViewFileSystemWithAuthorityLocalFileSystem org.apache.hadoop.fs.viewfs.TestFSMainOperationsLocalFileSystem org.apache.hadoop.fs.viewfs.TestViewFileSystemLocalFileSystem org.apache.hadoop.ha.TestFailoverController +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/792//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/792//console This message is automatically generated.
          Hide
          John George added a comment -

          I will attach a patch with the unit test fixes and addressing comment from Daryn. The following is the basic theme that this patch follows. Suggestions and comments welcome:

          • getDefaultBlockSize, getDefaultReplication and getServerDefaults APIs with no path argument is invalid as far as viewFS is concerned. The logic behind this is that viewFS has no 'default' mount point. Even in cases where ROOT_PATH is mounted, my thinking is that it is not the 'default' mountpoint. Hence, viewFS will throw an exception in such cases.
          • Any call with path argument given, will be resolved accordingly and the corresponding FS routing will be called.
          Show
          John George added a comment - I will attach a patch with the unit test fixes and addressing comment from Daryn. The following is the basic theme that this patch follows. Suggestions and comments welcome: getDefaultBlockSize , getDefaultReplication and getServerDefaults APIs with no path argument is invalid as far as viewFS is concerned. The logic behind this is that viewFS has no 'default' mount point. Even in cases where ROOT_PATH is mounted, my thinking is that it is not the 'default' mountpoint. Hence, viewFS will throw an exception in such cases. Any call with path argument given, will be resolved accordingly and the corresponding FS routing will be called.
          John George made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          John George made changes -
          Attachment HADOOP-8014.patch [ 12520434 ]
          John George made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Daryn Sharp added a comment -

          Looking good, however FileFileSystem's no-path variants of the methods need to call the path variant with the root path instead of calling through to the underlying fs no-path method. Otherwise there are problems such as ChrootFileSystem not getting a chance to rewrite the path.

          Show
          Daryn Sharp added a comment - Looking good, however FileFileSystem 's no-path variants of the methods need to call the path variant with the root path instead of calling through to the underlying fs no-path method. Otherwise there are problems such as ChrootFileSystem not getting a chance to rewrite the path.
          Hide
          Daryn Sharp added a comment -

          Also, do the existing tests already verify that the correct replication factor and block size are returned, and that a non-default replication and block size are honored?

          Show
          Daryn Sharp added a comment - Also, do the existing tests already verify that the correct replication factor and block size are returned, and that a non-default replication and block size are honored?
          Daryn Sharp made changes -
          Attachment HADOOOP-8014.branch-1.patch [ 12520631 ]
          Daryn Sharp made changes -
          Attachment HADOOOP-8014.branch-1.patch [ 12520631 ]
          Hide
          John George added a comment -

          Thanks for catching that Daryn. I will upload a patch with the fix soon.

          Show
          John George added a comment - Thanks for catching that Daryn. I will upload a patch with the fix soon.
          John George made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          John George made changes -
          Attachment HADOOP-8014.patch [ 12520663 ]
          John George made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          John George added a comment -

          Also, do the existing tests already verify that the correct replication factor and block size are returned, and that a non-default replication and block size are honored?

          These are tested as part of HDFS-3121.

          Show
          John George added a comment - Also, do the existing tests already verify that the correct replication factor and block size are returned, and that a non-default replication and block size are honored? These are tested as part of HDFS-3121 .
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12520663/HADOOP-8014.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 7 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/806//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/806//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12520663/HADOOP-8014.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 7 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/806//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/806//console This message is automatically generated.
          Hide
          Daryn Sharp added a comment -

          FilterFileSystem's no-path methods should be calling the path variant. (Sorry I butchered it as FileFileSystem in an earlier comment). Pushing this behavior up into ChrootFileSystem will force any other subclass of FilterFileSystem that wants to alter the behavior of path handling to implement both methods. I think putting the behavior in FilterFileSystem is more future-proof for arbitrarily stackable filesystems.

          Otherwise, looks great.

          Show
          Daryn Sharp added a comment - FilterFileSystem 's no-path methods should be calling the path variant. (Sorry I butchered it as FileFileSystem in an earlier comment). Pushing this behavior up into ChrootFileSystem will force any other subclass of FilterFileSystem that wants to alter the behavior of path handling to implement both methods. I think putting the behavior in FilterFileSystem is more future-proof for arbitrarily stackable filesystems. Otherwise, looks great.
          Hide
          John George added a comment -

          Thanks for looking at the patch again Daryn - always appreciate your input. About moving the behavior to FilterFileSystem, I was thinking the other way round - I feel it is better to keep the behavior in ChrootFileSystem since, as of now, it is the characteristic of ChrootFileSystem to have a path. Anyone inheriting FilterFileSystem should probably implement the same behavior like you said.

          Other than this being a debatable change (since it could be either way), do you actually see a defect or an issue in this change?

          Show
          John George added a comment - Thanks for looking at the patch again Daryn - always appreciate your input. About moving the behavior to FilterFileSystem , I was thinking the other way round - I feel it is better to keep the behavior in ChrootFileSystem since, as of now, it is the characteristic of ChrootFileSystem to have a path . Anyone inheriting FilterFileSystem should probably implement the same behavior like you said. Other than this being a debatable change (since it could be either way), do you actually see a defect or an issue in this change?
          Hide
          Daryn Sharp added a comment -

          I seem to recall that Hive's ProxyFileSystem is a subclass of FilterFileSystem that does path rewriting. You may want to check that it won't break if FilterFileSystem doesn't loop the no-path methods to the path variants.

          Show
          Daryn Sharp added a comment - I seem to recall that Hive's ProxyFileSystem is a subclass of FilterFileSystem that does path rewriting. You may want to check that it won't break if FilterFileSystem doesn't loop the no-path methods to the path variants.
          Hide
          John George added a comment -

          I suppose if Hive's ProxyFileSystem is using it as of now, they would be overriding the method any way because otherwise would it end up using FileSystem methods, which is what these methods do in the patch as well. So, it shouldn't be an issue.

          Show
          John George added a comment - I suppose if Hive's ProxyFileSystem is using it as of now, they would be overriding the method any way because otherwise would it end up using FileSystem methods, which is what these methods do in the patch as well. So, it shouldn't be an issue.
          Hide
          John George added a comment -

          Daryn,
          Do you have any other concerns about the patch?

          Show
          John George added a comment - Daryn, Do you have any other concerns about the patch?
          Hide
          Daryn Sharp added a comment -

          +1 I'd rather see the logic pushed back down as in an earlier patch, but I think it's good enough for now.

          Show
          Daryn Sharp added a comment - +1 I'd rather see the logic pushed back down as in an earlier patch, but I think it's good enough for now.
          Hide
          John George added a comment -

          Attaching a patch with minor cosmetic changes (line alignment etc, @keyword etc)

          Show
          John George added a comment - Attaching a patch with minor cosmetic changes (line alignment etc, @keyword etc)
          John George made changes -
          Attachment HADOOP-8014.patch [ 12521506 ]
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12521506/HADOOP-8014.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 2 new or modified test files.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/825//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/825//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12521506/HADOOP-8014.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified test files. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/825//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/825//console This message is automatically generated.
          Hide
          Suresh Srinivas added a comment -

          Nice work.

          Most of these are minor comments.

          1. FileSystem#getServerDefaults() - is it better to day path p is used for identifying a destination file system? Same for FileSystem#getDefaultReplication(path). Perhaps adding information like a FileSystem could have another file system or file systems it could be delegating the call to. Path helps identifying the underlying file system?
          2. Please move NotInMountException to a separate java file
          3. FileSystemTestHelper#createParent not used in createFile() method. Do you need multiple overloaded variants of that method?
          Show
          Suresh Srinivas added a comment - Nice work. Most of these are minor comments. FileSystem#getServerDefaults() - is it better to day path p is used for identifying a destination file system? Same for FileSystem#getDefaultReplication(path). Perhaps adding information like a FileSystem could have another file system or file systems it could be delegating the call to. Path helps identifying the underlying file system? Please move NotInMountException to a separate java file FileSystemTestHelper#createParent not used in createFile() method. Do you need multiple overloaded variants of that method?
          Hide
          Suresh Srinivas added a comment -

          is it better to day

          is it better to say. I had to think for a long time to figure out what I was trying to say

          Show
          Suresh Srinivas added a comment - is it better to day is it better to say. I had to think for a long time to figure out what I was trying to say
          Hide
          Suresh Srinivas added a comment -

          BTW if you take care of these comments, I am +1 for the patch.

          Show
          Suresh Srinivas added a comment - BTW if you take care of these comments, I am +1 for the patch.
          Hide
          Daryn Sharp added a comment -

          Are you suggesting that fs.getDefaultReplication(Path) should automatically delegate to the filesystem of the path? Would it be better to call checkPath(Path)?

          Show
          Daryn Sharp added a comment - Are you suggesting that fs.getDefaultReplication(Path) should automatically delegate to the filesystem of the path? Would it be better to call checkPath(Path) ?
          Hide
          John George added a comment -

          Canceling patch to address Suresh's comment.

          Show
          John George added a comment - Canceling patch to address Suresh's comment.
          John George made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          John George made changes -
          Attachment HADOOP-8014.patch [ 12521558 ]
          Hide
          John George added a comment -

          # FileSystem#getServerDefaults() - is it better to day path p is used for identifying a destination file system? Same for FileSystem#getDefaultReplication(path). Perhaps adding information like a FileSystem could have another file system or file systems it could be delegating the call to. Path helps identifying the underlying file system?

          I understand that you expect a comment change here - basically add a comment explaining why path is used?

          # Please move NotInMountException to a separate java file

          done

          # FileSystemTestHelper#createParent not used in createFile() method. Do you need multiple overloaded variants of that method?

          removed.

          Show
          John George added a comment - # FileSystem#getServerDefaults() - is it better to day path p is used for identifying a destination file system? Same for FileSystem#getDefaultReplication(path). Perhaps adding information like a FileSystem could have another file system or file systems it could be delegating the call to. Path helps identifying the underlying file system? I understand that you expect a comment change here - basically add a comment explaining why path is used? # Please move NotInMountException to a separate java file done # FileSystemTestHelper#createParent not used in createFile() method. Do you need multiple overloaded variants of that method? removed.
          John George made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12521558/HADOOP-8014.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 2 new or modified test files.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.fs.viewfs.TestViewFsTrash

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/831//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/831//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12521558/HADOOP-8014.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified test files. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.fs.viewfs.TestViewFsTrash +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/831//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/831//console This message is automatically generated.
          Hide
          Suresh Srinivas added a comment -

          Are you suggesting that fs.getDefaultReplication(Path) should automatically delegate to the filesystem of the path? Would it be better to call checkPath(Path)?

          I understand that you expect a comment change here - basically add a comment explaining why path is used?

          File system defaults with a path seems to be confusing - given common understanding would be defaults are the file system level. These variants of methods become more meaningful, once a user of API understands that a FileSystem implementation could be front ending another file system or file systems. The path is used only for identifying an underlying file system, where necessary. I was thinking if we could capture that information, to avoid confusion, where user might end up thinking that the defaults are associated with a file corresponding to the path.

          Makes sense?

          Show
          Suresh Srinivas added a comment - Are you suggesting that fs.getDefaultReplication(Path) should automatically delegate to the filesystem of the path? Would it be better to call checkPath(Path)? I understand that you expect a comment change here - basically add a comment explaining why path is used? File system defaults with a path seems to be confusing - given common understanding would be defaults are the file system level. These variants of methods become more meaningful, once a user of API understands that a FileSystem implementation could be front ending another file system or file systems. The path is used only for identifying an underlying file system, where necessary. I was thinking if we could capture that information, to avoid confusion, where user might end up thinking that the defaults are associated with a file corresponding to the path. Makes sense?
          Hide
          Suresh Srinivas added a comment -

          Just realized - my previous comment is addressed by your new patch.

          In the new patch - {{Its spec and implementation is identical to

          {@link ViewFs}

          .}} not sure what you mean here. Can you please add description on when this is used or what error it conveys? Once you address that I am +1 for the patch, if the test failure is unrelated to this.

          Show
          Suresh Srinivas added a comment - Just realized - my previous comment is addressed by your new patch. In the new patch - {{Its spec and implementation is identical to {@link ViewFs} .}} not sure what you mean here. Can you please add description on when this is used or what error it conveys? Once you address that I am +1 for the patch, if the test failure is unrelated to this.
          John George made changes -
          Attachment HADOOP-8014.patch [ 12521694 ]
          John George made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          John George made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          John George added a comment -

          In the new patch - Its spec and implementation is identical to {@link ViewFs}. not sure what you mean here. Can you please add description on when this is used or what error it conveys? Once you address that I am +1 for the patch, if the test failure is unrelated to this.

          Added a better description.
          TestViewFsTrash seemed to fail in earlier builds as well (eg: 829, 830).

          Show
          John George added a comment - In the new patch - Its spec and implementation is identical to {@link ViewFs}. not sure what you mean here. Can you please add description on when this is used or what error it conveys? Once you address that I am +1 for the patch, if the test failure is unrelated to this. Added a better description. TestViewFsTrash seemed to fail in earlier builds as well (eg: 829 , 830 ).
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12521694/HADOOP-8014.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 2 new or modified test files.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/832//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/832//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12521694/HADOOP-8014.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified test files. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/832//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/832//console This message is automatically generated.
          Hide
          Robert Joseph Evans added a comment -

          Thanks John, With Surresh's +1 and my own I have merged this into branch-0.23, branch-2, and trunk

          Show
          Robert Joseph Evans added a comment - Thanks John, With Surresh's +1 and my own I have merged this into branch-0.23, branch-2, and trunk
          Robert Joseph Evans made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Fix Version/s 0.23.3 [ 12320059 ]
          Fix Version/s 2.0.0 [ 12320352 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #2019 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2019/)
          HADOOP-8014. ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary (John George via bobby) (Revision 1310507)

          Result = FAILURE
          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310507
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/FileSystemTestHelper.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/TestChRootedFileSystem.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2019 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2019/ ) HADOOP-8014 . ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary (John George via bobby) (Revision 1310507) Result = FAILURE bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310507 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/FileSystemTestHelper.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/TestChRootedFileSystem.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #2094 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2094/)
          HADOOP-8014. ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary (John George via bobby) (Revision 1310507)

          Result = SUCCESS
          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310507
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/FileSystemTestHelper.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/TestChRootedFileSystem.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2094 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2094/ ) HADOOP-8014 . ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary (John George via bobby) (Revision 1310507) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310507 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/FileSystemTestHelper.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/TestChRootedFileSystem.java
          Hide
          Tsz Wo Nicholas Sze added a comment -

          Forgot to add the new file NotInMountpointException.java?

          Show
          Tsz Wo Nicholas Sze added a comment - Forgot to add the new file NotInMountpointException.java?
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #2032 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2032/)
          HADOOP-8014. ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary (John George via bobby) (Revision 1310507)

          Result = ABORTED
          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310507
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/FileSystemTestHelper.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/TestChRootedFileSystem.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2032 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2032/ ) HADOOP-8014 . ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary (John George via bobby) (Revision 1310507) Result = ABORTED bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310507 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/FileSystemTestHelper.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/TestChRootedFileSystem.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #2098 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2098/)
          HADOOP-8014. ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary (Revision 1310555)

          Result = SUCCESS
          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310555
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/NotInMountpointException.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2098 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2098/ ) HADOOP-8014 . ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary (Revision 1310555) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310555 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/NotInMountpointException.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #2023 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2023/)
          HADOOP-8014. ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary (Revision 1310555)

          Result = SUCCESS
          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310555
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/NotInMountpointException.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2023 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2023/ ) HADOOP-8014 . ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary (Revision 1310555) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310555 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/NotInMountpointException.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #2034 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2034/)
          HADOOP-8014. ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary (Revision 1310555)

          Result = ABORTED
          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310555
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/NotInMountpointException.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2034 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2034/ ) HADOOP-8014 . ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary (Revision 1310555) Result = ABORTED bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310555 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/NotInMountpointException.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #2099 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2099/)
          HDFS-3121. Add HDFS tests for HADOOP-8014 change. Contributed by John George. Missed adding the file in the earlier commit. (Revision 1310631)
          HDFS-3121. Add HDFS tests for HADOOP-8014 change. Contributed by John George. (Revision 1310630)

          Result = SUCCESS
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310631
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFsDefaultValue.java

          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310630
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2099 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2099/ ) HDFS-3121 . Add HDFS tests for HADOOP-8014 change. Contributed by John George. Missed adding the file in the earlier commit. (Revision 1310631) HDFS-3121 . Add HDFS tests for HADOOP-8014 change. Contributed by John George. (Revision 1310630) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310631 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFsDefaultValue.java suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310630 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #2024 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2024/)
          HDFS-3121. Add HDFS tests for HADOOP-8014 change. Contributed by John George. Missed adding the file in the earlier commit. (Revision 1310631)
          HDFS-3121. Add HDFS tests for HADOOP-8014 change. Contributed by John George. (Revision 1310630)

          Result = SUCCESS
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310631
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFsDefaultValue.java

          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310630
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2024 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2024/ ) HDFS-3121 . Add HDFS tests for HADOOP-8014 change. Contributed by John George. Missed adding the file in the earlier commit. (Revision 1310631) HDFS-3121 . Add HDFS tests for HADOOP-8014 change. Contributed by John George. (Revision 1310630) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310631 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFsDefaultValue.java suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310630 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #2035 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2035/)
          HDFS-3121. Add HDFS tests for HADOOP-8014 change. Contributed by John George. Missed adding the file in the earlier commit. (Revision 1310631)
          HDFS-3121. Add HDFS tests for HADOOP-8014 change. Contributed by John George. (Revision 1310630)

          Result = ABORTED
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310631
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFsDefaultValue.java

          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310630
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2035 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2035/ ) HDFS-3121 . Add HDFS tests for HADOOP-8014 change. Contributed by John George. Missed adding the file in the earlier commit. (Revision 1310631) HDFS-3121 . Add HDFS tests for HADOOP-8014 change. Contributed by John George. (Revision 1310630) Result = ABORTED suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310631 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFsDefaultValue.java suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310630 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-0.23-Build #220 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/220/)
          HADOOP-8014. ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary (Revision 1310557)
          svn merge -c 1310507 from trunk. FIXES: HADOOP-8014. ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary (John George via bobby) (Revision 1310513)

          Result = SUCCESS
          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310557
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/NotInMountpointException.java

          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310513
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/FileSystemTestHelper.java
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/TestChRootedFileSystem.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #220 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/220/ ) HADOOP-8014 . ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary (Revision 1310557) svn merge -c 1310507 from trunk. FIXES: HADOOP-8014 . ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary (John George via bobby) (Revision 1310513) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310557 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/NotInMountpointException.java bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310513 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/FileSystemTestHelper.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/TestChRootedFileSystem.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #1007 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1007/)
          HDFS-3121. Add HDFS tests for HADOOP-8014 change. Contributed by John George. Missed adding the file in the earlier commit. (Revision 1310631)
          HDFS-3121. Add HDFS tests for HADOOP-8014 change. Contributed by John George. (Revision 1310630)
          HADOOP-8014. ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary (Revision 1310555)
          HADOOP-8014. ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary (John George via bobby) (Revision 1310507)

          Result = FAILURE
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310631
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFsDefaultValue.java

          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310630
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt

          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310555
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/NotInMountpointException.java

          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310507
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/FileSystemTestHelper.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/TestChRootedFileSystem.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1007 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1007/ ) HDFS-3121 . Add HDFS tests for HADOOP-8014 change. Contributed by John George. Missed adding the file in the earlier commit. (Revision 1310631) HDFS-3121 . Add HDFS tests for HADOOP-8014 change. Contributed by John George. (Revision 1310630) HADOOP-8014 . ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary (Revision 1310555) HADOOP-8014 . ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary (John George via bobby) (Revision 1310507) Result = FAILURE suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310631 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFsDefaultValue.java suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310630 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310555 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/NotInMountpointException.java bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310507 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/FileSystemTestHelper.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/TestChRootedFileSystem.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1042 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1042/)
          HDFS-3121. Add HDFS tests for HADOOP-8014 change. Contributed by John George. Missed adding the file in the earlier commit. (Revision 1310631)
          HDFS-3121. Add HDFS tests for HADOOP-8014 change. Contributed by John George. (Revision 1310630)
          HADOOP-8014. ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary (Revision 1310555)
          HADOOP-8014. ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary (John George via bobby) (Revision 1310507)

          Result = SUCCESS
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310631
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFsDefaultValue.java

          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310630
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt

          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310555
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/NotInMountpointException.java

          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310507
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/FileSystemTestHelper.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/TestChRootedFileSystem.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1042 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1042/ ) HDFS-3121 . Add HDFS tests for HADOOP-8014 change. Contributed by John George. Missed adding the file in the earlier commit. (Revision 1310631) HDFS-3121 . Add HDFS tests for HADOOP-8014 change. Contributed by John George. (Revision 1310630) HADOOP-8014 . ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary (Revision 1310555) HADOOP-8014 . ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary (John George via bobby) (Revision 1310507) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310631 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFsDefaultValue.java suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310630 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310555 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/NotInMountpointException.java bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310507 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/FileSystemTestHelper.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/TestChRootedFileSystem.java
          Eli Collins made changes -
          Link This issue is related to HADOOP-8422 [ HADOOP-8422 ]
          Arun C Murthy made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Eli Collins made changes -
          Link This issue is related to HADOOP-8430 [ HADOOP-8430 ]
          Arun C Murthy made changes -
          Fix Version/s 2.0.2-alpha [ 12322473 ]
          Fix Version/s 2.0.0-alpha [ 12320352 ]
          Daryn Sharp made changes -
          Link This issue relates to HADOOP-9631 [ HADOOP-9631 ]
          Brandon Li made changes -
          Link This issue is related to HADOOP-10425 [ HADOOP-10425 ]

            People

            • Assignee:
              John George
              Reporter:
              Daryn Sharp
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development