Hadoop Common
  1. Hadoop Common
  2. HADOOP-7454 Common side of High Availability Framework (HDFS-1623)
  3. HADOOP-7970

All HAServiceProtocol methods have to throw IOException since they are invoked over the network

    Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: HA Branch (HDFS-1623)
    • Fix Version/s: None
    • Component/s: ha
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      HAServiceProtocol methods have to throw ioexception in addition to other exceptions since they are RPCs which are invoked over the network.

      1. HADOOP-7970.txt
        5 kB
        Hari Mankude
      2. HADOOP-7970.txt
        5 kB
        Hari Mankude
      3. HADOOP-7970.txt
        6 kB
        Hari Mankude
      4. HADOOP-7970.txt
        6 kB
        Hari Mankude

        Issue Links

          Activity

          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-HAbranch-build #45 (See https://builds.apache.org/job/Hadoop-Hdfs-HAbranch-build/45/)
          HADOOP-7970. HAServiceProtocol methods must throw IOException.Contributed by Hari Mankude.

          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1230351
          Files :

          • /hadoop/common/branches/HDFS-1623/hadoop-common-project/hadoop-common/CHANGES.HDFS-1623.txt
          • /hadoop/common/branches/HDFS-1623/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/FailoverController.java
          • /hadoop/common/branches/HDFS-1623/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/HAServiceProtocol.java
          • /hadoop/common/branches/HDFS-1623/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/HealthCheckFailedException.java
          • /hadoop/common/branches/HDFS-1623/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/ServiceFailedException.java
          • /hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-HAbranch-build #45 (See https://builds.apache.org/job/Hadoop-Hdfs-HAbranch-build/45/ ) HADOOP-7970 . HAServiceProtocol methods must throw IOException.Contributed by Hari Mankude. suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1230351 Files : /hadoop/common/branches/ HDFS-1623 /hadoop-common-project/hadoop-common/CHANGES. HDFS-1623 .txt /hadoop/common/branches/ HDFS-1623 /hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/FailoverController.java /hadoop/common/branches/ HDFS-1623 /hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/HAServiceProtocol.java /hadoop/common/branches/ HDFS-1623 /hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/HealthCheckFailedException.java /hadoop/common/branches/ HDFS-1623 /hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/ServiceFailedException.java /hadoop/common/branches/ HDFS-1623 /hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12510294/HADOOP-7970.txt
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/506//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12510294/HADOOP-7970.txt against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/506//console This message is automatically generated.
          Hide
          Suresh Srinivas added a comment -

          I committed the patch. Thank you Hari.

          Show
          Suresh Srinivas added a comment - I committed the patch. Thank you Hari.
          Hide
          Hari Mankude added a comment -

          Fix a typo

          Show
          Hari Mankude added a comment - Fix a typo
          Hide
          Hari Mankude added a comment -

          Attaching the common patch. Will close out hdfs-2783

          Show
          Hari Mankude added a comment - Attaching the common patch. Will close out hdfs-2783
          Hide
          Suresh Srinivas added a comment -

          Hari given that we are not running through Jenkins, can you attach the combined patch for common and HDFS?

          +1 for the common patch.

          Show
          Suresh Srinivas added a comment - Hari given that we are not running through Jenkins, can you attach the combined patch for common and HDFS? +1 for the common patch.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12510288/HADOOP-7970.txt
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/505//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12510288/HADOOP-7970.txt against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/505//console This message is automatically generated.
          Hide
          Aaron T. Myers added a comment -

          Hey Hari, test-patch is actually capable of dealing with a patch generated from either the repo root or one level up. The thing it can't do, however, is try to apply the patch to the correct branch - it always tries to apply the patch to trunk. Since this file doesn't exist on trunk, test-patch is never going to work for this patch.

          See this JIRA for more info: HADOOP-7435

          Show
          Aaron T. Myers added a comment - Hey Hari, test-patch is actually capable of dealing with a patch generated from either the repo root or one level up. The thing it can't do, however, is try to apply the patch to the correct branch - it always tries to apply the patch to trunk. Since this file doesn't exist on trunk, test-patch is never going to work for this patch. See this JIRA for more info: HADOOP-7435
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12510288/HADOOP-7970.txt
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/504//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12510288/HADOOP-7970.txt against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/504//console This message is automatically generated.
          Hide
          Hari Mankude added a comment -

          Attach patch with complete path

          Show
          Hari Mankude added a comment - Attach patch with complete path
          Hide
          Eli Collins added a comment -

          +1, this would make some of the code in the FailoverController cleaner (places where we need to catch exception could now catch IOE).

          Show
          Eli Collins added a comment - +1, this would make some of the code in the FailoverController cleaner (places where we need to catch exception could now catch IOE).
          Hide
          Aaron T. Myers added a comment -

          +1, I bumped into this problem when working on HDFS-2772. Thanks a lot for filing this, Hari.

          Given that HAServiceProtocol is actually under the hadoop-common project, perhaps this JIRA should be moved there as a sub-task of HADOOP-7454?

          Show
          Aaron T. Myers added a comment - +1, I bumped into this problem when working on HDFS-2772 . Thanks a lot for filing this, Hari. Given that HAServiceProtocol is actually under the hadoop-common project, perhaps this JIRA should be moved there as a sub-task of HADOOP-7454 ?

            People

            • Assignee:
              Hari Mankude
              Reporter:
              Hari Mankude
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development