Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Not A Problem
    • Affects Version/s: 0.24.0
    • Fix Version/s: None
    • Component/s: fs
    • Labels:
      None

      Description

      This is to fix Eli's comments on the parent task:

      This breaks a public API, why not preserve it but add in the improved one and update the docs to refer to it? Also, the test for this (HDFS-2070) should be done before the change.

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        1d 1h 48m 1 Eli Collins 10/Jan/12 05:03
        Eli Collins made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Not A Problem [ 8 ]
        Hide
        Eli Collins added a comment -

        Thanks Daryn, read your doc, and agree we're already incompat so this should be harmless (the new shell work is nice too btw!).

        Show
        Eli Collins added a comment - Thanks Daryn, read your doc, and agree we're already incompat so this should be harmless (the new shell work is nice too btw!).
        Daryn Sharp made changes -
        Attachment Grid_FsShellImpact.pdf [ 12509950 ]
        Hide
        Daryn Sharp added a comment -

        The incompatibilities should have been listed in the respective jiras, but I'll attach a doc with a summary of the known impact.

        Show
        Daryn Sharp added a comment - The incompatibilities should have been listed in the respective jiras, but I'll attach a doc with a summary of the known impact.
        Hide
        Eli Collins added a comment -

        What incompatibilities did the FsShell redesign introduce? At the least we should document them.

        Show
        Eli Collins added a comment - What incompatibilities did the FsShell redesign introduce? At the least we should document them.
        Hide
        Daryn Sharp added a comment -

        My thoughts are the redesign of FsShell introduced some incompatibilities, and the getmerge change is a rather small change that further improves the inconsistency of the shell commands. That said, I won't block making it backwards compat, but I think a deprecated warning should be emitted. Although a warning may introduce incompatibility if the calling script is checking stderr...

        Show
        Daryn Sharp added a comment - My thoughts are the redesign of FsShell introduced some incompatibilities, and the getmerge change is a rather small change that further improves the inconsistency of the shell commands. That said, I won't block making it backwards compat, but I think a deprecated warning should be emitted. Although a warning may introduce incompatibility if the calling script is checking stderr...
        Hide
        Eli Collins added a comment - - edited

        Why is it OK to break existing Hadoop scripts w/o at least first deprecating the option?

        Show
        Eli Collins added a comment - - edited Why is it OK to break existing Hadoop scripts w/o at least first deprecating the option?
        Hide
        Daryn Sharp added a comment -

        I'm not sure I agree with adding back the old behavior. It used what should have been a path argument to decide if newlines should be added. That behavior is inconsistent with all other commands.

        Show
        Daryn Sharp added a comment - I'm not sure I agree with adding back the old behavior. It used what should have been a path argument to decide if newlines should be added. That behavior is inconsistent with all other commands.
        Harsh J made changes -
        Fix Version/s 0.24.0 [ 12317652 ]
        Harsh J made changes -
        Component/s fs [ 12310689 ]
        Harsh J made changes -
        Field Original Value New Value
        Fix Version/s 0.24.0 [ 12317652 ]
        Harsh J created issue -

          People

          • Assignee:
            Harsh J
            Reporter:
            Harsh J
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development