Hadoop Common
  1. Hadoop Common
  2. HADOOP-7948

Shell scripts created by hadoop-dist/pom.xml to build tar do not properly propagate failure

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.23.1, 0.24.0
    • Fix Version/s: 0.23.1
    • Component/s: build
    • Labels:
      None
    • Environment:

      OSX

    • Hadoop Flags:
      Reviewed

      Description

      The run() function, as defined in dist-layout-stitching.sh and dist-tar-stitching, created in hadoop-dist/pom.xml, does not properly propagate the error code of a failing command. See the following:

          ...
          "${@}"                 # call fails with non-zero exit code
          if [ $? != 0 ]; then   
              echo               
              echo "Failed!"     
              echo               
              exit $?            # $?=result of echo above, likely 0, thus exit with code 0
          ...
      
      1. HADOOP-7948.patch
        1 kB
        Michajlo Matijkiw

        Activity

        Michajlo Matijkiw created issue -
        Michajlo Matijkiw made changes -
        Field Original Value New Value
        Status Open [ 1 ] Patch Available [ 10002 ]
        Michajlo Matijkiw made changes -
        Attachment HADOOP-7948.patch [ 12509343 ]
        Alejandro Abdelnur made changes -
        Assignee Michajlo Matijkiw [ cim_michajlomatijkiw ]
        Alejandro Abdelnur made changes -
        Fix Version/s 0.23.1 [ 12318884 ]
        Affects Version/s 0.24.0 [ 12317652 ]
        Affects Version/s 0.23.1 [ 12318884 ]
        Alejandro Abdelnur made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Resolution Fixed [ 1 ]
        Arun C Murthy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Michajlo Matijkiw
            Reporter:
            Michajlo Matijkiw
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development