Hadoop Common
  1. Hadoop Common
  2. HADOOP-7948

Shell scripts created by hadoop-dist/pom.xml to build tar do not properly propagate failure

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.23.1, 0.24.0
    • Fix Version/s: 0.23.1
    • Component/s: build
    • Labels:
      None
    • Environment:

      OSX

    • Hadoop Flags:
      Reviewed

      Description

      The run() function, as defined in dist-layout-stitching.sh and dist-tar-stitching, created in hadoop-dist/pom.xml, does not properly propagate the error code of a failing command. See the following:

          ...
          "${@}"                 # call fails with non-zero exit code
          if [ $? != 0 ]; then   
              echo               
              echo "Failed!"     
              echo               
              exit $?            # $?=result of echo above, likely 0, thus exit with code 0
          ...
      
      1. HADOOP-7948.patch
        1 kB
        Michajlo Matijkiw

        Activity

        Michajlo Matijkiw created issue -
        Hide
        Michajlo Matijkiw added a comment -

        Retain result of failing call and use it as exit code.

        Show
        Michajlo Matijkiw added a comment - Retain result of failing call and use it as exit code.
        Michajlo Matijkiw made changes -
        Field Original Value New Value
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Michajlo Matijkiw added a comment -

        Forgot to attach this, retains result of call and passes it to exit.

        Show
        Michajlo Matijkiw added a comment - Forgot to attach this, retains result of call and passes it to exit.
        Michajlo Matijkiw made changes -
        Attachment HADOOP-7948.patch [ 12509343 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12509343/HADOOP-7948.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/493//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12509343/HADOOP-7948.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/493//console This message is automatically generated.
        Hide
        Alejandro Abdelnur added a comment -

        +1

        Show
        Alejandro Abdelnur added a comment - +1
        Alejandro Abdelnur made changes -
        Assignee Michajlo Matijkiw [ cim_michajlomatijkiw ]
        Alejandro Abdelnur made changes -
        Fix Version/s 0.23.1 [ 12318884 ]
        Affects Version/s 0.24.0 [ 12317652 ]
        Affects Version/s 0.23.1 [ 12318884 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #1563 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1563/)
        HADOOP-7948. Shell scripts created by hadoop-dist/pom.xml to build tar do not properly propagate failure. (cim_michajlomatijkiw via tucu)

        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1227225
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-dist/pom.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1563 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1563/ ) HADOOP-7948 . Shell scripts created by hadoop-dist/pom.xml to build tar do not properly propagate failure. (cim_michajlomatijkiw via tucu) tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1227225 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-dist/pom.xml
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #1491 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1491/)
        HADOOP-7948. Shell scripts created by hadoop-dist/pom.xml to build tar do not properly propagate failure. (cim_michajlomatijkiw via tucu)

        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1227225
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-dist/pom.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1491 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1491/ ) HADOOP-7948 . Shell scripts created by hadoop-dist/pom.xml to build tar do not properly propagate failure. (cim_michajlomatijkiw via tucu) tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1227225 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-dist/pom.xml
        Hide
        Alejandro Abdelnur added a comment -

        Thanks Michajlo, integrated in trunk and branch-0.23

        Show
        Alejandro Abdelnur added a comment - Thanks Michajlo, integrated in trunk and branch-0.23
        Alejandro Abdelnur made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Commit #325 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/325/)
        Merge -r 1227224:1227225 from trunk to branch. FIXES: HADOOP-7948

        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1227234
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-dist/pom.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Commit #325 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/325/ ) Merge -r 1227224:1227225 from trunk to branch. FIXES: HADOOP-7948 tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1227234 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-dist/pom.xml
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-0.23-Commit #336 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/336/)
        Merge -r 1227224:1227225 from trunk to branch. FIXES: HADOOP-7948

        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1227234
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-dist/pom.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Common-0.23-Commit #336 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/336/ ) Merge -r 1227224:1227225 from trunk to branch. FIXES: HADOOP-7948 tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1227234 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-dist/pom.xml
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #1512 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1512/)
        HADOOP-7948. Shell scripts created by hadoop-dist/pom.xml to build tar do not properly propagate failure. (cim_michajlomatijkiw via tucu)

        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1227225
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-dist/pom.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1512 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1512/ ) HADOOP-7948 . Shell scripts created by hadoop-dist/pom.xml to build tar do not properly propagate failure. (cim_michajlomatijkiw via tucu) tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1227225 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-dist/pom.xml
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Commit #347 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/347/)
        Merge -r 1227224:1227225 from trunk to branch. FIXES: HADOOP-7948

        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1227234
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-dist/pom.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Commit #347 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/347/ ) Merge -r 1227224:1227225 from trunk to branch. FIXES: HADOOP-7948 tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1227234 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-dist/pom.xml
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #916 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/916/)
        HADOOP-7948. Shell scripts created by hadoop-dist/pom.xml to build tar do not properly propagate failure. (cim_michajlomatijkiw via tucu)

        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1227225
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-dist/pom.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #916 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/916/ ) HADOOP-7948 . Shell scripts created by hadoop-dist/pom.xml to build tar do not properly propagate failure. (cim_michajlomatijkiw via tucu) tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1227225 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-dist/pom.xml
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #129 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/129/)
        Merge -r 1227224:1227225 from trunk to branch. FIXES: HADOOP-7948

        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1227234
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-dist/pom.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #129 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/129/ ) Merge -r 1227224:1227225 from trunk to branch. FIXES: HADOOP-7948 tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1227234 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-dist/pom.xml
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Build #151 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/151/)
        Merge -r 1227224:1227225 from trunk to branch. FIXES: HADOOP-7948

        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1227234
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-dist/pom.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Build #151 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/151/ ) Merge -r 1227224:1227225 from trunk to branch. FIXES: HADOOP-7948 tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1227234 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-dist/pom.xml
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #949 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/949/)
        HADOOP-7948. Shell scripts created by hadoop-dist/pom.xml to build tar do not properly propagate failure. (cim_michajlomatijkiw via tucu)

        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1227225
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-dist/pom.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #949 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/949/ ) HADOOP-7948 . Shell scripts created by hadoop-dist/pom.xml to build tar do not properly propagate failure. (cim_michajlomatijkiw via tucu) tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1227225 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-dist/pom.xml
        Arun C Murthy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        3m 14s 1 Michajlo Matijkiw 03/Jan/12 21:31
        Patch Available Patch Available Resolved Resolved
        20h 7m 1 Alejandro Abdelnur 04/Jan/12 17:38
        Resolved Resolved Closed Closed
        60d 9h 10m 1 Arun C Murthy 05/Mar/12 02:49

          People

          • Assignee:
            Michajlo Matijkiw
            Reporter:
            Michajlo Matijkiw
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development