Hadoop Common
  1. Hadoop Common
  2. HADOOP-7902

skipping name rules setting (if already set) should be done on UGI initialization only

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.1, 0.24.0
    • Fix Version/s: 0.23.1, 0.24.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Both TestDelegationToken and TestOfflineEditsViewer are currently failing.

      1. HDFS-2648.patch
        3 kB
        Alejandro Abdelnur

        Activity

        Hide
        Uma Maheswara Rao G added a comment -

        TestOfflineEditsViewer also failing with the same reason.

        java.lang.IllegalArgumentException: Illegal principal name JobTracker/foo.com@FOO.COM
        at org.apache.hadoop.security.User.<init>(User.java:50)
        at org.apache.hadoop.security.User.<init>(User.java:43)
        at org.apache.hadoop.security.UserGroupInformation.createRemoteUser(UserGroupInformation.java:834)
        at org.apache.hadoop.hdfs.server.namenode.OfflineEditsViewerHelper.runOperations(OfflineEditsViewerHelper.java:202)
        at org.apache.hadoop.hdfs.server.namenode.OfflineEditsViewerHelper.generateEdits(OfflineEditsViewerHelper.java:72)
        at org.apache.hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer.testGenerated(TestOfflineEditsViewer.java:97)
        ........
        ........
        Caused by: org.apache.hadoop.security.authentication.util.KerberosName$NoMatchingRule: No rules applied to JobTracker/foo.com@FOO.COM
        at org.apache.hadoop.security.authentication.util.KerberosName.getShortName(KerberosName.java:377)
        at org.apache.hadoop.security.User.<init>(User.java:48)
        ... 28 more

        Show
        Uma Maheswara Rao G added a comment - TestOfflineEditsViewer also failing with the same reason. java.lang.IllegalArgumentException: Illegal principal name JobTracker/foo.com@FOO.COM at org.apache.hadoop.security.User.<init>(User.java:50) at org.apache.hadoop.security.User.<init>(User.java:43) at org.apache.hadoop.security.UserGroupInformation.createRemoteUser(UserGroupInformation.java:834) at org.apache.hadoop.hdfs.server.namenode.OfflineEditsViewerHelper.runOperations(OfflineEditsViewerHelper.java:202) at org.apache.hadoop.hdfs.server.namenode.OfflineEditsViewerHelper.generateEdits(OfflineEditsViewerHelper.java:72) at org.apache.hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer.testGenerated(TestOfflineEditsViewer.java:97) ........ ........ Caused by: org.apache.hadoop.security.authentication.util.KerberosName$NoMatchingRule: No rules applied to JobTracker/foo.com@FOO.COM at org.apache.hadoop.security.authentication.util.KerberosName.getShortName(KerberosName.java:377) at org.apache.hadoop.security.User.<init>(User.java:48) ... 28 more
        Hide
        Tsz Wo Nicholas Sze added a comment -

        Thanks Uma for the quick comment. Revised the summary and the description.

        Show
        Tsz Wo Nicholas Sze added a comment - Thanks Uma for the quick comment. Revised the summary and the description.
        Hide
        Alejandro Abdelnur added a comment -

        Identified the problem, the skipping of setting name rules is done in the wrong place. working on a patch.

        Show
        Alejandro Abdelnur added a comment - Identified the problem, the skipping of setting name rules is done in the wrong place. working on a patch.
        Hide
        Alejandro Abdelnur added a comment -

        skipping the setting the KerberosName name rules if already set should be done on UGI initialization only (where the initialization is done with a new Configuration()).

        When UGI is being configured passing a configuration (ie NN initialization) it should not skip the setting of the namerules.

        Failing tests are not passing, check that the tests affected by HADOOP-7887 are also passing.

        Show
        Alejandro Abdelnur added a comment - skipping the setting the KerberosName name rules if already set should be done on UGI initialization only (where the initialization is done with a new Configuration()). When UGI is being configured passing a configuration (ie NN initialization) it should not skip the setting of the namerules. Failing tests are not passing, check that the tests affected by HADOOP-7887 are also passing.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12506742/HDFS-2648.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1668//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12506742/HDFS-2648.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1668//console This message is automatically generated.
        Hide
        Alejandro Abdelnur added a comment -

        Moved JIRA to common as the changes are in common and hudson barks at the patch if in Hadoop HDFS.

        The 2 failing HDFS tests go back to green with the patch.

        Show
        Alejandro Abdelnur added a comment - Moved JIRA to common as the changes are in common and hudson barks at the patch if in Hadoop HDFS. The 2 failing HDFS tests go back to green with the patch.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12506742/HDFS-2648.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 javadoc. The javadoc tool appears to have generated 5 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/457//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/457//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12506742/HDFS-2648.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javadoc. The javadoc tool appears to have generated 5 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/457//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/457//console This message is automatically generated.
        Hide
        Aaron T. Myers added a comment -

        +1, the patch looks good to me. I'm confident the javadoc warnings are unrelated, since this patch doesn't update any javadocs.

        Show
        Aaron T. Myers added a comment - +1, the patch looks good to me. I'm confident the javadoc warnings are unrelated, since this patch doesn't update any javadocs.
        Hide
        Alejandro Abdelnur added a comment -

        committed to trunk & branch-0.23

        Show
        Alejandro Abdelnur added a comment - committed to trunk & branch-0.23
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #1464 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1464/)
        HADOOP-7902. skipping name rules setting (if already set) should be done on UGI initialization only. (tucu)

        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1212591
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/HadoopKerberosName.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1464 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1464/ ) HADOOP-7902 . skipping name rules setting (if already set) should be done on UGI initialization only. (tucu) tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1212591 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/HadoopKerberosName.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #1390 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1390/)
        HADOOP-7902. skipping name rules setting (if already set) should be done on UGI initialization only. (tucu)

        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1212591
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/HadoopKerberosName.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1390 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1390/ ) HADOOP-7902 . skipping name rules setting (if already set) should be done on UGI initialization only. (tucu) tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1212591 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/HadoopKerberosName.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Commit #254 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/254/)
        Merge -r 1212590:1212591 from trunk to branch. FIXES: HADOOP-7902

        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1212592
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/HadoopKerberosName.java
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Commit #254 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/254/ ) Merge -r 1212590:1212591 from trunk to branch. FIXES: HADOOP-7902 tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1212592 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/HadoopKerberosName.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-0.23-Commit #264 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/264/)
        Merge -r 1212590:1212591 from trunk to branch. FIXES: HADOOP-7902

        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1212592
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/HadoopKerberosName.java
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-0.23-Commit #264 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/264/ ) Merge -r 1212590:1212591 from trunk to branch. FIXES: HADOOP-7902 tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1212592 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/HadoopKerberosName.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #1413 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1413/)
        HADOOP-7902. skipping name rules setting (if already set) should be done on UGI initialization only. (tucu)

        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1212591
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/HadoopKerberosName.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1413 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1413/ ) HADOOP-7902 . skipping name rules setting (if already set) should be done on UGI initialization only. (tucu) tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1212591 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/HadoopKerberosName.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Commit #274 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/274/)
        Merge -r 1212590:1212591 from trunk to branch. FIXES: HADOOP-7902

        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1212592
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/HadoopKerberosName.java
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Commit #274 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/274/ ) Merge -r 1212590:1212591 from trunk to branch. FIXES: HADOOP-7902 tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1212592 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/HadoopKerberosName.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #103 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/103/)
        Merge -r 1212590:1212591 from trunk to branch. FIXES: HADOOP-7902

        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1212592
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/HadoopKerberosName.java
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #103 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/103/ ) Merge -r 1212590:1212591 from trunk to branch. FIXES: HADOOP-7902 tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1212592 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/HadoopKerberosName.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Build #121 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/121/)
        Merge -r 1212590:1212591 from trunk to branch. FIXES: HADOOP-7902

        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1212592
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/HadoopKerberosName.java
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Build #121 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/121/ ) Merge -r 1212590:1212591 from trunk to branch. FIXES: HADOOP-7902 tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1212592 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/HadoopKerberosName.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #890 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/890/)
        HADOOP-7902. skipping name rules setting (if already set) should be done on UGI initialization only. (tucu)

        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1212591
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/HadoopKerberosName.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #890 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/890/ ) HADOOP-7902 . skipping name rules setting (if already set) should be done on UGI initialization only. (tucu) tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1212591 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/HadoopKerberosName.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #923 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/923/)
        HADOOP-7902. skipping name rules setting (if already set) should be done on UGI initialization only. (tucu)

        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1212591
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/HadoopKerberosName.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #923 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/923/ ) HADOOP-7902 . skipping name rules setting (if already set) should be done on UGI initialization only. (tucu) tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1212591 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/HadoopKerberosName.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java

          People

          • Assignee:
            Alejandro Abdelnur
            Reporter:
            Tsz Wo Nicholas Sze
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development